Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve option to mark all notifications read #16044

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Improve option to mark all notifications read #16044

merged 5 commits into from
Jun 1, 2023

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented May 29, 2023

Fixes #14983

Summary

  • Use correct icon to mark notifications as read
  • Add support for the disabled state in action drawer actions
  • Update quo2 preview drawers > action-drawers
  • Rewrite the action drawer component spec to use our test helpers

Steps to test

  1. Open Activity Center with at least one notification and all of them read.
  2. Open the hamburger menu and check that the option to mark all notifications as read is disabled.

You can also check the disabled state in Quo 2 Preview > drawers > action-drawers

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented May 29, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2a5c1ad #1 2023-05-29 15:37:45 ~5 min android 🤖apk 📲
✔️ 2a5c1ad #1 2023-05-29 15:38:03 ~5 min android-e2e 🤖apk 📲
✔️ 2a5c1ad #1 2023-05-29 15:39:47 ~7 min ios 📱ipa 📲
✔️ 2a5c1ad #1 2023-05-29 15:41:14 ~9 min tests 📄log
✔️ dd8c31c #2 2023-05-31 17:05:20 ~6 min android 🤖apk 📲
✔️ dd8c31c #2 2023-05-31 17:06:57 ~8 min android-e2e 🤖apk 📲
✔️ dd8c31c #2 2023-05-31 17:10:47 ~11 min ios 📱ipa 📲
✔️ dd8c31c #2 2023-05-31 17:13:33 ~14 min tests 📄log

smohamedjavid
smohamedjavid approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alwx alwx assigned alwx and unassigned alwx May 29, 2023
alwx
alwx approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@alwx alwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ilmotta ilmotta force-pushed the improve-option-to-mark-all-notifications-read branch from 2a5c1ad to dd8c31c Compare May 31, 2023 16:58
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 32
Failed tests: 2
Passed tests: 30
Not executed tests: 1

IDs of not executed tests: 702850 

IDs of failed tests: 702838,702851

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 
    Test setup failed: medium/test_activity_center.py:13: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
 cannot unpack non-iterable NoneType object



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (30)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_pin_messages, id: 702732
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    2. test_community_message_delete, id: 702839
    Device sessions

    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_one_image_send_reply, id: 702859
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    8. test_community_mentions_push_notification, id: 702786
    Device sessions

    9. test_community_several_images_send_reply, id: 703194
    Device sessions

    10. test_community_leave, id: 702845
    Device sessions

    11. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    7. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    8. test_1_1_chat_edit_message, id: 702855
    Device sessions

    9. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @ilmotta ilmotta merged commit 0dd3cb5 into develop Jun 1, 2023
    @ilmotta ilmotta deleted the improve-option-to-mark-all-notifications-read branch June 1, 2023 00:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @alwx alwx alwx approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @ilmotta ilmotta

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Improve UX when you tap "Mark all notifications as read" in AC and there is no unread notifications
    4 participants
    @ilmotta @status-im-auto @alwx @smohamedjavid