Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: zoomable component #16022

Merged
merged 2 commits into from
May 31, 2023
Merged

refactor: zoomable component #16022

merged 2 commits into from
May 31, 2023

Conversation

OmarBasem
Copy link
Contributor

@OmarBasem OmarBasem commented May 25, 2023 •
edited
Loading

This PR refactors zoomable image component to use functional components properly.

@OmarBasem OmarBasem self-assigned this May 25, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 25, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (1)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ aa6d9f9 #1 2023-05-25 05:33:36 ~3 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b5a03ad #2 2023-05-25 05:41:16 ~5 min android-e2e 🤖apk 📲
✔️ b5a03ad #2 2023-05-25 05:41:45 ~6 min ios 📱ipa 📲
✔️ b5a03ad #2 2023-05-25 05:43:30 ~7 min android 🤖apk 📲
✔️ b5a03ad #2 2023-05-25 05:44:52 ~9 min tests 📄log
✔️ 2bc05fe #3 2023-05-31 05:50:30 ~5 min android 🤖apk 📲
✔️ 2bc05fe #3 2023-05-31 05:50:45 ~6 min android-e2e 🤖apk 📲
✔️ 2bc05fe #3 2023-05-31 05:52:37 ~8 min ios 📱ipa 📲
✔️ 2bc05fe #3 2023-05-31 05:53:45 ~9 min tests 📄log

@status-im-auto
Copy link
Member

97% of end-end tests have passed

Total executed tests: 33
Failed tests: 1
Passed tests: 32

IDs of failed tests: 702838

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (32)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_mentions_push_notification, id: 702786
    Device sessions

    6. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    7. test_community_leave, id: 702845
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    9. test_community_message_delete, id: 702839
    Device sessions

    10. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    11. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    ilmotta
    ilmotta approved these changes May 26, 2023
    View reviewed changes
    Copy link
    Contributor

    @ilmotta ilmotta left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks @OmarBasem. I shared some suggestions, but no blockers.

    src/status_im2/contexts/chat/lightbox/zoomable_image/utils.cljs Show resolved Hide resolved
    src/status_im2/contexts/chat/lightbox/zoomable_image/view.cljs Show resolved Hide resolved
    src/status_im2/contexts/chat/lightbox/zoomable_image/view.cljs Show resolved Hide resolved
    @OmarBasem
    refactor: zoomable comp
    bcdf8d6 
    fix: nickname ios padding

updates

updates

updates

udpates

updates

updates

review

revert podfile.lock

updates

refactor
    @OmarBasem
    lint
    2bc05fe
    @OmarBasem OmarBasem merged commit 2b701f9 into develop May 31, 2023
    @OmarBasem OmarBasem deleted the refactor-zoomable branch May 31, 2023 06:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @ulisesmac ulisesmac ulisesmac approved these changes

    Assignees

    @OmarBasem OmarBasem

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @OmarBasem @status-im-auto @ilmotta @ulisesmac