Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new login endpoint #16013

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Use new login endpoint #16013

merged 1 commit into from
Jun 20, 2023

Conversation

cammellos
Copy link
Contributor

@cammellos cammellos commented May 24, 2023 •
edited
Loading

Use new login endpoint
status-im/status-go@7586452...3559636

This commit changes the login endpoint so that it uses LoginAccount.
The main difference is that is consistent with the two others we use for
creation/importing, and this will override the networks and use the
secrets provided.

This should allow us in theory to remove a fair amount of code (anything to do with node config, but that would be a separate PR)

@status-im-auto
Copy link
Member

status-im-auto commented May 24, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (42)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 55de32a #1 2023-05-24 15:14:53 ~8 min ios 📱ipa 📲
✔️ 55de32a #1 2023-05-24 15:14:56 ~8 min android 🤖apk 📲
✔️ 55de32a #1 2023-05-24 15:15:47 ~9 min android-e2e 🤖apk 📲
✔️ 55de32a #1 2023-05-24 15:16:59 ~10 min tests 📄log
❌ 25b744c #2 2023-05-25 10:12:21 ~3 min ios 📄log
❌ 29cf5bd #3 2023-05-25 10:27:13 ~3 min ios 📄log
❌ 29cf5bd #3 2023-05-25 10:31:42 ~8 min android-e2e 📄log
❌ 29cf5bd #3 2023-05-25 10:32:37 ~9 min android 📄log
❌ 29cf5bd #3 2023-05-25 10:33:02 ~9 min tests 📄log
❌ d6cf85d #4 2023-05-25 10:39:00 ~3 min ios 📄log
❌ d6cf85d #4 2023-05-25 10:41:41 ~6 min android 📄log
❌ d6cf85d #4 2023-05-25 10:44:52 ~9 min tests 📄log
❌ d6cf85d #4 2023-05-25 10:46:23 ~11 min android-e2e 📄log
❌ b19f9c7 #5 2023-05-25 11:25:17 ~5 min tests 📄log
✔️ 0d3ab81 #6 2023-05-25 11:33:28 ~5 min android 🤖apk 📲
✔️ 0d3ab81 #6 2023-05-25 11:34:46 ~6 min android-e2e 🤖apk 📲
✔️ 0d3ab81 #6 2023-05-25 11:36:45 ~8 min ios 📱ipa 📲
✔️ 0d3ab81 #6 2023-05-25 11:37:02 ~9 min tests 📄log
✔️ 674155b #7 2023-05-25 15:20:36 ~9 min tests 📄log
✔️ 674155b #7 2023-05-25 15:20:48 ~9 min android-e2e 🤖apk 📲
✔️ 674155b #7 2023-05-25 15:20:53 ~9 min android 🤖apk 📲
✔️ 674155b #7 2023-05-25 15:38:33 ~27 min ios 📱ipa 📲
✔️ e50c9ff #8 2023-05-25 15:49:08 ~7 min android-e2e 🤖apk 📲
✔️ e50c9ff #8 2023-05-25 15:49:55 ~8 min ios 📱ipa 📲
✔️ e50c9ff #8 2023-05-25 15:50:20 ~8 min android 🤖apk 📲
✔️ e50c9ff #8 2023-05-25 15:50:26 ~9 min tests 📄log
✔️ 1c46a4c #9 2023-05-25 16:08:07 ~7 min android 🤖apk 📲
✔️ 1c46a4c #9 2023-05-25 16:08:26 ~8 min android-e2e 🤖apk 📲
✔️ 1c46a4c #9 2023-05-25 16:09:13 ~8 min ios 📱ipa 📲
✔️ 1c46a4c #9 2023-05-25 16:09:43 ~9 min tests 📄log
✔️ 3497fc1 #11 2023-05-29 11:49:46 ~8 min ios 📱ipa 📲
✔️ 3497fc1 #11 2023-05-29 11:52:52 ~11 min android 🤖apk 📲
✔️ 3497fc1 #11 2023-05-29 11:53:03 ~11 min android-e2e 🤖apk 📲
✔️ 3497fc1 #11 2023-05-29 11:56:12 ~14 min tests 📄log
❌ 546236d #13 2023-06-16 15:29:30 ~15 sec android-e2e 📄log
❌ 546236d #13 2023-06-16 15:29:41 ~26 sec android 📄log
❌ 546236d #13 2023-06-16 15:30:06 ~51 sec tests 📄log
❌ 546236d #13 2023-06-16 15:31:17 ~2 min ios 📄log
✔️ ea3b8fe #14 2023-06-16 15:40:51 ~5 min android-e2e 🤖apk 📲
✔️ ea3b8fe #14 2023-06-16 15:41:18 ~5 min android 🤖apk 📲
✔️ ea3b8fe #14 2023-06-16 15:42:24 ~6 min ios 📱ipa 📲
✔️ ea3b8fe #14 2023-06-16 15:43:27 ~7 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 45a4a2d #15 2023-06-19 13:21:30 ~6 min android 🤖apk 📲
✔️ 45a4a2d #15 2023-06-19 13:22:48 ~7 min android-e2e 🤖apk 📲
✔️ 45a4a2d #15 2023-06-19 13:22:57 ~8 min ios 📱ipa 📲
✔️ 45a4a2d #15 2023-06-19 13:27:01 ~12 min tests 📄log
✔️ 66cd3ed #16 2023-06-20 15:59:21 ~6 min android 🤖apk 📲
✔️ 66cd3ed #16 2023-06-20 16:00:03 ~6 min ios 📱ipa 📲
✔️ 66cd3ed #16 2023-06-20 16:01:36 ~8 min tests 📄log

@cammellos cammellos force-pushed the chore/login-endpoint branch 5 times, most recently from 1c46a4c to aebaa7d Compare May 29, 2023 11:39
@cammellos cammellos changed the title wip Use new login endpoint May 29, 2023
@cammellos cammellos marked this pull request as ready for review May 29, 2023 11:44
@status-im-auto
Copy link
Member

61% of end-end tests have passed

Total executed tests: 33
Failed tests: 13
Passed tests: 20

IDs of failed tests: 702783,702733,702782,702730,702859,702958,702957,702732,702851,703194,702894,702731,702855

Failed tests (13)

Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 1: Looking for activity center element: 'receiver'
    Device 1: Find `Button` by `accessibility id`: `activity-center-open-more` 

    medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.more_options_activity_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `activity-center-open-more` is not found on the screen



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1253: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!

    [[Issue with messages not being sent for a long time]]

    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Tap on found: Button
    Device 1: Getting PN by 'DELETE ME' 

    critical/chats/test_1_1_public_chats.py:1210: in test_1_1_chat_text_message_delete_push_disappear
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to 'Delivered' after 60 s

    [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]]

    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Long press on Button until expected element is shown
    Device 1: Find Button by xpath: //*[@text="Reply"] 

    critical/chats/test_1_1_public_chats.py:895: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_1.quote_message(emoji_unicode)
../views/chat_view.py:999: in quote_message
    self.reply_message_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="Reply"]` is not found on the screen



    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730

    Device 1: Long press on ChatElementByText until expected element is shown
    Device 1: Find Button by accessibility id: reaction-thumbs-up 

    critical/chats/test_1_1_public_chats.py:868: in test_1_1_chat_message_reaction
    self.chat_1.set_reaction(message_from_sender)
../views/chat_view.py:1015: in set_reaction
    element.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `reaction-thumbs-up` is not found on the screen



    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    6. test_1_1_chat_edit_message, id: 702855

    Device 2: Find Text by xpath: //*[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']
    Device 2: Tap on found: Text 

    critical/chats/test_1_1_public_chats.py:1142: in test_1_1_chat_edit_message
    self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:228: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sending

    [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]]

    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: base_test_case.py:355: in setup_method
    driver.execute_script("sauce:context=Started %s" % method.__name__)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script
    return self.execute(command, {
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
    raise wde
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
    super().check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response
    raise exception_class(value)
 ERROR The test with session id 1f97f84bc89e4b66997e6ca7cbb51ea2 has already finished, and can't receive further commands.
E   You can learn more at https://app.eu-central-1.saucelabs.com/tests/1f97f84bc89e4b66997e6ca7cbb51ea2
E   For help, please check https://docs.saucelabs.com/dev/error-messages



    2. test_activity_center_mentions, id: 702957 

    Test setup failed: base_test_case.py:355: in setup_method
    driver.execute_script("sauce:context=Started %s" % method.__name__)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script
    return self.execute(command, {
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
    raise wde
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
    super().check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response
    raise exception_class(value)
 ERROR The test with session id 1f97f84bc89e4b66997e6ca7cbb51ea2 has already finished, and can't receive further commands.
E   You can learn more at https://app.eu-central-1.saucelabs.com/tests/1f97f84bc89e4b66997e6ca7cbb51ea2
E   For help, please check https://docs.saucelabs.com/dev/error-messages



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859

    Device 1: Find RepliedMessageText by xpath: //*[starts-with(@text,'reply to image')]/preceding::android.widget.TextView[@content-desc='quoted-message']
    Device 1: RepliedMessageText is Image 

    critical/test_public_chat_browsing.py:548: in test_community_one_image_send_reply
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Reply message was not received by the sender



    Device sessions

    2. test_community_several_images_send_reply, id: 703194

    Device 1: Find RepliedMessageText by xpath: //*[starts-with(@text,'reply to gallery')]/preceding::android.widget.TextView[@content-desc='quoted-message']
    Device 1: RepliedMessageText is Image 

    critical/test_public_chat_browsing.py:571: in test_community_several_images_send_reply
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Reply message was not received by the sender



    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894

    Device 2: Tap on found: Button
    Device 2: Find Button by xpath: //*[@text="# general"] 

    critical/test_public_chat_browsing.py:735: in test_community_contact_block_unblock_offline
    [home.jump_to_card_by_text('# %s' % self.channel_name) for home in [self.home_1, self.home_2]]</b>
critical/test_public_chat_browsing.py:735: in <listcomp>
    [home.jump_to_card_by_text('# %s' % self.channel_name) for home in [self.home_1, self.home_2]]</b>
../views/base_view.py:613: in jump_to_card_by_text
    self.element_by_text(text).click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[@text="# general"]` is not found on the screen



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (20)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    4. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    5. test_community_message_edit, id: 702843
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_unread_messages_badge, id: 702841
    Device sessions

    8. test_community_mentions_push_notification, id: 702786
    Device sessions

    9. test_community_leave, id: 702845
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @cammellos hello! Thank you for the PR. Could you please rebase the PR? Sorry for pinging you, I could do it myself but there are conflicts that need to be resolved during rebasing.

    @cammellos cammellos force-pushed the chore/login-endpoint branch 3 times, most recently from 546236d to ea3b8fe Compare June 16, 2023 15:35
    @cammellos
    Copy link
    Contributor Author

    @pavloburykh thanks for the ping, rebased!

    @status-im-auto
    Copy link
    Member

    82% of end-end tests have passed

    Total executed tests: 33
Failed tests: 6
Passed tests: 27

    IDs of failed tests: 703086,702783,702733,702732,702894,702731

    Failed tests (6)

    Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Find Button by accessibility id: mark-as-read
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:790: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Commmunity element



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 2: Tap on found: Button
    Device 2: Find Button by xpath: //*[@text="# general"] 

    critical/test_public_chat_browsing.py:735: in test_community_contact_block_unblock_offline
    [home.jump_to_card_by_text('# %s' % self.channel_name) for home in [self.home_1, self.home_2]]</b>
critical/test_public_chat_browsing.py:735: in <listcomp>
    [home.jump_to_card_by_text('# %s' % self.channel_name) for home in [self.home_1, self.home_2]]</b>
../views/base_view.py:613: in jump_to_card_by_text
    self.element_by_text(text).click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[@text="# general"]` is not found on the screen



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1253: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!

    [[Issue with messages not being sent for a long time]]

    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Tap on found: Button
    Device 1: Getting PN by 'DELETE ME' 

    critical/chats/test_1_1_public_chats.py:1210: in test_1_1_chat_text_message_delete_push_disappear
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to 'Delivered' after 60 s

    [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]]

    Device sessions

    3. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (27)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_mentions_push_notification, id: 702786
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_several_images_send_reply, id: 703194
    Device sessions

    10. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @pavloburykh pavloburykh self-assigned this Jun 19, 2023
    @pavloburykh
    Copy link
    Contributor

    @cammellos PR overall PR looks LGTM.

    Though while testing I have faced messages delivery issues. Could you please check the logs and see if it could be PR related? Yet I was not able to reproduce problem on nightly build.

    On video below you can observe that messages sent from User A to User B (and vica-verse) are not delivered until app re-login.

    messages_not_delivered1.mp4

    User_Android.zip
    User_IOS.zip

    If the issue is not PR related - then PR is ready for merge. Meanwhile I will try to reproduce issue on nightly.

    @pavloburykh
    Copy link
    Contributor

    Though while testing I have faced messages delivery issues.

    @cammellos I think this is not a PR issues. We are facing delivery issues in nightly in our e2e tests. So it should be logged and addressed separately.

    I believe this PR can be merged if you have not found anything suspicious in attached logs that might show relation of delivery issues to current PR changes.

    @cammellos
    Use new login endpoint
    66cd3ed 
    status-im/status-go@47711c4...47711c4

This commit changes the login endpoint so that it uses LoginAccount.
The main difference is that is consistent with the two others we use for
creation/importing, and this will override the networks and use the
secrets provided.
    @cammellos cammellos merged commit 66cd3ed into develop Jun 20, 2023
    @cammellos cammellos deleted the chore/login-endpoint branch June 20, 2023 15:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @rasom rasom rasom approved these changes

    @erikseppanen erikseppanen erikseppanen approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    Assignees

    @cammellos cammellos

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @cammellos @status-im-auto @pavloburykh @erikseppanen @rasom @Parveshdhull @flexsurfer