[Fix] QR scanner scanning QR when user moved to next screen #16012

smohamedjavid · 2023-05-24T14:56:53Z

Summary

This PR fixes the QR scanner that scans the QR code when the user is moved to the next screen (:syncing-progress).

The bug was caused when due to the navigational stack. The "QR scanner" screen will be behind the "Syncing devices" screen, and the QR scanner reset after 3 seconds to scan/process any QR code. The fix was to ensure the scanner scan/process the data only when the user is on the "QR scanner" screen.

Platforms

Android
iOS

Steps to test

Open Status
Navigate to Sign in
Enable access to the camera
Point the camera at an invalid QR code. (for instance, a QR code that has been used before)
Check if the user gets redirected again to the Something went wrong screen more than once.

status: ready

status-im-auto · 2023-05-24T15:03:47Z

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`e248993`	#1	2023-05-24 15:03:47	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`e248993`	#1	2023-05-24 15:03:50	~6 min	`android`	🤖`apk` 📲
✔️	`e248993`	#1	2023-05-24 15:04:18	~7 min	`ios`	📱`ipa` 📲
✔️	`e248993`	#1	2023-05-24 15:05:09	~7 min	`tests`	📄`log`

✔️	`fa5d3a2`	#2	2023-05-25 14:45:39	~5 min	`android`	🤖`apk` 📲
✔️	`fa5d3a2`	#2	2023-05-25 14:45:59	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`fa5d3a2`	#2	2023-05-25 14:48:15	~8 min	`tests`	📄`log`
✔️	`fa5d3a2`	#2	2023-05-25 15:29:12	~49 min	`ios`	📱`ipa` 📲

✔️	`1197087`	#3	2023-05-29 08:32:20	~6 min	`ios`	📱`ipa` 📲
✔️	`1197087`	#3	2023-05-29 08:32:36	~6 min	`android`	🤖`apk` 📲
✔️	`1197087`	#3	2023-05-29 08:32:39	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`1197087`	#3	2023-05-29 08:34:51	~8 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ec7a57a`	#5	2023-05-30 11:01:11	~5 min	`ios`	📱`ipa` 📲
✔️	`ec7a57a`	#5	2023-05-30 11:02:27	~7 min	`android`	🤖`apk` 📲
✔️	`ec7a57a`	#5	2023-05-30 11:07:16	~12 min	`android-e2e`	🤖`apk` 📲
✔️	`ec7a57a`	#5	2023-05-30 11:08:01	~12 min	`tests`	📄`log`

✔️	`8af6402`	#6	2023-05-30 15:54:18	~5 min	`android`	🤖`apk` 📲
✔️	`8af6402`	#6	2023-05-30 15:54:54	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`8af6402`	#6	2023-05-30 15:56:19	~7 min	`ios`	📱`ipa` 📲
✔️	`8af6402`	#6	2023-05-30 15:58:21	~9 min	`tests`	📄`log`

src/status_im2/contexts/syncing/scan_sync_code/view.cljs

smohamedjavid · 2023-05-25T14:38:51Z

i believe is the proper solution to close qr screen. why is it active?

@flexsurfer

This is due to the navigational structure of the stack navigation.

Let's say we have screens A, B, C,...etc.

On stack navigation, when the user moves from A -> B, the screen B is added to the top of the stack (which is visible to the user). When the user navigates back, the screen B is popped from the stack. The previous screen (A) is visible to the user.

That's why the camera on the previous screen is active. Once the syncing is completed successfully, we reset the whole stack with :init-root. That's where the screen so far the user has been destroyed.

When the QR scans any sync code, it moves to :syncing-progress screen. Here, the syncing can be successful or not. In case of not successful, we should allow the user to go back.

To prevent the QR scanner to process any further data. I believe checking the view-id would be the best solution.

status-im-auto · 2023-05-26T13:58:31Z

82% of end-end tests have passed

Total executed tests: 33
Failed tests: 6
Passed tests: 27

IDs of failed tests: 702840,702851,702947,702731,702838,702783

Failed tests (6)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
Device 1: Find `Text` by `xpath`: `//*[starts-with(@text,'Message 3')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 1: Tap on found: Text `critical/chats/test_1_1_public_chats.py:979: in test_1_1_chat_pin_messages self.chat_1.chat_element_by_text(message).wait_for_status_to_be("Delivered") ../views/chat_view.py:227: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s" % expected_status) Message status was not changed to Delivered` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
# STEP: Device1 goes back online and checks that 1-1 chat will be fetched Device 1: Looking for a message by text: test message `critical/chats/test_1_1_public_chats.py:1230: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not delivered after back up online, it is "Sending"! E Message was not delivered after resending from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device 2: Quoting '♻' message Device 2: Find `Button` by `xpath`: `//[contains(@text, "♻")]` critical/test_public_chat_browsing.py:584: in test_community_emoji_send_copy_paste_reply self.channel_2.quote_message(emoji_unicode) ../views/chat_view.py:994: in quote_message self.element_by_text_part(message).long_press_until_element_is_shown(self.reply_message_button) ../views/base_element.py:298: in long_press_until_element_is_shown element = self.find_element() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, "♻")]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Verifying that 'hello' is under today Device 2: Looking for a message by text: hello critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username channel.verify_message_is_under_today_text(message, self.errors) ../views/chat_view.py:944: in verify_message_is_under_today_text message_element.wait_for_visibility_of_element() ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element [[blocked by 14797]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device 2: Tap on found: SendMessageButton
# STEP: Checking unread indicators

medium/test_activity_center.py:188: in test_activity_center_reply_read_unread_delete_filter_swipe
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(120)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 1: Looking for activity center element: 'receiver'
Device 1: Find Button by accessibility id: activity-center-open-more

medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.more_options_activity_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `activity-center-open-more` is not found on the screen

Device sessions

Device 1:

Device 2:

Passed tests (27)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

status-im-auto · 2023-05-29T15:03:49Z

100% of end-end tests have passed

Total executed tests: 2
Failed tests: 0
Passed tests: 2

Passed tests (2)

Click to expand

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

VolodLytvynenko · 2023-05-29T15:17:02Z

Hi @smohamedjavid . Thank you for PR.
The issue is still reproducible

ISSUE 1: Continuous QR code scanning even after "Oops something wrong" page is displayed

Steps to reproduce:

Point the camera at an invalid QR code. (In this case, use the sync code that has been used before)
Do not tap the "Try again" button and keep the camera pointed at the QR code when the "Oops something wrong" page is displayed.

Actual result:

The IOS device continues to scan the QR code.

(I don't tap 'try again' button on the record)

senc_problem.mp4

Expected result:

The IOS device should stop scanning the QR code until the "Try again" button is tapped.

Device:

iPhone 11 Pro Max, iOS 16

smohamedjavid · 2023-05-30T11:28:14Z

@VladimrLitvinenko - Kindly retest.

status-im-auto · 2023-05-30T13:47:13Z

67% of end-end tests have passed

Total executed tests: 33
Failed tests: 11
Passed tests: 22

IDs of failed tests: 703133,702732,702894,702782,703086,702731,702807,702784,702838,702958,702745

Failed tests (11)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device 2: Find `Text` by `xpath`: `//[@content-desc='pinned-messages-menu']//[starts-with(@text,'Message 4')]/../../*[@content-desc='pinned-by']/android.widget.TextView` Device 2: `Text` is `user admin` `critical/chats/test_group_chat.py:337: in test_group_chat_pin_messages self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message 2 is not pinned in group chat!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
2. test_group_chat_join_send_text_messages_push, id: 702807
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_group_chat.py:224: in test_group_chat_join_send_text_messages_push self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120) ../views/chat_view.py:227: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s" % expected_status) Message status was not changed to Delivered` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestActivityMultipleDevicePR:

1. test_activity_center_admin_notification_accept_swipe, id: 702958

Device 2: Tap on found: Button
Device 2: Click until Button by accessibility id: jump-to will be presented

medium/test_activity_center.py:292: in test_activity_center_admin_notification_accept_swipe
    [home.jump_to_communities_home() for home in (self.home_1, self.home_2)]
medium/test_activity_center.py:292: in <listcomp>
    [home.jump_to_communities_home() for home in (self.home_1, self.home_2)]
../views/base_view.py:606: in jump_to_communities_home
    self.communities_tab.click_until_presence_of_element(self.jump_to_button)
../views/base_element.py:99: in click_until_presence_of_element
    while not desired_element.is_element_displayed(1) and counter <= attempts:
../views/base_element.py:193: in is_element_displayed
    return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
../views/base_element.py:133: in wait_for_visibility_of_element
    .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
    value = method(self._driver)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
    return _element_if_visible(_find_element(driver, self.locator))
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
    return element if element.is_displayed() == visibility else False
 'dict' object has no attribute 'is_displayed'

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device 1: Tap on found: ProfileSendMessageButton Device 1: Sending message 'piy' critical/test_public_chat_browsing.py:741: in test_community_contact_block_unblock_offline self.chat_1.send_message("piy") ../views/chat_view.py:954: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_mark_all_messages_as_read, id: 703086
Device 1: Find `Button` by `accessibility id`: `jump-to` critical/test_public_chat_browsing.py:752: in test_community_mark_all_messages_as_read self.channel_1.jump_to_communities_home() ../views/base_view.py:605: in jump_to_communities_home self.jump_to_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `jump-to` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Verifying that 'hello' is under today Device 2: Looking for a message by text: hello critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username channel.verify_message_is_under_today_text(message, self.errors) ../views/chat_view.py:944: in verify_message_is_under_today_text message_element.wait_for_visibility_of_element() ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element [[blocked by 14797]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Tap on found: Button
Device 1: Wait for element Button for max 30s and click when it is available

critical/test_public_chat_browsing.py:354: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.recover_access(passphrase=waku_user.seed, second_user=True)
../views/sign_in_view.py:265: in recover_access
    self.identifiers_button.wait_and_click(30)
../views/base_element.py:403: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Button by accessibility id:`skip-identifiers` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 1: Tap on found: SendMessageButton Device 2: Looking for a message by text: Test with link: https://status.im/ here should be nothing unusual. critical/chats/test_1_1_public_chats.py:920: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_2.chat_element_by_text(url_message).wait_for_element(20) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_pin_messages, id: 702731
Device 2: Wait for text element `Button` to be equal to `2` Device 2: Find `Button` by `xpath`: `//[@content-desc='pins-count']//android.widget.TextView` critical/chats/test_1_1_public_chats.py:952: in test_1_1_chat_pin_messages chat.pinned_messages_count.wait_for_element_text("2", ../views/base_element.py:152: in wait_for_element_text text_element = self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[@content-desc='pins-count']//android.widget.TextView` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
critical/chats/test_1_1_public_chats.py:1234: in test_1_1_chat_delete_via_long_press_relogin self.home_2.click_system_back_button_until_element_is_shown() ../views/base_view.py:388: in click_system_back_button_until_element_is_shown while not element.is_element_displayed(1) and counter <= attempts: ../views/base_element.py:193: in is_element_displayed return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions) ../views/base_element.py:133: in wait_for_visibility_of_element .until(expected_conditions.visibility_of_element_located((self.by, self.locator))) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until value = method(self._driver) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__ return _element_if_visible(_find_element(driver, self.locator)) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible return element if element.is_displayed() == visibility else False 'dict' object has no attribute 'is_displayed' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Looking for a message by text: hello Device 2: Find `TimeStampText` by `xpath`: `//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-timestamp']` critical/chats/test_1_1_public_chats.py:1045: in test_1_1_chat_non_latin_messages_stack_update_profile_photo timestamp = self.chat_2.chat_element_by_text(messages[0]).timestamp ../views/chat_view.py:161: in timestamp return TimeStampText(self.driver, self.locator).text ../views/base_element.py:209: in text return self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: TimeStampText by xpath: `//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-timestamp']` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (22)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2023-05-30T15:27:52Z

85% of end-end tests have passed

Total executed tests: 33
Failed tests: 5
Passed tests: 28

IDs of failed tests: 703133,702732,702807,702838,702808

Failed tests (5)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Wait for element `Button` for max 30s and click when it is available
Device 1: Find `Button` by `accessibility id`: `skip-identifiers`

critical/test_public_chat_browsing.py:354: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.recover_access(passphrase=waku_user.seed, second_user=True)
../views/sign_in_view.py:265: in recover_access
    self.identifiers_button.wait_and_click(30)
../views/base_element.py:404: in wait_and_click
    self.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `skip-identifiers` is not found on the screen

Device sessions

Device 1:

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by 14797]]

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Test setup failed: critical/chats/test_group_chat.py:154: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:224: in create_user self.i_m_new_in_status_button.click_until_presence_of_element(self.generate_keys_button) ../views/base_element.py:99: in click_until_presence_of_element while not desired_element.is_element_displayed(1) and counter <= attempts: ../views/base_element.py:193: in is_element_displayed return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions) ../views/base_element.py:133: in wait_for_visibility_of_element .until(expected_conditions.visibility_of_element_located((self.by, self.locator))) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until value = method(self._driver) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__ return _element_if_visible(_find_element(driver, self.locator)) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:415: in _find_element raise e /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:411: in _find_element return driver.find_element(by) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:414: in find_element return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value'] /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response raise exception_class(message, screen, stacktrace) session backend not connected
2. test_group_chat_join_send_text_messages_push, id: 702807
## Creating new multiaccount (password:'qwerty1234', keycard:'False', enable_notification: 'True') Device 3: Click until `Button` by `xpath`: `//[@text="Generate keys"]` will be presented Test setup failed: critical/chats/test_group_chat.py:154: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:224: in create_user self.i_m_new_in_status_button.click_until_presence_of_element(self.generate_keys_button) ../views/base_element.py:99: in click_until_presence_of_element while not desired_element.is_element_displayed(1) and counter <= attempts: ../views/base_element.py:193: in is_element_displayed return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions) ../views/base_element.py:133: in wait_for_visibility_of_element .until(expected_conditions.visibility_of_element_located((self.by, self.locator))) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until value = method(self._driver) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__ return _element_if_visible(_find_element(driver, self.locator)) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:415: in _find_element raise e /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:411: in _find_element return driver.find_element(by) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:414: in find_element return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value'] /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response raise exception_class(message, screen, stacktrace) session backend not connected Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
3. test_group_chat_offline_pn, id: 702808
Test setup failed: critical/chats/test_group_chat.py:154: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:224: in create_user self.i_m_new_in_status_button.click_until_presence_of_element(self.generate_keys_button) ../views/base_element.py:99: in click_until_presence_of_element while not desired_element.is_element_displayed(1) and counter <= attempts: ../views/base_element.py:193: in is_element_displayed return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions) ../views/base_element.py:133: in wait_for_visibility_of_element .until(expected_conditions.visibility_of_element_located((self.by, self.locator))) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until value = method(self._driver) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__ return _element_if_visible(_find_element(driver, self.locator)) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:415: in _find_element raise e /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:411: in _find_element return driver.find_element(by) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:414: in find_element return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value'] /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response raise exception_class(message, screen, stacktrace) session backend not connected

Passed tests (28)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

VolodLytvynenko · 2023-05-30T15:37:55Z

hi @smohamedjavid Thank you for the fixes. PR is ready to be merged

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

smohamedjavid added the pairing label May 24, 2023

smohamedjavid requested review from flexsurfer, J-Son89 and jo-mut May 24, 2023 14:56

smohamedjavid self-assigned this May 24, 2023

jo-mut approved these changes May 24, 2023

View reviewed changes

smohamedjavid added the request-manual-qa label May 24, 2023

flexsurfer requested changes May 25, 2023

View reviewed changes

src/status_im2/contexts/syncing/scan_sync_code/view.cljs Outdated Show resolved Hide resolved

smohamedjavid force-pushed the fix/qr-scanner-rescan branch from e248993 to fa5d3a2 Compare May 25, 2023 14:39

smohamedjavid requested a review from flexsurfer May 26, 2023 11:28

flexsurfer approved these changes May 26, 2023

View reviewed changes

smohamedjavid force-pushed the fix/qr-scanner-rescan branch from fa5d3a2 to 1197087 Compare May 29, 2023 08:25

VolodLytvynenko self-assigned this May 29, 2023

VolodLytvynenko added the Tested - Issues label May 30, 2023

smohamedjavid force-pushed the fix/qr-scanner-rescan branch from 1197087 to fc5786e Compare May 30, 2023 10:50

VolodLytvynenko added Tested - OK and removed Tested - Issues labels May 30, 2023

smohamedjavid added 3 commits May 30, 2023 21:18

[Fix] QR scanning when move to other screen

26fcf22

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

Added sycning clear state event and moved the view-id sub inside render

e458525

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

Clean up

8af6402

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

smohamedjavid force-pushed the fix/qr-scanner-rescan branch from ec7a57a to 8af6402 Compare May 30, 2023 15:48

smohamedjavid merged commit 863dac6 into develop May 30, 2023

smohamedjavid deleted the fix/qr-scanner-rescan branch May 30, 2023 15:58

smohamedjavid mentioned this pull request Jul 25, 2023

[#16437] fix sync qr code not recognized after trying again #16746

Merged

[Fix] QR scanner scanning QR when user moved to next screen #16012

[Fix] QR scanner scanning QR when user moved to next screen #16012

Conversation

smohamedjavid commented May 24, 2023

Summary

Platforms

Steps to test

status-im-auto commented May 24, 2023 • edited Loading

Jenkins Builds

smohamedjavid commented May 25, 2023

status-im-auto commented May 26, 2023

82% of end-end tests have passed

Failed tests (6)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Passed tests (27)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

status-im-auto commented May 29, 2023

100% of end-end tests have passed

Passed tests (2)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

VolodLytvynenko commented May 29, 2023

ISSUE 1: Continuous QR code scanning even after "Oops something wrong" page is displayed

Steps to reproduce:

Actual result:

Expected result:

Device:

smohamedjavid commented May 30, 2023

status-im-auto commented May 30, 2023

67% of end-end tests have passed

Failed tests (11)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (22)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

status-im-auto commented May 30, 2023

85% of end-end tests have passed

Failed tests (5)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (28)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

VolodLytvynenko commented May 30, 2023

status-im-auto commented May 24, 2023 •

edited

Loading