Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] "View Profile" button behaviour on keyboard open in "Add a contact" modal #15978

Merged
merged 5 commits into from
May 25, 2023
Merged

[Fix] "View Profile" button behaviour on keyboard open in "Add a contact" modal #15978

merged 5 commits into from
May 25, 2023

Conversation

smohamedjavid
Copy link
Member

@smohamedjavid smohamedjavid commented May 21, 2023 •
edited
Loading

fixes #15976

Summary

This PR fixes the behaviour of the View Profile button in the "Add a contact" modal when the keyboard is open.

Platforms

  • Android
  • iOS

Steps to test

  1. Open Status
  2. Navigate to the Messages tab
  3. Tap on + button on top right corner
  4. Press Add a contact
  5. Bring up the keyboard by tapping/focusing on ENS or Chat Key
  6. See whether the View Profile button sticks to the top of the keyboard

status: ready

@smohamedjavid smohamedjavid self-assigned this May 21, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 21, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f796bad #1 2023-05-21 16:52:33 ~6 min android-e2e 🤖apk 📲
✔️ f796bad #1 2023-05-21 16:53:11 ~6 min android 🤖apk 📲
✔️ f796bad #1 2023-05-21 16:53:27 ~6 min tests 📄log
✔️ f796bad #1 2023-05-21 16:54:00 ~7 min ios 📱ipa 📲
✔️ 379a747 #2 2023-05-22 15:04:59 ~5 min android-e2e 🤖apk 📲
✔️ 379a747 #2 2023-05-22 15:05:01 ~5 min android 🤖apk 📲
✔️ 379a747 #2 2023-05-22 15:05:01 ~5 min tests 📄log
✔️ 379a747 #2 2023-05-22 15:05:43 ~6 min ios 📱ipa 📲
✔️ c6500d5 #3 2023-05-23 05:59:20 ~6 min ios 📱ipa 📲
✔️ c6500d5 #3 2023-05-23 05:59:32 ~6 min android-e2e 🤖apk 📲
✔️ c6500d5 #3 2023-05-23 05:59:45 ~6 min android 🤖apk 📲
✔️ c6500d5 #3 2023-05-23 06:00:48 ~7 min tests 📄log
✔️ fe2a1ef #4 2023-05-23 15:15:35 ~5 min android 🤖apk 📲
❌ fe2a1ef #4 2023-05-23 15:15:43 ~5 min tests 📄log
✔️ fe2a1ef #4 2023-05-23 15:15:57 ~5 min android-e2e 🤖apk 📲
✔️ fe2a1ef #4 2023-05-23 15:16:41 ~6 min ios 📱ipa 📲
✔️ 322d395 #5 2023-05-23 15:32:16 ~5 min android 🤖apk 📲
✔️ 322d395 #5 2023-05-23 15:32:27 ~5 min android-e2e 🤖apk 📲
✔️ 322d395 #5 2023-05-23 15:32:39 ~5 min tests 📄log
✔️ 322d395 #5 2023-05-23 15:34:56 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 93f7bef #6 2023-05-23 15:59:53 ~6 min android 🤖apk 📲
✔️ 93f7bef #6 2023-05-23 16:01:16 ~7 min ios 📱ipa 📲
✔️ 93f7bef #6 2023-05-23 16:02:12 ~8 min tests 📄log
✔️ 93f7bef #6 2023-05-23 16:02:38 ~8 min android-e2e 🤖apk 📲
✔️ b0431a3 #7 2023-05-25 13:23:33 ~6 min android-e2e 🤖apk 📲
✔️ b0431a3 #7 2023-05-25 13:24:42 ~7 min ios 📱ipa 📲
✔️ b0431a3 #7 2023-05-25 13:25:02 ~7 min android 🤖apk 📲
✔️ b0431a3 #7 2023-05-25 13:26:52 ~9 min tests 📄log

@flexsurfer
Copy link
Member

hey @smohamedjavid, just wondering why we don't show the button instead, looks like a proper way to fix the issue ?

@smohamedjavid
Copy link
Member Author

hey @smohamedjavid, just wondering why we don't show the button instead, looks like a proper way to fix the issue ?

Hi @flexsurfer - Figma doesn't have a definitive design on how the button should behave when the keyboard is open for the "Add a contact" modal. That's why, I went with dismissing the keyboard by tapping outside of the keyboard area approach.

I agree displaying the button on top of the keyboard is the correct fix for a good UX. I have removed the first approach state above and updated the "Add a contact" screen with keyboard-avoiding-view to match the button behaviour with other modals like "Add/Edit nickname".

@smohamedjavid smohamedjavid changed the title [Fix] Keyboard dismiss in "Add a contact" modal [Fix] "View Profile" button behaviour on keyboard open in "Add a contact" modal May 22, 2023
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 33
Failed tests: 4
Passed tests: 29

IDs of failed tests: 702732,702807,702808,702838

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test setup failed: critical/chats/test_group_chat.py:198: in prepare_devices
    self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>,
../views/home_view.py:358: in create_group_chat
    [chat.get_username_checkbox(user_name).click() for user_name in user_names_to_add]
../views/home_view.py:358: in <listcomp>
    [chat.get_username_checkbox(user_name).click() for user_name in user_names_to_add]
../views/chat_view.py:326: in click
    self.scroll_to_element(direction='up', depth=20).click()
../views/base_element.py:177: in scroll_to_element
    raise NoSuchElementException(
 Device 1: UsernameCheckbox by xpath: `//*[@text='member_1']/..//*[@content-desc='checkbox-off']` is not found on the screen



    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 1: Find UsernameCheckbox by xpath: //*[@text='member_1']/..//*[@content-desc='checkbox-off']
    Device 1: Find UsernameCheckbox by xpath: //*[@text='member_1']/..//*[@content-desc='checkbox-off'] 

    Test setup failed: critical/chats/test_group_chat.py:198: in prepare_devices
    self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>,
../views/home_view.py:358: in create_group_chat
    [chat.get_username_checkbox(user_name).click() for user_name in user_names_to_add]
../views/home_view.py:358: in <listcomp>
    [chat.get_username_checkbox(user_name).click() for user_name in user_names_to_add]
../views/chat_view.py:326: in click
    self.scroll_to_element(direction='up', depth=20).click()
../views/base_element.py:177: in scroll_to_element
    raise NoSuchElementException(
 Device 1: UsernameCheckbox by xpath: `//*[@text='member_1']/..//*[@content-desc='checkbox-off']` is not found on the screen



    Device sessions

    3. test_group_chat_offline_pn, id: 702808 

    Test setup failed: critical/chats/test_group_chat.py:198: in prepare_devices
    self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>,
../views/home_view.py:358: in create_group_chat
    [chat.get_username_checkbox(user_name).click() for user_name in user_names_to_add]
../views/home_view.py:358: in <listcomp>
    [chat.get_username_checkbox(user_name).click() for user_name in user_names_to_add]
../views/chat_view.py:326: in click
    self.scroll_to_element(direction='up', depth=20).click()
../views/base_element.py:177: in scroll_to_element
    raise NoSuchElementException(
 Device 1: UsernameCheckbox by xpath: `//*[@text='member_1']/..//*[@content-desc='checkbox-off']` is not found on the screen



    Passed tests (29)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_mentions_push_notification, id: 702786
    Device sessions

    6. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    7. test_community_leave, id: 702845
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    9. test_community_message_delete, id: 702839
    Device sessions

    10. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    11. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this May 23, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    VolodLytvynenko commented May 23, 2023 •
    edited
    Loading

    Hi @smohamedjavid thank you for PR. The issue is fixed for some devices. But still reproduced for smaller resolution devices

    Steps to reproduce:

    1. Paste into 'ENS or Chat key' field a compressed chat key which contains (https://join.status.im/u/) Example: https://join.status.im/u/zQ3shcsrHCfa1A2QWfXW8eNa8SptqSkQEqW6yyrj3AjMRv3SR

    Actual result:

    • Real device: Huawei p20 light, Android 9
      image

    • Android Studio: Pixel XL, Android 10
      image

    Expected result:

    'View profile' button is still visible

    @VolodLytvynenko
    Copy link
    Contributor

    @smohamedjavid I believe it will be challenging to show 'view profile' button for all devices in this case. Since a user can add text longer than the valid chat key, causing the "View Profile" button becomes hidden again.

    Expected result:

    Maybe would be better to implement the following solution for such cases:

    • The keyboard closes when the user presses the "Return" button on the keyboard.
    • The keyboard closes when the user taps somewhere outside of 'chat key' field

    This will allow the user to see the overlapped by keyboard "View Profile" button.

    Actual result:

    User can't close the keyboard to see the 'view profile' button
    image

    @smohamedjavid It'll be better to add as a separate follow up or can be fixed in the current PR?

    @smohamedjavid
    Copy link
    Member Author

    @VladimrLitvinenko Thanks for testing the PR!

    @smohamedjavid I believe it will be challenging to show 'view profile' button for all devices in this case.

    Yes, It will be challenging to support smaller devices as the input box can grow.

    Maybe would be better to implement the following solution for such cases:

    • The keyboard closes when the user presses the "Return" button on the keyboard.
    • The keyboard closes when the user taps somewhere outside of 'chat key' field

    Good suggestion! I have added both functionalities. Also, I have updated the return button to the done button. As it's more appropriate.

    Kindly retest.

    @status-im-auto
    Copy link
    Member

    97% of end-end tests have passed

    Total executed tests: 33
Failed tests: 1
Passed tests: 32

    IDs of failed tests: 702838

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (32)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_mentions_push_notification, id: 702786
    Device sessions

    6. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    7. test_community_leave, id: 702845
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    9. test_community_message_delete, id: 702839
    Device sessions

    10. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    11. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi, @smohamedjavid could you rebase this PR, please? This fix will be included in the release 1.23

    @smohamedjavid
    [Fix] Keyboard dismiss in add contact modal
    f304481 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid
    [Fix] View Profile Button in add contact modal
    2fe53ec 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid
    [Fix] Text Input Sumbit in add contact modal
    9845985 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid
    Lint
    14f0dab 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid
    Added keyboard dismiss on tapping outside of keyboard
    b0431a3 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid
    Copy link
    Member Author

    hi, @smohamedjavid could you rebase this PR, please? This fix will be included in the release 1.23

    Done! 😄

    @status-im-auto
    Copy link
    Member

    81% of end-end tests have passed

    Total executed tests: 27
Failed tests: 5
Passed tests: 22
Not executed tests: 6

    IDs of not executed tests: 702807,702732,702808,702936,702947,702957 

    IDs of failed tests: 702851,702838,702958,702850,702894

    Not executed tests (6)

    Click to expand
  • Rerun not executed tests

    • Failed tests (5)

    Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958 
    Test setup failed: medium/test_activity_center.py:115: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:304: in create_shared_drivers
    drivers = loop.run_until_complete(start_threads(quantity,
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:22: in start_threads
    returns[k] = await returns[k]
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:267: in __init__
    super().__init__(
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:157: in __init__
    self.start_session(capabilities, browser_profile)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:360: in start_session
    self.session_id = response['sessionId']
 'sessionId'



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 2: Tap on found: SendMessageButton
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:748: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not received in 1-1 chat after user unblock!



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Find Button by accessibility id: new-chat-button
    Device 2: Find Button by accessibility id: add-a-contact 

    medium/test_activity_center.py:78: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_2.add_contact(self.public_key_1, remove_from_contacts=True)
../views/home_view.py:337: in add_contact
    self.add_a_contact_chat_bottom_sheet_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `add-a-contact` is not found on the screen



    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850

    Device 2: Tap on found: Button
    Device 2: Click until ProfileBlockContactButton by accessibility id: Block-item-button will be presented 

    medium/test_activity_center.py:39: in test_activity_center_contact_request_decline
    chat.view_profile_new_contact_button.click_until_presence_of_element(chat.profile_block_contact_button)
../views/base_element.py:99: in click_until_presence_of_element
    while not desired_element.is_element_displayed(1) and counter <= attempts:
../views/base_element.py:193: in is_element_displayed
    return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
../views/base_element.py:133: in wait_for_visibility_of_element
    .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
    value = method(self._driver)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
    return _element_if_visible(_find_element(driver, self.locator))
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
    return element if element.is_displayed() == visibility else False
 'dict' object has no attribute 'is_displayed'



    Device sessions

    Passed tests (22)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_unread_messages_badge, id: 702841
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_several_images_send_reply, id: 703194
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    7. test_community_one_image_send_reply, id: 702859
    Device sessions

    8. test_community_mentions_push_notification, id: 702786
    Device sessions

    9. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    10. test_community_leave, id: 702845
    Device sessions

    @status-im-auto
    Copy link
    Member

    97% of end-end tests have passed

    Total executed tests: 33
Failed tests: 1
Passed tests: 32

    IDs of failed tests: 702838

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (32)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_message_edit, id: 702843
    Device sessions

    6. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    7. test_community_mentions_push_notification, id: 702786
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    10. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    3. test_group_chat_pin_messages, id: 702732
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    @smohamedjavid No issues from my side. PR can be merged

    @smohamedjavid
    Copy link
    Member Author

    @smohamedjavid No issues from my side. PR can be merged

    Thanks for testing the PR, @VladimrLitvinenko!

    @smohamedjavid smohamedjavid merged commit e14ed7a into develop May 25, 2023
    @smohamedjavid smohamedjavid deleted the fix/keyboard-on-new-contact branch May 25, 2023 19:02
    rahulpsingh pushed a commit that referenced this pull request May 26, 2023
    @smohamedjavid @rahulpsingh
    [Fix] "View Profile" button behaviour on keyboard open in "Add a cont…
    1f7efc6 
    …act" modal (#15978)

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jo-mut jo-mut jo-mut approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @erikseppanen erikseppanen erikseppanen approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @smohamedjavid smohamedjavid

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    [iOS] "View Profile" button goes behind the keyboard while adding a new contact
    6 participants
    @smohamedjavid @status-im-auto @flexsurfer @VolodLytvynenko @erikseppanen @jo-mut