Design fixes for profile options #15966

vkjr · 2023-05-19T12:36:51Z

Partially fixes design notes from #15789

Summary

Fixes the following notes:

Set drawer background color to shell (full comment here)
Updated delete icon design (full comment here)
Increased bottom padding for bottom sheet, made it 55 as in designs, instead of defaults of safe area (full comment here)

status: ready

siddarthkay · 2023-05-19T12:44:26Z

src/status_im2/navigation/view.cljs

@@ -69,12 +69,17 @@
        (when js/goog.DEBUG
          [reloader/reload-view])]))))

+; Designs require bottom inset to be bigger than safe area, otherwise it is too close to the bottom


Do you think its better if we move this block of code to status-mobile/src/react_native/safe_area.cljs ?

Not sure, to be honest. Safe area is used in a lot of different contexts and the file safe_area.cljs used as an interface react-native-static-safe-area-insets. So I don't think that moving bottom-sheet stuff there will be beneficial. Whereas its declaration near the place of use looks more obvious to me.
Wdyt?

Hmm I can understand why you did this, to be honest in most cases i do this too.

The thought process behind my original comment was this ,
Since safe_area.cljs is an interface, I thought it would be better to have a bottom sheet variant over there which could then be used like this in your code like this :

(def bottom-sheet (reagent/reactify-component (fn [] (let [{:keys [sheets hide?]} (rf/sub [:bottom-sheet]) sheet (last sheets) insets (safe-area/bottom-sheet-insets)] ^{:key (str "sheet" @reloader/cnt)} [:<> [inactive]

But totally upto you, I don't have a very strong opinion on this :)

I checked all the usages of (safe-area/get-insets) and didn't find other similar code where insets are changed right after getting. So I would suggest leaving it as is. And if we will find out that different components also want to get some alternated insets, we can move all these alternations to safe_area.cljs.

In general I think that developer who opened safe_area.cljs for his own reasons shouldn't stumble upon bottom-sheet mention and think about it, since it is on another level of abstraction)

status-im-auto · 2023-05-19T12:44:53Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`2aa2f04`	#2	2023-05-19 12:44:52	~6 min	`android`	🤖`apk` 📲
✔️	`2aa2f04`	#2	2023-05-19 12:44:57	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`2aa2f04`	#2	2023-05-19 12:45:09	~6 min	`tests`	📄`log`
✔️	`2aa2f04`	#2	2023-05-19 12:46:37	~8 min	`ios`	📱`ipa` 📲

✔️	`1d4365e`	#3	2023-05-19 13:18:08	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`1d4365e`	#3	2023-05-19 13:18:33	~6 min	`ios`	📱`ipa` 📲
✔️	`1d4365e`	#3	2023-05-19 13:18:39	~6 min	`android`	🤖`apk` 📲
✔️	`1d4365e`	#3	2023-05-19 13:19:08	~6 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`c1c239e`	#4	2023-05-22 14:24:11	~34 sec	`ios`	📄`log`

✔️	`0f0caee`	#5	2023-05-22 14:32:43	~5 min	`android`	🤖`apk` 📲
✔️	`0f0caee`	#5	2023-05-22 14:32:55	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`0f0caee`	#5	2023-05-22 14:33:25	~6 min	`ios`	📱`ipa` 📲
✔️	`0f0caee`	#5	2023-05-22 14:33:39	~6 min	`tests`	📄`log`

siddarthkay

Other than a minor comment, this looks good to me, good work @vkjr

status-im-auto · 2023-05-19T14:28:34Z

84% of end-end tests have passed

Total executed tests: 32
Failed tests: 5
Passed tests: 27

IDs of failed tests: 702844,702782,702850,702851,702838

Failed tests (5)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device 1: Tap on found: SendMessageButton
Device 2: Find `Button` by `xpath`: `//*[starts-with(@text,'http://status.im')]`

critical/chats/test_1_1_public_chats.py:930: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_2.element_starts_with_text(url_message, 'button').click_inside_element_by_coordinate(0.2, 0.5)
../views/base_element.py:328: in click_inside_element_by_coordinate
    location, size = self.get_element_coordinates()
../views/base_element.py:266: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[starts-with(@text,'http://status.im')]` is not found on the screen

Device sessions

Device 1:

Device 2:

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device 2: Looking for activity center element: 'sender' Device 2: Find `Button` by `xpath`: `//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']//[@content-desc="activity-message-body"]` medium/test_activity_center.py:68: in test_activity_center_contact_request_decline if activity_center_element.message_body.text != self.home_2.get_translation_by_key("add-me-to-your-contacts"): ../views/base_element.py:209: in text return self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']//[@content-desc="activity-message-body"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device 2: Find `Button` by `accessibility id`: `new-chat-button` Device 2: Find `Button` by `accessibility id`: `add-a-contact` medium/test_activity_center.py:78: in test_activity_center_contact_request_accept_swipe_mark_all_as_read self.home_2.add_contact(self.public_key_1, remove_from_contacts=True) ../views/home_view.py:337: in add_contact self.add_a_contact_chat_bottom_sheet_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `add-a-contact` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device 2: Tap on found: SendMessageButton Device 2: Find `Button` by `xpath`: `//[@text="Don't ask me again"]` critical/test_public_chat_browsing.py:604: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable self.channel_2.element_by_translation_id("dont-ask").click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[@text="Don't ask me again"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Verifying that 'hello' is under today Device 2: Looking for a message by text: hello critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username channel.verify_message_is_under_today_text(message, self.errors) ../views/chat_view.py:935: in verify_message_is_under_today_text message_element.wait_for_visibility_of_element() ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element [[blocked by 14797]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (27)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
3. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2023-05-22T09:56:29Z

50% of end-end tests have passed

Total executed tests: 4
Failed tests: 2
Passed tests: 2

IDs of failed tests: 702782,702844

Failed tests (2)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Device 2: Tap on found: SendMessageButton
Device 2: Find `Button` by `xpath`: `//*[@text="Don't ask me again"]`

critical/test_public_chat_browsing.py:604: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    self.channel_2.element_by_translation_id("dont-ask").click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[@text="Don't ask me again"]` is not found on the screen

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device 1: Tap on found: SendMessageButton
Device 2: Find Button by xpath: //*[starts-with(@text,'http://status.im')]

critical/chats/test_1_1_public_chats.py:930: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_2.element_starts_with_text(url_message, 'button').click_inside_element_by_coordinate(0.2, 0.5)
../views/base_element.py:328: in click_inside_element_by_coordinate
    location, size = self.get_element_coordinates()
../views/base_element.py:266: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[starts-with(@text,'http://status.im')]` is not found on the screen

Device sessions

Device 1:

Device 2:

Passed tests (2)

Click to expand

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

briansztamfater · 2023-05-22T14:33:20Z

src/status_im2/common/bottom_sheet/view.cljs

@@ -73,7 +73,7 @@
                (styles/sheet insets window-height override-theme shell?))}

       (when shell?
-         [blur/view
+         [blur/ios-view


Do we have issues for blur on Android here? Asking so I can try to fix it here #15953

Yeah, with blur/view it looks incorrect on Android

Thanks, I'll try to fix it on my PR 👍

qoqobolo · 2023-05-22T15:05:22Z

Thanks for the fixes @vkjr!
PR can be merged.

vkjr · 2023-05-22T15:07:52Z

@qoqobolo, thank you!

vkjr requested review from briansztamfater, J-Son89, ibrkhalil and siddarthkay May 19, 2023 12:36

vkjr self-assigned this May 19, 2023

vkjr force-pushed the design-fixes branch from dbfb4a0 to 2aa2f04 Compare May 19, 2023 12:38

siddarthkay reviewed May 19, 2023

View reviewed changes

siddarthkay approved these changes May 19, 2023

View reviewed changes

vkjr force-pushed the design-fixes branch from 2aa2f04 to 1d4365e Compare May 19, 2023 13:12

vkjr added the request-manual-qa label May 19, 2023

qoqobolo self-assigned this May 19, 2023

vkjr added 2 commits May 22, 2023 15:26

design fixes

513dd16

Use blur view that fallbacks to rn/view on Android

0f0caee

vkjr force-pushed the design-fixes branch from c1c239e to 0f0caee Compare May 22, 2023 14:26

briansztamfater reviewed May 22, 2023

View reviewed changes

briansztamfater approved these changes May 22, 2023

View reviewed changes

qoqobolo added the Tested - OK label May 22, 2023

vkjr merged commit 540e5be into develop May 22, 2023

vkjr deleted the design-fixes branch May 22, 2023 15:07

qoqobolo mentioned this pull request May 24, 2023

Transparent background of onboarding bottom sheets on Android #16007

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Design fixes for profile options #15966

Design fixes for profile options #15966

vkjr commented May 19, 2023 •

edited

Loading

siddarthkay May 19, 2023

vkjr May 19, 2023

siddarthkay May 19, 2023

vkjr May 19, 2023

status-im-auto commented May 19, 2023 •

edited

Loading

siddarthkay left a comment

status-im-auto commented May 19, 2023

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented May 22, 2023

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

briansztamfater May 22, 2023

vkjr May 22, 2023

vkjr May 22, 2023

briansztamfater May 22, 2023

qoqobolo commented May 22, 2023

vkjr commented May 22, 2023

Design fixes for profile options #15966

Design fixes for profile options #15966

Conversation

vkjr commented May 19, 2023 • edited Loading

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

status-im-auto commented May 19, 2023 • edited Loading

Jenkins Builds

siddarthkay left a comment

Choose a reason for hiding this comment

status-im-auto commented May 19, 2023

84% of end-end tests have passed

Failed tests (5)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Passed tests (27)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented May 22, 2023

50% of end-end tests have passed

Failed tests (2)

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (2)

Class TestActivityCenterContactRequestMultipleDevicePR:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qoqobolo commented May 22, 2023

vkjr commented May 22, 2023

vkjr commented May 19, 2023 •

edited

Loading

status-im-auto commented May 19, 2023 •

edited

Loading