feat: add ident ring for login profile picture #15942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (28)
|
yqrashawn
force-pushed
the
identring-for-login-profile-pic
branch
4 times, most recently
from
6d4649f
to
3251c2b
Compare
yqrashawn
force-pushed
the
identring-for-login-profile-pic
branch
2 times, most recently
from
a4660e4
to
a48419a
Compare
yqrashawn
commented
May 19, 2023
| @@ -26,7 +26,7 @@ | |||
| 4)) | |||
|
|
|||
| (defn get-account-image-uri | |||
| [port public-key image-name key-uid theme] | |||
| [{:keys [port public-key image-name key-uid theme ring?]}] | |||
There was a problem hiding this comment.
the ring? here will be used later to disable ident ring for user with ens name
yqrashawn
commented
May 19, 2023
Comment on lines
+58
to
+61
| (let [image-name (-> multiaccounts | ||
| (get-in [target-key-uid :images]) | ||
| first | ||
| :type)] |
There was a problem hiding this comment.
image name stored in status-go is the :type of images, "large", "thumbnail"
80% of end-end tests have passedNot executed tests (2)Failed tests (6)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Passed tests (24)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
yqrashawn
force-pushed
the
identring-for-login-profile-pic
branch
from
a48419a
to
7582397
Compare
94% of end-end tests have passedNot executed tests (1)Failed tests (2)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (30)Click to expandClass TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
|
yqrashawn
force-pushed
the
identring-for-login-profile-pic
branch
from
7582397
to
bfd002c
Compare
|
Hey @yqrashawn ! Thanx for the PR. We are waiting for the review. After approval we will be able to take it into testing. |
alwx
approved these changes
May 22, 2023
94% of end-end tests have passedNot executed tests (1)Failed tests (2)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (30)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
@yqrashawn thank you for the PR. Just to make sure: empty profile image is not in scope of current PR, correct?
|
If it is not - then this PR is ready to be merged. If it is in scope - then we need to add ident ring for empty login profile picture. |
Signed-off-by: yqrashawn <namy.19@gmail.com>
yqrashawn
force-pushed
the
identring-for-login-profile-pic
branch
from
bfd002c
to
6ae4722
Compare
|
@pavloburykh it's not in the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix for subissue 1 in #15788
Adds ident ring for user set profile picture in views before login
ident ring around initials is not supported yet. Will work on that next.
related status-go PR status-im/status-go#3500 status-im/status-go#3505
with these status-go changes
status: ready