Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity Center Empty Community Image #15907

Merged
merged 3 commits into from
May 18, 2023
Merged

Activity Center Empty Community Image #15907

merged 3 commits into from
May 18, 2023

Conversation

smohamedjavid
Copy link
Member

fixes #15888

Summary

This PR fixes the loading (activity-indicator) and the x mark shown for the communities which have no (avatar) image.

Review notes

Introduced the no-avatar-placeholder? key to the context-tag component to prevent breaking the changes from #15815.

Platforms

  • Android
  • iOS

Steps to test

  • Generate Admin, Mention, Replies, and Community Request (Membership) notifications from communities with no (avatar) image
  • Check whether loading or x mark is shown.

status: ready

@smohamedjavid smohamedjavid self-assigned this May 15, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 15, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e065267 #1 2023-05-15 20:00:54 ~6 min android-e2e 🤖apk 📲
✔️ e065267 #1 2023-05-15 20:00:54 ~6 min android 🤖apk 📲
✔️ e065267 #1 2023-05-15 20:01:22 ~7 min ios 📱ipa 📲
✔️ e065267 #1 2023-05-15 20:06:48 ~12 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d57b315 #2 2023-05-16 15:13:29 ~5 min android 🤖apk 📲
✔️ d57b315 #2 2023-05-16 15:14:27 ~6 min android-e2e 🤖apk 📲
✔️ d57b315 #2 2023-05-16 15:14:57 ~7 min ios 📱ipa 📲
✔️ d57b315 #2 2023-05-16 15:15:29 ~7 min tests 📄log
✔️ 970768b #3 2023-05-17 19:27:43 ~6 min ios 📱ipa 📲
✔️ 970768b #3 2023-05-17 19:27:49 ~6 min android 🤖apk 📲
✔️ 970768b #3 2023-05-17 19:28:11 ~6 min tests 📄log

@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 32
Failed tests: 4
Passed tests: 28

IDs of failed tests: 702786,702807,702838,702813

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: `Text` is `Delivered`
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:228: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin

    [[blocked by 15859]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: user_1 

    critical/test_public_chat_browsing.py:812: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin

    [[blocked by 15859]]

    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:935: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    # STEP: Send emoji message to Device 1 while it's on background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:1097: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:945: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element

    [[blocked by 15859]]

    Device sessions

    Passed tests (28)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_1_1_chat_image_send_reply, id: 702859
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @smohamedjavid smohamedjavid force-pushed the fix/empty-community-icon-in-activity-center branch from e065267 to d57b315 Compare May 16, 2023 15:07
    @VolodLytvynenko VolodLytvynenko self-assigned this May 17, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    VolodLytvynenko commented May 17, 2023 •
    edited
    Loading

    @smohamedjavid Thank you for PR! The issue is fixed.

    I have found a follow-up issue also related to the community avatar. This issue is unrelated to the fixes implemented in this PR, and it's already present in the development environment.

    kindly, if you could address this additional issue within the scope of the current PR?

    ISSUE 1: Community avatar image appears as an loading spinner in 1-1 chat after being shared

    Steps to reproduce:

    1. User_A: Create closed community -> set image for community during creation
    2. User_A: Shares the community with User_B
    3. User_B: Check community avatar in 1-1

    Actual result:

    Community avatar image appears as an loading spinner in 1-1
    image

    Expected result:

    The image of community is fetched in 1-1 chat

    @smohamedjavid
    [Fix] Activity Center Empty Community Icons
    767a1de 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid
    [Update] Added Quo2 preview for Context Tag changes
    30d5f15 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid
    [Update] Community Thumbnail in Preview
    970768b 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid smohamedjavid force-pushed the fix/empty-community-icon-in-activity-center branch from d57b315 to 970768b Compare May 17, 2023 19:21
    @smohamedjavid
    Copy link
    Member Author

    @VladimrLitvinenko Thanks a lot for testing this PR 😄

    kindly, if you could address this additional issue within the scope of the current PR?

    ISSUE 1: Community avatar image appears as an loading spinner in 1-1 chat after being shared

    Sure, I have added the fix with this PR.

    Kindly retest :)

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 1
Failed tests: 1
Passed tests: 0
Not executed tests: 31

    IDs of not executed tests: 702730,702782,702731,702745,702813,702855,702733,702783,702784,702807,702732,702808,702838,702843,702839,702840,702859,702841,702844,702894,702845,702786,703086,702846,702742,703133,702850,702851,702936,702947,702957 

    IDs of failed tests: 702958

    Not executed tests (31)

    Click to expand
  • Rerun not executed tests

    • Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958 
    Test setup failed: medium/test_activity_center.py:115: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:304: in create_shared_drivers
    drivers = loop.run_until_complete(start_threads(quantity,
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:22: in start_threads
    returns[k] = await returns[k]
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:267: in __init__
    super().__init__(
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:157: in __init__
    self.start_session(capabilities, browser_profile)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:357: in start_session
    response = self.execute(RemoteCommand.NEW_SESSION, parameters)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response
    raise exception_class(value)
 The test with session id 673059c29eeb4a5fb8e6e940953e1d21 has already finished, and can't receive further commands.
E   For help, please check https://docs.saucelabs.com/dev/error-messages



    @status-im-auto
    Copy link
    Member

    88% of end-end tests have passed

    Total executed tests: 32
Failed tests: 4
Passed tests: 28

    IDs of failed tests: 702786,702813,702838,702807

    Failed tests (4)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    # STEP: Send emoji message to Device 1 while it's on background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:1096: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:945: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Text is Delivered
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:227: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: user_1 

    critical/test_public_chat_browsing.py:811: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin



    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:935: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (28)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_message_edit, id: 702843
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_1_1_chat_image_send_reply, id: 702859
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    7. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    8. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi @smohamedjavid. Thank you a lot for fixing 2 issues in 1 PR. No issues from my side. PR is ready to be merged

    @smohamedjavid smohamedjavid merged commit 3c9ad50 into develop May 18, 2023
    @smohamedjavid smohamedjavid deleted the fix/empty-community-icon-in-activity-center branch May 18, 2023 11:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @alwx alwx alwx approved these changes

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    Assignees

    @smohamedjavid smohamedjavid

    @VolodLytvynenko VolodLytvynenko

    Labels
    activity-center request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Empty community icon (with no logo set) is not fetched in Activity center
    6 participants
    @smohamedjavid @status-im-auto @VolodLytvynenko @ilmotta @alwx @flexsurfer