Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app locked screen accent color #15854

Merged
merged 1 commit into from
May 11, 2023
Merged

fix: app locked screen accent color #15854

merged 1 commit into from
May 11, 2023

Conversation

ajayesivan
Copy link
Contributor

fixes #15853

status: ready

@ajayesivan ajayesivan self-assigned this May 9, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 9, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ff79e79 #1 2023-05-09 23:41:28 ~5 min android 🤖apk 📲
✔️ ff79e79 #1 2023-05-09 23:41:34 ~6 min android-e2e 🤖apk 📲
✔️ ff79e79 #1 2023-05-09 23:42:54 ~7 min tests 📄log
✔️ ff79e79 #1 2023-05-09 23:44:31 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 31440e6 #2 2023-05-11 09:58:58 ~5 min android-e2e 🤖apk 📲
✔️ 31440e6 #2 2023-05-11 09:59:14 ~5 min android 🤖apk 📲
✔️ 31440e6 #2 2023-05-11 09:59:32 ~5 min tests 📄log
✔️ 31440e6 #2 2023-05-11 10:00:07 ~6 min ios 📱ipa 📲
✔️ 408a83f #3 2023-05-11 12:25:43 ~5 min android 🤖apk 📲
✔️ 408a83f #3 2023-05-11 12:25:50 ~5 min tests 📄log
✔️ 408a83f #3 2023-05-11 12:26:06 ~6 min android-e2e 🤖apk 📲
✔️ 408a83f #3 2023-05-11 12:27:55 ~8 min ios 📱ipa 📲

@qoqobolo qoqobolo self-assigned this May 10, 2023
@status-im-auto
Copy link
Member

74% of end-end tests have passed

Total executed tests: 31
Failed tests: 8
Passed tests: 23

IDs of failed tests: 702840,702786,702807,702850,702808,702838,702742,702813

Failed tests (8)

Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find `Button` by `accessibility id`: `close-activity-center`
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:73: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Text is Delivered
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:227: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin



    Device sessions

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:258: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 message from new member PN was not fetched from offline



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    # STEP: Send emoji message to Device 1 while it's on background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:1171: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:937: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 1: Find RepliedMessageText by xpath: //*[starts-with(@text,'test message')]/preceding::android.widget.TextView[@content-desc='quoted-message']
    Device 1: RepliedMessageText is 👩‍✈️ 

    critical/test_public_chat_browsing.py:526: in test_community_emoji_send_copy_paste_reply
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Emoji message was not copied

    [[flaky test; sometimes can not be copied through appium]]

    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: user_1 

    critical/test_public_chat_browsing.py:764: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin



    Device sessions

    3. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:461: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:927: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Find ChatMessageInput by accessibility id: chat-message-input
    Device 1: Clear text in ChatMessageInput 

    critical/test_public_chat_browsing.py:353: in test_community_copy_and_paste_message_in_chat_input
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message mmmeowesage_text text was not copied in community channel
E    Message https://status.im text was not copied in community channel

    [[flaky test; sometimes can not be copied through appium]]

    Device sessions

    Passed tests (23)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_unread_messages_badge, id: 702841
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    Hey @ajayesivan, PR looks good to me so far, but could you please resolve the conflicts?
    I'll double-check it again, and after this, we can merge.
    Thanks!

    @status-im-auto
    Copy link
    Member

    25% of end-end tests have passed

    Total executed tests: 8
Failed tests: 6
Passed tests: 2

    IDs of failed tests: 702786,702840,702813,702838,702742,702807

    Failed tests (6)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: user_1 

    critical/test_public_chat_browsing.py:764: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin



    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 1: Find RepliedMessageText by xpath: //*[starts-with(@text,'test message')]/preceding::android.widget.TextView[@content-desc='quoted-message']
    Device 1: RepliedMessageText is 🇱🇷 

    critical/test_public_chat_browsing.py:526: in test_community_emoji_send_copy_paste_reply
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Emoji message was not copied

    [[flaky test; sometimes can not be copied through appium]]

    Device sessions

    3. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:461: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:927: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Find ChatMessageInput by accessibility id: chat-message-input
    Device 1: Clear text in ChatMessageInput 

    critical/test_public_chat_browsing.py:353: in test_community_copy_and_paste_message_in_chat_input
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message mmmeowesage_text text was not copied in community channel
E    Message https://status.im text was not copied in community channel

    [[flaky test; sometimes can not be copied through appium]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    # STEP: Send emoji message to Device 1 while it's on background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:1171: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:937: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Text is Delivered
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:227: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin



    Device sessions

    Passed tests (2)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808
    Device sessions

    @ajayesivan ajayesivan force-pushed the 15853-app-locked-accent-color-fix branch from ff79e79 to 31440e6 Compare May 11, 2023 09:53
    @ajayesivan
    Copy link
    Contributor Author

    @qoqobolo I have rebased this PR.

    @qoqobolo
    Copy link
    Contributor

    Thanks for your work @ajayesivan!
    PR can be merged.

    @ajayesivan ajayesivan force-pushed the 15853-app-locked-accent-color-fix branch from 31440e6 to 408a83f Compare May 11, 2023 12:19
    @ajayesivan ajayesivan merged commit d284088 into develop May 11, 2023
    @ajayesivan ajayesivan deleted the 15853-app-locked-accent-color-fix branch May 11, 2023 12:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @briansztamfater briansztamfater briansztamfater approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    Assignees

    @ajayesivan ajayesivan

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    App locked screen - add accent color
    5 participants
    @ajayesivan @status-im-auto @qoqobolo @Parveshdhull @briansztamfater