Setup syncing timer fix

[ajayesivan]

fixes #15807

status: ready

[status-im-auto]

Jenkins Builds

Click to see older builds (16)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	fe74fdc	#1	2023-05-10 08:41:49	~6 min	android-e2e	🤖apk 📲
✔️	fe74fdc	#1	2023-05-10 08:41:59	~6 min	android	🤖apk 📲
✔️	fe74fdc	#1	2023-05-10 08:42:20	~7 min	tests	📄log
✔️	fe74fdc	#1	2023-05-10 08:42:55	~7 min	ios	📱ipa 📲
✔️	b3252f2	#2	2023-05-11 23:40:30	~5 min	android	🤖apk 📲
✔️	b3252f2	#2	2023-05-11 23:41:20	~6 min	ios	📱ipa 📲
✔️	b3252f2	#2	2023-05-11 23:41:51	~7 min	android-e2e	🤖apk 📲
✔️	b3252f2	#2	2023-05-11 23:41:53	~7 min	tests	📄log
✔️	dcd250a	#4	2023-05-16 12:41:36	~6 min	android	🤖apk 📲
✔️	dcd250a	#4	2023-05-16 12:42:01	~6 min	android-e2e	🤖apk 📲
✔️	dcd250a	#4	2023-05-16 12:42:12	~6 min	tests	📄log
✔️	dcd250a	#4	2023-05-16 12:46:39	~11 min	ios	📱ipa 📲
✔️	006ea5b	#5	2023-05-25 11:46:27	~6 min	android	🤖apk 📲
✔️	006ea5b	#5	2023-05-25 11:47:33	~7 min	android-e2e	🤖apk 📲
✔️	006ea5b	#5	2023-05-25 11:47:57	~7 min	ios	📱ipa 📲
✔️	006ea5b	#5	2023-05-25 11:51:36	~11 min	tests	📄log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	62cc321	#6	2023-05-25 12:03:41	~5 min	android-e2e	🤖apk 📲
✔️	62cc321	#6	2023-05-25 12:03:51	~5 min	android	🤖apk 📲
✔️	62cc321	#6	2023-05-25 12:05:35	~7 min	ios	📱ipa 📲
✔️	8502832	#7	2023-05-25 12:11:13	~5 min	android-e2e	🤖apk 📲
✔️	8502832	#7	2023-05-25 12:12:07	~6 min	ios	📱ipa 📲
✔️	8502832	#7	2023-05-25 12:12:55	~6 min	android	🤖apk 📲
✔️	8502832	#7	2023-05-25 12:14:15	~8 min	tests	📄log

[pavloburykh]

Hey @ajayesivan! Thanx for the PR. Please take a look at the following issue.

ISSUE 1 Sync code does not expire after 2 minutes and can be successfully used for syncing

Steps:

1. Generate Sync code on Device 1
2. Make screenshot of QR code because it will be unavailable after timer is up.
3. Wait until 2 minutes for expiration of timer
4. Scan Sync QR by Device 2
5. See if error about sync code expiration will appear for Device 2

Actual result: error does not appear. Sync code does not expire and can be used after expiration period is up.

Expected result: sync code should expire in 2 minutes after being generated. Using expired code should result in error "This sync code has expired". Figma

[pavloburykh]

@ajayesivan I will move PR to CONTRIBUTOR column. Please, move it to E2E column when its ready for re-test. Thank you!

[ajayesivan]

Hey @ajayesivan! Thanx for the PR. Please take a look at the following issue.

ISSUE 1 Sync code does not expire after 2 minutes and can be successfully used for syncing

Steps:

1. Generate Sync code on Device 1
2. Make screenshot of QR code because it will be unavailable after timer is up.
3. Wait until 2 minutes for expiration of timer
4. Scan Sync QR by Device 2
5. See if error about sync code expiration will appear for Device 2

Actual result: error does not appear. Sync code does not expire and can be used after expiration period is up.

Expected result: sync code should expire in 2 minutes after being generated. Using expired code should result in error "This sync code has expired". Figma

@pavloburykh This bug was not introduced in this PR, so can we go ahead and merge this PR? I will take care of this separately(#15945).

[pavloburykh]

@pavloburykh This bug was not introduced in this PR, so can we go ahead and merge this PR? I will take care of this separately(#15945).

Hi @ajayesivan ! Sounds good. Should this PR be retested after rebasing branch? I see there are a lot of new commits in develop which could result in conflicts after rebasing. If re-test is not needed - then you are good to merge.