Adapt to status-go backend changes for ConvertToKeycardAccount #15846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasom
approved these changes
May 9, 2023
Jenkins Builds
|
ilmotta
approved these changes
May 9, 2023
qfrank
force-pushed
the
chore/adapt-change-to-ConvertToKeycardAccount
branch
from
bfd78fd
to
bd4e2b9
Compare
|
Thanks @qfrank, just now I faced an issue due to the signature change after pointing status-mobile to the latest status-go revision. My lesson learned so far (maybe obvious to you guys): don't rebase status-go against develop all the time, many times (like now) I had to spin off a new branch to start from the revision supported by status-mobile. |
I see, thank you for your note 🫶 @ilmotta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate comment