Add share tab in shell #15782
Merged
Add share tab in shell #15782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (70)
|
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
from
e880a26
to
08a7bf3
Compare
✔️ status-mobile/prs/ios/PR-15782#8 🔹 ~7 min 10 sec 🔹 958f408 🔹 📦 ios package |
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
5 times, most recently
from
6b6b37b
to
780330c
Compare
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
2 times, most recently
from
9a6969d
to
45f4368
Compare
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
from
5c9f471
to
ea901b6
Compare
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
from
564e325
to
8334cfe
Compare
|
Hey @pavloburykh : Tagging you since you already had tested #15528 and this PR is basically a follow up to that one. |
87% of end-end tests have passedFailed tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (27)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
vkjr
approved these changes
May 15, 2023
jo-mut
reviewed
May 15, 2023
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
from
c9440bf
to
003415a
Compare
|
Hi @pavloburykh : Issue 1,2 and 3 are related and should be fixed in latest commit. Regarding this question : "is it possible to prevent this empty loading state of already generated QR when user comes back from background?" I'll investigate further, If it the solution turns out to be a lot of work, we could log this in another issue. I'll keep you posted 👍🏻 |
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
2 times, most recently
from
26b773b
to
8228249
Compare
|
Hi @pavloburykh, |
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
from
8228249
to
85f8933
Compare
flexsurfer
reviewed
May 16, 2023
|
|
||
| (defn qr-code | ||
| [{:keys [source width height]}] | ||
| [rn/view | ||
| {:style style/container} | ||
| [rn/image | ||
| [fast-image/fast-image |
There was a problem hiding this comment.
fast-image gets rid of the flickering introduced when we change tabs. According to the author of the library they use "Aggressive Caching", ref : https://github.com/DylanVann/react-native-fast-image/blob/main/docs/how-is-caching-handled.md
84% of end-end tests have passedFailed tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Passed tests (27)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
from
900f471
to
2293ed4
Compare
|
@siddarthkay thanx for the fixes! I am partially reproducing ISSUE 1 User is not redirected to profile screen until first re-loginSteps:
Actual result: user is not redirected to profile screen. Redirection starts working after first logout. redirect_failed.mp4 |
ISSUE 5 Chat key is located to close to share button (IOS)
|
|
@siddarthkay decided to fix remaining issues in followups. PR is ready for merge. |
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
from
2fde0d0
to
3450a54
Compare
fixes: #13439 Summary - Update `quo2/qr-code` component to use `fast-image` instead of `rn/image` - Adds profile tab in share section, wallet tab is marked as WIP - Shows profile QR code along with link to user's profile and the user's emoji hash. - profile link is shareable and copyable on tap. - emoji hash is shareable and copyable on tap. - fixed weird android issues
siddarthkay
force-pushed
the
add-share-tab-in-shell
branch
from
3450a54
to
0665f20
Compare
|
@pavloburykh : I made this for #15926 to keep track of progress on ISSUE 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made this PR because it was almost impossible to rebase : #15528
fixes: #13439
Summary
quo2/qr-codecomponent to usefast-imageinstead ofrn/imagescreenshots :
IOS
Android
status: ready