Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused code relate to old text-input component #15765

Merged
merged 2 commits into from
Apr 28, 2023
Merged

remove unused code relate to old text-input component #15765

merged 2 commits into from
Apr 28, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Apr 27, 2023

when i was trying to move mention implementation to status-go , i found we have 2 components for input:

src/status_im/ui/screens/chat/components/input.cljs
src/status_im/ui2/screens/chat/composer/input.cljs

the latter one is a new implementation, src/status_im/ui/screens/chat/components/input.cljs can be safely removed now.

Testing notes

small refactor relate to mention has been included in this PR. edit message should works as before.

Platforms

  • Android
  • iOS

status: ready

@qfrank qfrank self-assigned this Apr 27, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Apr 27, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0d7685f #3 2023-04-27 09:54:36 ~6 min android 🤖apk 📲
✔️ 0d7685f #3 2023-04-27 09:55:07 ~6 min ios 📱ipa 📲
✔️ 0d7685f #3 2023-04-27 09:56:04 ~7 min tests 📄log
✔️ 0d7685f #3 2023-04-27 09:56:10 ~7 min android-e2e 🤖apk 📲
✔️ f4a546d #4 2023-04-28 01:34:30 ~5 min android-e2e 🤖apk 📲
✔️ f4a546d #4 2023-04-28 01:35:01 ~5 min android 🤖apk 📲
✔️ f4a546d #4 2023-04-28 01:35:06 ~6 min tests 📄log
✔️ f4a546d #4 2023-04-28 01:36:02 ~6 min ios 📱ipa 📲

@pavloburykh pavloburykh self-assigned this Apr 27, 2023
J-Son89
J-Son89 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@status-im-auto
Copy link
Member

79% of end-end tests have passed

Total executed tests: 29
Failed tests: 6
Passed tests: 23
Not executed tests: 1

IDs of not executed tests: 703086 

IDs of failed tests: 702958,702745,702850,702957,702731,702838

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (6)

    Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Tap on found: Button
    Device 2: Find `Text` by `xpath`: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` 

    medium/test_activity_center.py:138: in test_activity_center_contact_request_decline
    if self.home_2.pending_contact_request_text.text != '1':
../views/base_element.py:391: in text
    text = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen

    [[Blocked by 15500]]

    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 2: Clearing history in chat 'user1' by long press
    Device 2: Looking for chat: 'user1' 

    medium/test_activity_center.py:374: in test_activity_center_admin_notification_accept_swipe
    self.home_2.clear_chat_long_press(self.default_username_1)
../views/home_view.py:453: in clear_chat_long_press
    self.get_chat(username).long_press_element()
../views/base_element.py:292: in long_press_element
    element = self.find_element()
../views/home_view.py:64: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'user1')]/..` is not found on the screen after wait_for_visibility_of_element

    [[Blocked by 15500]]

    Device sessions

    2. test_activity_center_mentions, id: 702957

    Device 2: Type @ to ChatMessageInput
    Device 2: Find SendMessageButton by accessibility id: send-message-button 

    medium/test_activity_center.py:342: in test_activity_center_mentions
    self.channel_2.send_message_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: SendMessageButton by accessibility id: `send-message-button` is not found on the screen

    [[Blocked by 15500]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Looking for a message by text: hello
    Device 2: Find TimeStampText by xpath: //*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp'] 

    critical/chats/test_1_1_public_chats.py:1118: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    timestamp = self.chat_2.chat_element_by_text(messages[0]).timestamp
../views/chat_view.py:162: in timestamp
    return TimeStampText(self.driver, self.locator).text
../views/base_element.py:209: in text
    return self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: TimeStampText by xpath: `//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp']` is not found on the screen



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731

    Device 2: Looking for a message by text: Message 2
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'Message 2')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/chats/test_1_1_public_chats.py:1022: in test_1_1_chat_pin_messages
    self.chat_2.pin_message(self.message_2, 'pin-to-chat')
../views/chat_view.py:947: in pin_message
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:298: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'Message 2')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (23)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Apr 27, 2023 •
    edited
    Loading

    @qfrank thanx for the PR. Please take a look at the following issue

    ISSUE 1 Mention text overlays message text when mention is added during message editing (Android)

    Reproducible only for Android

    Steps:

    1. Open any chat
    2. Send a message
    3. Edit message: add mention during editing
    4. See how message looks after editing

    Actual result: mention overlays message text. It is fixed after chat reopening.

    photo_2023-04-27 15 51 06

    telegram-cloud-document-2-5357046119127853093.mp4

    @status-im-auto
    Copy link
    Member

    93% of end-end tests have passed

    Total executed tests: 29
Failed tests: 2
Passed tests: 27
Not executed tests: 1

    IDs of not executed tests: 703086 

    IDs of failed tests: 702838,702850

    Not executed tests (1)

    Click to expand
  • Rerun not executed tests

    • Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Tap on found: Button
    Device 2: Find `Text` by `xpath`: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` 

    medium/test_activity_center.py:138: in test_activity_center_contact_request_decline
    if self.home_2.pending_contact_request_text.text != '1':
../views/base_element.py:391: in text
    text = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen

    [[Blocked by 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (27)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_unread_messages_badge, id: 702841
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_message_edit, id: 702843
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_mentions_push_notification, id: 702786
    Device sessions

    6. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    7. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    8. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    3. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_pin_messages, id: 702732
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    @qfrank
    Copy link
    Contributor Author

    qfrank commented Apr 27, 2023 •
    edited
    Loading

    @qfrank thanx for the PR. Please take a look at the following issue

    ISSUE 1 Mention text overlays message text when mention is added during message editing (Android)

    Reproducible only for Android

    Steps:

    1. Open any chat
    2. Send a message
    3. Edit message: add mention during editing
    4. See how message looks after editing

    Actual result: mention overlays message text. It is fixed after chat reopening.

    photo_2023-04-27 15 51 06

    telegram-cloud-document-2-5357046119127853093.mp4

    Hi @pavloburykh , can you check if this issue also exist on latest develop branch? if it does, it won't be fixed in this PR

    @pavloburykh
    Copy link
    Contributor

    Hi @pavloburykh , can you check if this issue also exist on latest develop branch? if it does, it won't be fixed in this PR

    My bad @qfrank. It exists in develop. Very weird, as it has been recently fixed. Will log this issue separately then.

    @pavloburykh
    Copy link
    Contributor

    @qfrank PR is ready to be merged. Thank you!

    @qfrank qfrank merged commit ee71117 into develop Apr 28, 2023
    @qfrank qfrank deleted the chore/remove-unused-code branch April 28, 2023 01:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @rasom rasom rasom approved these changes

    @yqrashawn yqrashawn Awaiting requested review from yqrashawn

    Assignees

    @qfrank qfrank

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @qfrank @status-im-auto @pavloburykh @rasom @flexsurfer @J-Son89