[15569] Select recent tab on messages home when double tapping messages icon #15604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (52)
|
ibrkhalil
changed the title
ilmotta
approved these changes
Apr 10, 2023
This PR uses GestureHandler to select the recent tab on the messages home screen, This was achievable by moving the selected tab atom to app-db and not to be local state inside the UI component.
This PR uses GestureHandler to select the recent tab on the messages home screen, This was achievable by moving the selected tab atom to app-db and not to be local state inside the UI component.
|
hi @ibrkhalil let me know please if this PR is ready for tests |
It's ready now @VladimrLitvinenko |
90% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (26)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
|
|
hi @ibrkhalil. Thank you for PR. Here a list of found issues: ISSUE 1: The "pending contact" requests and mutual contacts are not shown in the 'Contacts' tap after CR is sentSteps to reproduce:
Actual result'Pending request' and added contacts are not shown into the 'Contact request' tab Expected result
|
ISSUE 2: The 1-1 chats and group chats shown in all tabsSteps to reproduce:
Actual result:
groups.mp4Expected result:
|
flexsurfer
requested changes
Apr 17, 2023
src/status_im2/subs/root.cljs
Outdated
| @@ -281,3 +283,6 @@ | |||
| (reg-root-key-sub :messenger/started? :messenger/started?) | |||
|
|
|||
| (reg-root-key-sub :information-box-states :information-box-states) | |||
|
|
|||
| ; Messages home view -> tabs | |||
| (reg-root-key-sub :messages-home/selected-tab :messages-home/selected-tab :tab/recent) | |||
There was a problem hiding this comment.
this logic shouldn't be hidden in the key registration, this should be implemented on the view level
| :left 51 | ||
| :position :absolute | ||
| :background-color colors/primary-50}}]))]] | ||
| double-tap-gesture (conj [gesture/gesture-detector {:gesture double-tap-gesture}]))))]) |
There was a problem hiding this comment.
are we sure we want to add this into component? why don't just have this in the view level?
[gesture/gesture-detector {:gesture double-tap-gesture}
[bottom-nav-tab| (animation/load-stack @animation/selected-stack-id) | ||
| (reanimated/set-shared-value (:pass-through? shared-values) pass-through?) | ||
| [reanimated/view {:style animated-style} | ||
| (when pass-through? | ||
| [blur/view (blur-overlay-params style/bottom-tabs-blur-overlay)]) | ||
| [rn/view {:style (style/bottom-tabs)} | ||
| [bottom-tab :i/communities :communities-stack shared-values notifications-data] | ||
| [bottom-tab :i/messages :chats-stack shared-values notifications-data] | ||
| [bottom-tab :i/messages :chats-stack shared-values notifications-data |
There was a problem hiding this comment.
its better and simpler to do not implement this into the component, but just wrap bottom-tab here into gesture
flexsurfer
approved these changes
Apr 17, 2023
86% of end-end tests have passedFailed tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (25)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
100% of end-end tests have passedPassed tests (1)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
Hi @ibrkhalil thank you for fixes. Issue 1,2 are fixed. PR is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15569
Summary
This PR uses
GestureHandlerto select the recent tab on the messages home screen, This was achievable by moving the selected tabatomtoapp-dband not to be local state inside the UI component to make it accessible from anywhere.Review notes
I didn't write tests for the event because it was really simply, Just
associng a keyword.Testing notes
Double tap on the bottom navigation's messages icon and see if recent tab is selected.
Platforms
Steps to test
status: ready