Update contact screen to new design #15526

erikseppanen · 2023-03-29T00:12:38Z

status: ready

status-im-auto · 2023-03-29T00:18:54Z

Jenkins Builds

Click to see older builds (28)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`11fab1f`	#1	2023-03-29 00:18:53	~5 min	`tests`	📄`log`
✔️	`11fab1f`	#1	2023-03-29 00:20:45	~7 min	`ios`	📱`ipa` 📲
✔️	`11fab1f`	#1	2023-03-29 00:21:34	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`11fab1f`	#1	2023-03-29 00:22:05	~9 min	`android`	🤖`apk` 📲

✔️	`690cd6a`	#2	2023-03-29 20:00:11	~7 min	`ios`	📱`ipa` 📲
✔️	`690cd6a`	#2	2023-03-29 20:00:39	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`690cd6a`	#2	2023-03-29 20:00:46	~8 min	`android`	🤖`apk` 📲
✔️	`690cd6a`	#2	2023-03-29 20:02:07	~9 min	`tests`	📄`log`

✔️	`827b48b`	#3	2023-03-30 19:13:50	~5 min	`tests`	📄`log`
✔️	`827b48b`	#3	2023-03-30 19:16:32	~8 min	`ios`	📱`ipa` 📲
✔️	`827b48b`	#3	2023-03-30 19:16:38	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`827b48b`	#3	2023-03-30 19:16:52	~8 min	`android`	🤖`apk` 📲

✔️	`7562207`	#4	2023-03-31 12:48:50	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`7562207`	#4	2023-03-31 12:49:22	~8 min	`tests`	📄`log`
✔️	`7562207`	#4	2023-03-31 12:49:36	~8 min	`android`	🤖`apk` 📲
✔️	`7562207`	#4	2023-03-31 12:52:17	~11 min	`ios`	📱`ipa` 📲

✔️	`49de27b`	#5	2023-03-31 17:39:57	~6 min	`tests`	📄`log`
✔️	`49de27b`	#5	2023-03-31 17:41:38	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`49de27b`	#5	2023-03-31 17:41:56	~8 min	`android`	🤖`apk` 📲
✔️	`49de27b`	#5	2023-03-31 17:45:05	~11 min	`ios`	📱`ipa` 📲

✔️	`4c46fb9`	#6	2023-04-01 14:53:02	~5 min	`tests`	📄`log`
✔️	`4c46fb9`	#6	2023-04-01 14:54:25	~7 min	`ios`	📱`ipa` 📲
✔️	`4c46fb9`	#6	2023-04-01 14:54:53	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`4c46fb9`	#6	2023-04-01 14:55:20	~8 min	`android`	🤖`apk` 📲

✔️	`d695c1e`	#7	2023-04-12 00:16:18	~6 min	`tests`	📄`log`
✔️	`d695c1e`	#7	2023-04-12 00:17:23	~7 min	`ios`	📱`ipa` 📲
✔️	`d695c1e`	#7	2023-04-12 00:17:54	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`d695c1e`	#7	2023-04-12 00:19:06	~9 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`29280f5`	#8	2023-04-14 22:24:21	~6 min	`tests`	📄`log`
✔️	`29280f5`	#8	2023-04-14 22:24:30	~6 min	`android`	🤖`apk` 📲
✔️	`29280f5`	#8	2023-04-14 22:24:40	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`29280f5`	#8	2023-04-14 22:25:21	~7 min	`ios`	📱`ipa` 📲

✔️	`ae9c5aa`	#9	2023-04-18 17:22:03	~6 min	`tests`	📄`log`
✔️	`ae9c5aa`	#9	2023-04-18 17:22:19	~6 min	`android`	🤖`apk` 📲
✔️	`ae9c5aa`	#9	2023-04-18 17:22:23	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ae9c5aa`	#9	2023-04-18 17:23:34	~7 min	`ios`	📱`ipa` 📲

J-Son89 · 2023-03-29T12:35:09Z

This pr looks good. A side point to this section of the codebase however. To me the add_new_contact does not justify being it's own "context" in the codebase. I think we should try to find somewhere more suitable to have this code. Either in src/status_im2/contexts/contacts/add_new_contact/... or in src/status_im2/common/add_new_contacts/...

erikseppanen · 2023-03-29T13:36:17Z

This pr looks good. A side point to this section of the codebase however. To me the add_new_contact does not justify being it's own "context" in the codebase. I think we should try to find somewhere more suitable to have this code. Either in src/status_im2/contexts/contacts/add_new_contact/... or in src/status_im2/common/add_new_contacts/...

Thanks for reviewing @J-Son89!

I'm happy to move it wherever we think it should be. There were some discussions regarding its location here and here.

J-Son89 · 2023-03-29T13:46:44Z

This pr looks good. A side point to this section of the codebase however. To me the add_new_contact does not justify being it's own "context" in the codebase. I think we should try to find somewhere more suitable to have this code. Either in src/status_im2/contexts/contacts/add_new_contact/... or in src/status_im2/common/add_new_contacts/...

Thanks for reviewing @J-Son89!

I'm happy to move it wherever we think it should be. There were some discussions regarding its location here and here.

okay, seems like you should leave it for now and we need to open up a discussion on defining what a "context" is.
As I would have understood it, Browser, Wallet, Chats and Communities ( the bottom 4 tabs), User Profile and onboarding are contexts. I would not consider Quo_Previews to be a relevant context but this is an exception.
Anyway we are many devs so best to agree among the team

erikseppanen · 2023-03-29T13:59:06Z

This pr looks good. A side point to this section of the codebase however. To me the add_new_contact does not justify being it's own "context" in the codebase. I think we should try to find somewhere more suitable to have this code. Either in src/status_im2/contexts/contacts/add_new_contact/... or in src/status_im2/common/add_new_contacts/...

Thanks for reviewing @J-Son89!
I'm happy to move it wherever we think it should be. There were some discussions regarding its location here and here.

okay, seems like you should leave it for now and we need to open up a discussion on defining what a "context" is. As I would have understood it, Browser, Wallet, Chats and Communities ( the bottom 4 tabs), User Profile and onboarding are contexts. I would not consider Quo_Previews to be a relevant context but this is an exception. Anyway we are many devs so best to agree among the team

Sounds good @J-Son89! I agree it would be an improvement to reduce confusion regarding contexts, albeit a low-priority one. If you're interested, there was a bit more discussion regarding contexts here and here. And the discussion here takes a stab at reasoning about the dimensions along which we organize the codebase, contexts being one of them.

OmarBasem · 2023-03-29T21:12:20Z

src/status_im2/contexts/add_new_contact/views.cljs

@@ -5,7 +5,6 @@
    [react-native.core :as rn]


Hi @erikseppanen, this screen should use bottom-sheet-screen #15399

OmarBasem · 2023-03-30T22:57:59Z

src/status_im2/contexts/add_new_contact/views.cljs

+                        (reset! clipboard nil)
+                        (reset! default-value nil)
+                        (rf/dispatch [:contacts/clear-new-identity])
+                        (rf/dispatch [:navigate-back]))}) :i/close]


close parameter from bottom-sheet-screen should be used to navigate back, because it executes an animation to the background layer

Thanks @OmarBasem! Done.

@erikseppanen there is a recent commit into develop that simplifies the API for bottom sheet screen. You don't need to wrap the component. You just need to pass :options {:sheet? true} in navigation options.

Thanks @OmarBasem! Done

OmarBasem · 2023-04-14T20:39:14Z

Hi @erikseppanen,
I have noticed this PR has been approved for quite some time and has not merged yet. Are you facing any problems with this PR?

erikseppanen · 2023-04-14T22:14:03Z

Hi @OmarBasem It's ready for QA. I'll rebase now.

status-im-auto · 2023-04-17T09:17:30Z

33% of end-end tests have passed

Total executed tests: 3
Failed tests: 2
Passed tests: 1
Not executed tests: 26

IDs of not executed tests: 702730,702782,702731,702745,702813,702855,702733,702783,702807,702732,702808,702838,702843,702839,702840,702841,702844,702894,702845,702786,702846,702742,702936,702947,702957,702958

IDs of failed tests: 702850,702784

Not executed tests (26)

Click to expand

Rerun not executed tests

Failed tests (2)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850

Device 2: Find `Button` by `accessibility id`: `tab-recent`
Device 2: Tap on found: Button

medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

[[Blocked by 15500]]

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
`Test setup failed: critical/chats/test_1_1_public_chats.py:908: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) cannot unpack non-iterable NoneType object`

Passed tests (1)

Click to expand

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2023-04-17T16:37:08Z

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

IDs of failed tests: 702838,702850

Failed tests (2)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850

Device 2: Find `Button` by `accessibility id`: `tab-recent`
Device 2: Tap on found: Button

medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

[[Blocked by 15500]]

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by 14797]]

Device sessions

Device 1:

Device 2:

Passed tests (27)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

qoqobolo · 2023-04-18T09:04:07Z

Thanks for your work @erikseppanen!
PR is tested and can be merged.

erikseppanen self-assigned this Mar 29, 2023

J-Son89 approved these changes Mar 29, 2023

View reviewed changes

erikseppanen force-pushed the issue-15240 branch from 11fab1f to 690cd6a Compare March 29, 2023 19:52

OmarBasem reviewed Mar 29, 2023

View reviewed changes

erikseppanen force-pushed the issue-15240 branch from 690cd6a to 827b48b Compare March 30, 2023 19:07

OmarBasem approved these changes Mar 30, 2023

View reviewed changes

erikseppanen force-pushed the issue-15240 branch from 827b48b to 7562207 Compare March 31, 2023 12:40

erikseppanen added a commit that referenced this pull request Mar 31, 2023

Update contact screen to new design (#15526)

49de27b

erikseppanen force-pushed the issue-15240 branch from 7562207 to 49de27b Compare March 31, 2023 17:33

erikseppanen added a commit that referenced this pull request Apr 1, 2023

Update contact screen to new design (#15526)

4c46fb9

erikseppanen force-pushed the issue-15240 branch from 49de27b to 4c46fb9 Compare April 1, 2023 14:46

erikseppanen added a commit that referenced this pull request Apr 12, 2023

Update contact screen to new design (#15526)

d695c1e

erikseppanen force-pushed the issue-15240 branch from 4c46fb9 to d695c1e Compare April 12, 2023 00:09

erikseppanen closed this Apr 14, 2023

erikseppanen reopened this Apr 14, 2023

erikseppanen added a commit that referenced this pull request Apr 14, 2023

Update contact screen to new design (#15526)

29280f5

erikseppanen force-pushed the issue-15240 branch from d695c1e to 29280f5 Compare April 14, 2023 22:18

flexsurfer added the request-manual-qa label Apr 17, 2023

qoqobolo self-assigned this Apr 17, 2023

qoqobolo added the Tested - OK label Apr 18, 2023

Update contact screen to new design (#15526)

ae9c5aa

erikseppanen force-pushed the issue-15240 branch from 29280f5 to ae9c5aa Compare April 18, 2023 17:15

erikseppanen merged commit 5d0b739 into develop Apr 18, 2023

erikseppanen deleted the issue-15240 branch April 18, 2023 17:28

ibrkhalil pushed a commit that referenced this pull request Apr 20, 2023

Update contact screen to new design (#15526)

ff22ba1

alwx pushed a commit that referenced this pull request Apr 28, 2023

Update contact screen to new design (#15526)

3b07405

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update contact screen to new design #15526

Update contact screen to new design #15526

erikseppanen commented Mar 29, 2023

status-im-auto commented Mar 29, 2023 •

edited

Loading

J-Son89 commented Mar 29, 2023

erikseppanen commented Mar 29, 2023 •

edited

Loading

J-Son89 commented Mar 29, 2023

erikseppanen commented Mar 29, 2023

OmarBasem Mar 29, 2023

erikseppanen Mar 30, 2023

OmarBasem Mar 30, 2023

erikseppanen Mar 31, 2023

OmarBasem Mar 31, 2023 •

edited

Loading

erikseppanen Apr 1, 2023

OmarBasem commented Apr 14, 2023

erikseppanen commented Apr 14, 2023 •

edited

Loading

status-im-auto commented Apr 17, 2023

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

status-im-auto commented Apr 17, 2023

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Apr 18, 2023

Update contact screen to new design #15526

Update contact screen to new design #15526

Conversation

erikseppanen commented Mar 29, 2023

status-im-auto commented Mar 29, 2023 • edited Loading

Jenkins Builds

J-Son89 commented Mar 29, 2023

erikseppanen commented Mar 29, 2023 • edited Loading

J-Son89 commented Mar 29, 2023

erikseppanen commented Mar 29, 2023

OmarBasem Mar 29, 2023

Choose a reason for hiding this comment

erikseppanen Mar 30, 2023

Choose a reason for hiding this comment

OmarBasem Mar 30, 2023

Choose a reason for hiding this comment

erikseppanen Mar 31, 2023

Choose a reason for hiding this comment

OmarBasem Mar 31, 2023 • edited Loading

Choose a reason for hiding this comment

erikseppanen Apr 1, 2023

Choose a reason for hiding this comment

OmarBasem commented Apr 14, 2023

erikseppanen commented Apr 14, 2023 • edited Loading

status-im-auto commented Apr 17, 2023

33% of end-end tests have passed

Not executed tests (26)

Failed tests (2)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (1)

Class TestActivityCenterContactRequestMultipleDevicePR:

status-im-auto commented Apr 17, 2023

93% of end-end tests have passed

Failed tests (2)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Passed tests (27)

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Apr 18, 2023

status-im-auto commented Mar 29, 2023 •

edited

Loading

erikseppanen commented Mar 29, 2023 •

edited

Loading

OmarBasem Mar 31, 2023 •

edited

Loading

erikseppanen commented Apr 14, 2023 •

edited

Loading