Implement Information box and ens banner view #13753

Parveshdhull · 2022-08-02T22:36:54Z

Summary

PR implements Info Message and Information Box component, and also adds ENS Banner for release 1.20

status: ready

status-im-auto · 2022-08-02T22:47:31Z

Jenkins Builds

Click to see older builds (22)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`6100d67`	#1	2022-08-02 22:47:30	~10 min	`ios`	📦`ipa` 📲
✔️	`6100d67`	#1	2022-08-02 22:49:31	~12 min	`android`	📦`apk` 📲

✔️	`506c84c`	#5	2022-08-05 21:06:40	~7 min	`android-e2e`	📦`apk` 📲
✔️	`506c84c`	#5	2022-08-05 21:07:05	~7 min	`android`	📦`apk` 📲
✔️	`506c84c`	#5	2022-08-05 21:10:00	~10 min	`ios`	📦`ipa` 📲

✔️	`3a4c442`	#6	2022-08-08 13:16:39	~7 min	`android-e2e`	📦`apk` 📲
✔️	`3a4c442`	#6	2022-08-08 13:16:44	~7 min	`android`	📦`apk` 📲
✔️	`3a4c442`	#6	2022-08-08 13:19:21	~10 min	`ios`	📦`ipa` 📲

✔️	`ee36298`	#7	2022-08-08 13:32:05	~9 min	`android-e2e`	📦`apk` 📲
✔️	`ee36298`	#7	2022-08-08 13:34:26	~11 min	`ios`	📦`ipa` 📲

✔️	`785d7b0`	#9	2022-08-08 21:13:06	~9 min	`android`	📦`apk` 📲
✔️	`785d7b0`	#9	2022-08-08 21:13:59	~9 min	`ios`	📦`ipa` 📲

✔️	`4f5d383`	#10	2022-08-08 21:37:04	~10 min	`android-e2e`	📦`apk` 📲
✔️	`4f5d383`	#10	2022-08-08 21:37:13	~10 min	`android`	📦`apk` 📲
✖️	`4f5d383`	#10	2022-08-08 21:43:17	~16 min	`ios`	📦`ipa` 📲

✔️	`968a8f3`	#11	2022-08-08 21:55:41	~9 min	`android`	📦`apk` 📲
✔️	`968a8f3`	#11	2022-08-08 21:56:38	~10 min	`ios`	📦`ipa` 📲

✔️	`4802dd0`	#12	2022-08-10 20:45:11	~8 min	`android`	📦`apk` 📲
✔️	`4802dd0`	#12	2022-08-10 20:46:37	~10 min	`ios`	📦`ipa` 📲

✔️	`e6fa742`	#13	2022-08-10 21:28:03	~8 min	`android-e2e`	📦`apk` 📲
✔️	`e6fa742`	#13	2022-08-10 21:28:24	~9 min	`android`	📦`apk` 📲
✔️	`e6fa742`	#13	2022-08-10 21:29:15	~9 min	`ios`	📦`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`bf3a5f2`	#15	2022-08-11 16:28:03	~8 min	`android-e2e`	📦`apk` 📲
✔️	`bf3a5f2`	#15	2022-08-11 16:29:54	~10 min	`ios`	📦`ipa` 📲

✔️	`f1f9fa1`	#16	2022-08-11 16:46:50	~8 min	`android-e2e`	📦`apk` 📲
✔️	`f1f9fa1`	#16	2022-08-11 16:47:10	~9 min	`android`	📦`apk` 📲
✔️	`f1f9fa1`	#16	2022-08-11 16:49:40	~11 min	`ios`	📦`ipa` 📲

src/quo2/foundations/typography.cljs

Parveshdhull · 2022-08-08T13:44:58Z

Looks like component is not perfectly aligning with design, due to different letter spacing

flexsurfer

nice! great job!

translations/en.json

src/quo2/foundations/typography.cljs

src/quo2/components/information_box.cljs

Parveshdhull · 2022-08-08T23:36:29Z

src/quo2/foundations/typography.cljs

@@ -1,26 +1,25 @@
 (ns quo2.foundations.typography)

-;; Formulat for letter spacing from figma %: 16/{figma-percentage)*100


this can't be the formula for letter-spacing, as it is inversely proportional,
when there should be more spacing it will give less, when there should be less like 0, it will give infinite

[UPDATED] ~~@Parveshdhull Figma can also express the letter spacing in em rather than percentages. The body text having a spacing of -0.003em cc @pedro-et~~

There's a formula provided for the Inter font here: https://rsms.me/inter/dynmetrics/ (formula for letter-spacing which is 'tracking'). As far as I can tell we haven't deviated from this formula and you should be able to use it to set the letter-spacing. I'll leave it to @pedro-et to confirm this though

hi @hesterbruikman, Thank you very much for the link, I will explore the program/formula and see how it can be used.

src/quo2/components/information_box.cljs

status-im-auto · 2022-08-10T22:35:54Z

94% of end-end tests have passed

Total executed tests: 87
Failed tests: 5
Passed tests: 82

IDs of failed tests: 702157,702153,702394,702156,702155

Failed tests (5)

Click to expand

Rerun failed tests

Class TestPairingSyncMultipleDevicesMerged:

1. test_pairing_sync_clear_history, id: 702394
Device 1: Long press on `ChatElement` Device 1: Find `Button` by `accessibility id`: `clear-history-button` `critical/test_pairing_devices_sync.py:291: in test_pairing_sync_clear_history self.home_1.clear_chat_long_press('#%s' % self.public_chat_before_sync) ../views/home_view.py:384: in clear_chat_long_press self.clear_history_button.click() ../views/ba` Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestEnsStickersMultipleDevicesMerged:

1. test_sticker_1_1_public_chat_mainnet, id: 702157
Device 2: Double tap on: HomeButton Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1120: in test_sticker_1_1_public_chat_mainnet [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1120: in [home.home_button.double_cli` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Device 2: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented Device 2: Wait for text element `TransactionStatus` to be equal to `Confirmed` `critical/chats/test_1_1_public_chats.py:1033: in test_ens_command_send_tx_eth_1_1_chat chat_2_reciever_message.transaction_status.wait_for_element_text(chat_2_reciever_message.confirmed, wait_time=60) ../views/base_element.py:154: in wait_for_element_` Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_ens_mention_push_highlighted_public_chat, id: 702156
Device 2: Double tap on: HomeButton Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1086: in test_ens_mention_push_highlighted_public_chat [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1086: in [home.home_button.d` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_ens_mention_nickname_1_1_chat, id: 702155
Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1037: in test_ens_mention_nickname_1_1_chat [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1037: in [home.home_button.double_click` Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (82)

Click to expand

Class TestRestoreOneDeviceMerged:

1. test_restore_set_up_wallet_sign_phrase, id: 700749
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_restore_seed_phrase_field_validation, id: 700750
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

1. test_contact_block_unblock_public_chat_offline, id: 702176
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestKeycardTxOneDeviceMerged:

1. test_keycard_relogin_after_restore, id: 700768
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_keycard_create_account_unlock_same_seed, id: 5689
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_keycard_send_tx_eth, id: 700767
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestPairingSyncMultipleDevicesMerged:

1. test_pairing_sync_contacts_block_unblock, id: 702196
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_pairing_sync_initial_profile_picture, id: 702392
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_pairing_sync_initial_bookmarks, id: 702393
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_pairing_sync_initial_contacts_blocked_users, id: 702194
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_pairing_sync_1_1_chat_message, id: 702198
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_pairing_sync_public_chat_add_remove, id: 702199
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_pairing_sync_initial_public_chats, id: 702195
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommandsMultipleDevicesMerged:

1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestSendTxDeviceMerged:

1. test_send_tx_eth_check_logcat, id: 700763
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_send_tx_token_8_decimals, id: 700764
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_send_tx_set_recipient_options, id: 700757
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 6315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_image_send_save_reply, id: 6305
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_text_message_with_push, id: 6316
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_push_emoji, id: 6283
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestPublicChatMultipleDeviceMerged:

1. test_public_chat_message_edit, id: 700734
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_public_chat_unread_messages_counter, id: 5360
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_public_chat_emoji_send_copy_paste_reply, id: 700719
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_public_chat_delete_chat_long_press, id: 5319
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_public_chat_link_send_open, id: 700736
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_public_chat_mark_all_messages_as_read, id: 6270
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_public_chat_message_delete, id: 700735
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletManagementDeviceMerged:

1. test_wallet_manage_assets, id: 700758
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_wallet_add_account_seed_phrase_validation, id: 700762
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_wallet_add_hide_unhide_account_private_key, id: 700761
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_wallet_add_delete_watch_only_account, id: 700760
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_wallet_add_account_generate_new, id: 700759
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMerged:

1. test_group_chat_push_system_messages_when_invited, id: 3994
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_highligted, id: 5756
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_join_send_text_messages_push, id: 700731
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_offline_pn, id: 3998
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_add_new_member_activity_centre, id: 700732
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_leave_relogin, id: 3997
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestPublicChatBrowserOneDeviceMerged:

1. test_public_chat_open_using_deep_link, id: 700739
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_browser_bookmarks_create_edit_remove, id: 702077
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_browser_blocked_url, id: 702072
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_browser_delete_close_tabs, id: 702076
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_browser_connection_is_secure_not_secure_warning, id: 702073
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_browser_web3_permissions_testdapp, id: 702078
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_public_chat_tag_message, id: 700738
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
8. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
9. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
10. test_public_chat_fetch_more_history, id: 5675
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
11. test_browser_offline, id: 702075
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
12. test_browser_invalid_url, id: 702074
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestOnboardingOneDeviceMerged:

1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_onboarding_home_initial_popup, id: 700742
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_onboarding_share_contact_address, id: 700743
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_onboarding_share_wallet_address, id: 700744
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestEnsStickersMultipleDevicesMerged:

1. test_ens_purchased_in_profile, id: 702152
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_start_new_chat_public_key_validation, id: 702158
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2022-08-11T06:53:51Z

20% of end-end tests have passed

Total executed tests: 5
Failed tests: 4
Passed tests: 1

IDs of failed tests: 702157,702153,702156,702155

Failed tests (4)

Click to expand

Rerun failed tests

Class TestEnsStickersMultipleDevicesMerged:

1. test_sticker_1_1_public_chat_mainnet, id: 702157
Device 2: Double tap on: HomeButton Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1120: in test_sticker_1_1_public_chat_mainnet [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1120: in [home.home_button.double_cli` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Device 2: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented Device 2: Wait for text element `TransactionStatus` to be equal to `Confirmed` `critical/chats/test_1_1_public_chats.py:1033: in test_ens_command_send_tx_eth_1_1_chat chat_2_reciever_message.transaction_status.wait_for_element_text(chat_2_reciever_message.confirmed, wait_time=60) ../views/base_element.py:154: in wait_for_element_` Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_ens_mention_push_highlighted_public_chat, id: 702156
Device 2: Double tap on: HomeButton Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1086: in test_ens_mention_push_highlighted_public_chat [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1086: in [home.home_button.d` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_ens_mention_nickname_1_1_chat, id: 702155
Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1037: in test_ens_mention_nickname_1_1_chat [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1037: in [home.home_button.double_click` Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (1)

Click to expand

Class TestPairingSyncMultipleDevicesMerged:

1. test_pairing_sync_clear_history, id: 702394
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2022-08-11T13:36:38Z

0% of end-end tests have passed

Total executed tests: 4
Failed tests: 4
Passed tests: 0

IDs of failed tests: 702157,702153,702156,702155

Failed tests (4)

Click to expand

Rerun failed tests

Class TestEnsStickersMultipleDevicesMerged:

1. test_sticker_1_1_public_chat_mainnet, id: 702157
Device 2: Double tap on: HomeButton Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1120: in test_sticker_1_1_public_chat_mainnet [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1120: in [home.home_button.double_cli` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Device 2: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented Device 2: Wait for text element `TransactionStatus` to be equal to `Confirmed` `critical/chats/test_1_1_public_chats.py:1033: in test_ens_command_send_tx_eth_1_1_chat chat_2_reciever_message.transaction_status.wait_for_element_text(chat_2_reciever_message.confirmed, wait_time=60) ../views/base_element.py:154: in wait_for_element_` Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_ens_mention_push_highlighted_public_chat, id: 702156
Device 2: Double tap on: HomeButton Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1086: in test_ens_mention_push_highlighted_public_chat [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1086: in [home.home_button.d` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_ens_mention_nickname_1_1_chat, id: 702155
Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` Device 2: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` `critical/chats/test_1_1_public_chats.py:1037: in test_ens_mention_nickname_1_1_chat [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1037: in [home.home_button.double_click` Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

qoqobolo · 2022-08-11T15:37:05Z

@Parveshdhull thanks for your great work!
Couldn't find any issues.
Checked:

upgrade from 1.19 to this PR (Android)
fresh installation (without upgrade)
new/recovered multi-account
multi-account with/without ENS
regular/keycard multi-account
several multi-accounts on one device
dark/light mode
iOS
with chats on the home screen
search field on the home screen
with communities enabled

One request: can you add an accessibility-id for this button, please? We'll need it for e2e fixes.

After this, PR can be merged.
Thanks!

Parveshdhull · 2022-08-11T15:38:32Z

One request: can you add an accessibility-id for this button, please? We'll need it for e2e fixes.

sure will do, thank you

Signed-off-by: Parvesh Monu <parvesh.dhullmonu@gmail.com>

Parveshdhull self-assigned this Aug 2, 2022

Parveshdhull changed the title ~~[WIP]: Implement Information box and implement ens banner view~~ [WIP]: Implement Information box and ens banner view Aug 2, 2022

Parveshdhull force-pushed the feature/ens-name-dialog branch 5 times, most recently from 506c84c to 3a4c442 Compare August 8, 2022 13:09

Parveshdhull changed the title ~~[WIP]: Implement Information box and ens banner view~~ Implement Information box and ens banner view Aug 8, 2022

Parveshdhull commented Aug 8, 2022

View reviewed changes

src/quo2/foundations/typography.cljs Show resolved Hide resolved

Parveshdhull force-pushed the feature/ens-name-dialog branch from 3a4c442 to ee36298 Compare August 8, 2022 13:22

Parveshdhull requested review from flexsurfer and cammellos August 8, 2022 13:23

Parveshdhull added the request-manual-qa label Aug 8, 2022

Parveshdhull marked this pull request as ready for review August 8, 2022 13:23

Parveshdhull requested a review from hesterbruikman August 8, 2022 13:29

flexsurfer approved these changes Aug 8, 2022

View reviewed changes

translations/en.json Show resolved Hide resolved

src/quo2/foundations/typography.cljs Show resolved Hide resolved

src/quo2/components/information_box.cljs Outdated Show resolved Hide resolved

Parveshdhull force-pushed the feature/ens-name-dialog branch 2 times, most recently from 785d7b0 to 4f5d383 Compare August 8, 2022 21:26

Parveshdhull commented Aug 8, 2022

View reviewed changes

flexsurfer reviewed Aug 9, 2022

View reviewed changes

src/quo2/components/information_box.cljs Outdated Show resolved Hide resolved

Parveshdhull force-pushed the feature/ens-name-dialog branch from 968a8f3 to 4802dd0 Compare August 10, 2022 20:36

Info message component

230005f

Parveshdhull force-pushed the feature/ens-name-dialog branch from 4802dd0 to e6fa742 Compare August 10, 2022 21:19

Parveshdhull mentioned this pull request Aug 10, 2022

Improve quo2 text component #13793

Closed

qoqobolo self-assigned this Aug 11, 2022

flexsurfer approved these changes Aug 11, 2022

View reviewed changes

qoqobolo added the Tested - OK label Aug 11, 2022

Parveshdhull force-pushed the feature/ens-name-dialog branch from e6fa742 to 92c5096 Compare August 11, 2022 16:13

Information box component

c1ca929

Parveshdhull force-pushed the feature/ens-name-dialog branch from 92c5096 to bf3a5f2 Compare August 11, 2022 16:18

Implement ENS Banner View

f1f9fa1

Signed-off-by: Parvesh Monu <parvesh.dhullmonu@gmail.com>

Parveshdhull force-pushed the feature/ens-name-dialog branch from bf3a5f2 to f1f9fa1 Compare August 11, 2022 16:37

Parveshdhull merged commit f1f9fa1 into develop Aug 11, 2022

Parveshdhull deleted the feature/ens-name-dialog branch August 11, 2022 16:40

J-Son89 mentioned this pull request Jun 14, 2023

Various fixes for the Information Box component #16272

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Information box and ens banner view #13753

Implement Information box and ens banner view #13753

Parveshdhull commented Aug 2, 2022 •

edited

Loading

status-im-auto commented Aug 2, 2022 •

edited

Loading

Parveshdhull commented Aug 8, 2022

flexsurfer left a comment

Parveshdhull Aug 8, 2022

hesterbruikman Aug 9, 2022 •

edited

Loading

Parveshdhull Aug 9, 2022

status-im-auto commented Aug 10, 2022

Class TestPairingSyncMultipleDevicesMerged:

Class TestEnsStickersMultipleDevicesMerged:

Class TestRestoreOneDeviceMerged:

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

Class TestKeycardTxOneDeviceMerged:

Class TestPairingSyncMultipleDevicesMerged:

Class TestCommandsMultipleDevicesMerged:

Class TestSendTxDeviceMerged:

Class TestOneToOneChatMultipleSharedDevices:

Class TestPublicChatMultipleDeviceMerged:

Class TestWalletManagementDeviceMerged:

Class TestGroupChatMultipleDeviceMerged:

Class TestPublicChatBrowserOneDeviceMerged:

Class TestOnboardingOneDeviceMerged:

Class TestEnsStickersMultipleDevicesMerged:

status-im-auto commented Aug 11, 2022

Class TestEnsStickersMultipleDevicesMerged:

Class TestPairingSyncMultipleDevicesMerged:

status-im-auto commented Aug 11, 2022

Class TestEnsStickersMultipleDevicesMerged:

qoqobolo commented Aug 11, 2022

Parveshdhull commented Aug 11, 2022

		@@ -1,26 +1,25 @@
		(ns quo2.foundations.typography)

		;; Formulat for letter spacing from figma %: 16/{figma-percentage)*100

Implement Information box and ens banner view #13753

Implement Information box and ens banner view #13753

Conversation

Parveshdhull commented Aug 2, 2022 • edited Loading

Summary

status-im-auto commented Aug 2, 2022 • edited Loading

Jenkins Builds

Parveshdhull commented Aug 8, 2022

flexsurfer left a comment

Choose a reason for hiding this comment

Parveshdhull Aug 8, 2022

Choose a reason for hiding this comment

hesterbruikman Aug 9, 2022 • edited Loading

Choose a reason for hiding this comment

Parveshdhull Aug 9, 2022

Choose a reason for hiding this comment

status-im-auto commented Aug 10, 2022

94% of end-end tests have passed

Failed tests (5)

Class TestPairingSyncMultipleDevicesMerged:

Class TestEnsStickersMultipleDevicesMerged:

Passed tests (82)

Class TestRestoreOneDeviceMerged:

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

Class TestKeycardTxOneDeviceMerged:

Class TestPairingSyncMultipleDevicesMerged:

Class TestCommandsMultipleDevicesMerged:

Class TestSendTxDeviceMerged:

Class TestOneToOneChatMultipleSharedDevices:

Class TestPublicChatMultipleDeviceMerged:

Class TestWalletManagementDeviceMerged:

Class TestGroupChatMultipleDeviceMerged:

Class TestPublicChatBrowserOneDeviceMerged:

Class TestOnboardingOneDeviceMerged:

Class TestEnsStickersMultipleDevicesMerged:

status-im-auto commented Aug 11, 2022

20% of end-end tests have passed

Failed tests (4)

Class TestEnsStickersMultipleDevicesMerged:

Passed tests (1)

Class TestPairingSyncMultipleDevicesMerged:

status-im-auto commented Aug 11, 2022

0% of end-end tests have passed

Failed tests (4)

Class TestEnsStickersMultipleDevicesMerged:

qoqobolo commented Aug 11, 2022

Parveshdhull commented Aug 11, 2022

Parveshdhull commented Aug 2, 2022 •

edited

Loading

status-im-auto commented Aug 2, 2022 •

edited

Loading

hesterbruikman Aug 9, 2022 •

edited

Loading