Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13233] Proper message after clearing history in pubchat #13241

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[#13233] Proper message after clearing history in pubchat #13241

merged 1 commit into from
Apr 1, 2022

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Mar 31, 2022

fix #13233

status: ready

@rasom rasom self-assigned this Mar 31, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Mar 31, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3dd0941 #1 2022-03-31 18:35:25 ~10 min android 📦apk 📲
✔️ 3dd0941 #1 2022-03-31 18:35:31 ~10 min android-e2e 📦apk 📲
✔️ 3dd0941 #1 2022-03-31 18:41:19 ~16 min ios 📦ipa 📲
✔️ 346574a #2 2022-04-01 14:39:36 ~12 min android 📦apk 📲
✔️ 346574a #2 2022-04-01 14:46:14 ~19 min ios 📦ipa 📲

@rasom
Copy link
Contributor Author

rasom commented Apr 1, 2022

@churik I added new translation
"cleared-chat-description-public": "It's been quiet here. Start the conversation or ",

How do we usually handle this for the rest of languages?

@pavloburykh pavloburykh self-assigned this Apr 1, 2022
@churik
Copy link
Member

churik commented Apr 1, 2022

not sure, may be @jinhojang6 knows more

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 79
Failed tests: 3
Passed tests: 76

IDs of failed tests: 6270,6228,700737

Failed tests (3)

Click to expand
  • Rerun tests

    • 1. test_public_chat_mark_all_messages_as_read, id: 6270

    Device 1: Looking for chat: '#mnrogwl'
    Device 1: Wait for element `Button` for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    2. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find `Button` by `xpath`: `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find `Button` by `xpath`: `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    3. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Device 1: Looking for chat: '#mnrogwl'
    Device 1: Wait for element `Button` for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    Passed tests (76)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    3. test_wallet_manage_assets, id: 700758
    Device sessions

    4. test_public_chat_message_edit, id: 700734
    Device sessions

    5. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    6. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    7. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    8. test_send_tx_token_7_decimals, id: 700764
    Device sessions

    9. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    10. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    11. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    12. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    13. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    14. test_browser_bookmarks_create_edit_remove (TestRail link is not found)
    Device sessions

    15. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    16. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    17. test_restore_validation_seed_phrase_field, id: 700750
    Device sessions

    18. test_send_eth_in_1_1_chat_transaction_push (TestRail link is not found)
    Device sessions

    19. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    20. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    21. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    22. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    23. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    24. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    25. test_browser_blocked_url (TestRail link is not found)
    Device sessions

    26. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    27. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    28. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    29. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    30. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    31. test_block_user_from_public_chat, id: 5786
    Device sessions

    32. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    33. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    34. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    35. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    36. test_public_chat_link_send_open, id: 700736
    Device sessions

    37. test_onboarding_share_contact_address, id: 700743
    Device sessions

    38. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    39. test_wallet_tx_history_copy_tx_hash_on_lte, id: 700756
    Device sessions

    40. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    41. test_browser_delete_close_tabs (TestRail link is not found)
    Device sessions

    42. test_browser_connection_is_secure_not_secure_warning (TestRail link is not found)
    Device sessions

    43. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    44. test_send_tx_set_recipient_options, id: 700757
    Device sessions

    45. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    46. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    47. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    48. test_browser_web3_permissions_testdapp (TestRail link is not found)
    Device sessions

    49. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    50. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    51. test_group_chat_decline_invite_chat_highligted, id: 5756
    Device sessions

    52. test_set_profile_picture, id: 6646
    Device sessions

    53. test_public_chat_tag_message, id: 700738
    Device sessions

    54. test_request_and_receive_stt_in_1_1_chat_offline (TestRail link is not found)
    Device sessions

    55. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    56. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    57. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    58. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    59. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    60. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    61. test_group_chat_offline_pn, id: 3998
    Device sessions

    62. test_group_chat_add_new_member_activity_centre, id: 700732
    Device sessions

    63. test_keycard_send_tx_eth, id: 700767
    Device sessions

    64. test_browser_offline (TestRail link is not found)
    Device sessions

    65. test_browser_invalid_url (TestRail link is not found)
    Device sessions

    66. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    67. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    68. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    69. test_copy_and_paste_messages, id: 5317
    Device sessions

    70. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    71. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    72. test_decline_transactions_in_1_1_chat_push_notification_changing_state (TestRail link is not found)
    Device sessions

    73. test_group_chat_leave_relogin, id: 3997
    Device sessions

    74. test_public_chat_message_delete, id: 700735
    Device sessions

    75. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    76. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    @rasom rasom force-pushed the fix/#13233-frightening-quietness branch from 3dd0941 to 346574a Compare April 1, 2022 14:26
    @rasom rasom merged commit 346574a into develop Apr 1, 2022
    @rasom rasom deleted the fix/#13233-frightening-quietness branch April 1, 2022 14:27
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    Assignees

    @rasom rasom

    @pavloburykh pavloburykh

    Labels
    Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    "It's been quiet here for 19079 days" after clear history in public chat
    6 participants
    @rasom @status-im-auto @churik @flexsurfer @Parveshdhull @pavloburykh