Use HTTPs for image loading with self-signed certs #13039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (140)
|
bitgamma
force-pushed
the
feature/12855
branch
from
3ad8cef to
2450280
Compare
bitgamma
changed the title
flexsurfer
approved these changes
Feb 7, 2022
| path (if (string/starts-with? path "file") path (str "file://" path))] | ||
| (.save CameraRoll path))) | ||
| #(log/error "could not resize image" %))))) | ||
| (def temp-image-url (str (fs/cache-dir) "/StatusIm_Image.jpeg")) |
There was a problem hiding this comment.
could you please elaborate, why this needed ? what's this image ?
There was a problem hiding this comment.
CameraRoll is expecting a file URL so we have to first download the image locally to cache. Before this was done by saving the base64-encoded image using image-processing/resize, but this didn't work with HTTP(s) links. I added a way to download the image as a binary and unified the code/logic used for saving to gallery and to share image and also made it the same for iOS and Android
78% of end-end tests have passedFailed tests (18)Click to expand
Passed tests (64)Click to expand
|
|
Hi @bitgamma! Thanks for your work! |
bitgamma
force-pushed
the
feature/12855
branch
from
ae4ccf0 to
e9bb19d
Compare
|
@qoqobolo rebased! thanks |
88% of end-end tests have passedFailed tests (19)Click to expand
Passed tests (139)Click to expand |
24% of end-end tests have passedFailed tests (13)Click to expand
Passed tests (4)Click to expand
|
|
Thanks @bitgamma ISSUE 1: No preview PNG/BMP images in chat viewCan send and open a PNG/BMP image but can't see a preview in a chat. Steps:
Android: video_2022-02-07_17-02-42.mp4ISSUE 2:
|
|
i'll fix ISSUE 2 |
I'll take a look |
|
ISSUE 1 probably for some reason there is no on-load event |
|
@qoqobolo thanks for testing! will let you know when it is fixed. |
|
thanks @qoqobolo fixed |
|
Thank you @flexsurfer! ISSUE 3: Endless loading when opening an image (any format) after screen lock (iOS)Noticed another unexpected behavior. This one is not critical, but might be worth a look. Steps:
IMG_5242.MP4ISSUE 4: Gray line on the left side of a horizontal picture in TimelineThe issue is in nightly as well. But if you can fix it here, it would be nice! |
|
ISSUE 3: looks like critical, seems like http server is stopped |
Oh, okay. Didn't consider it as critical since could only reproduce it on iOS, relogin helps, and also you need to catch it before logout while in background. |
9% of end-end tests have passedFailed tests (10)Click to expand
Passed tests (1)Click to expand
|
|
Indeed ISSUE 3 seems to be reproducible by locking the screen and waiting a bit, regardless of what tab/chat is open in the Status client so it is quite major. I am trying to find out what exactly happens in that case and how we can recover from that situation |
|
@flexsurfer Also, can you take a look at the second part of ISSUE 2, please?
It's more visible in horizontal images. When opened, the picture is slightly darkened, but you can move it up, and it becomes lighter. Looks like it should be light and centered when opened. IMG_5246.MP4 |
|
@qoqobolo unfortunately it's in the component jobtoday/react-native-image-viewing#23 , dunno why it's not fixed, it's so essential issue |
bitgamma
force-pushed
the
feature/12855
branch
from
8c10ccb to
4f7fded
Compare
|
@qoqobolo issue 3 is now solved. Thanks! |
|
Thanks @bitgamma! Unfortunately, now the app crashes on iOS ISSUE 5: Crash when creating/recovering an account after creating password (iOS)After the crash can reopen, log in, and use the app. Steps:
Crashlog - StatusPR 9-2-22,11-10.log IMG_5253.MP4 |
bitgamma
force-pushed
the
feature/12855
branch
2 times, most recently
from
8334bf9 to
97d9cf6
Compare
|
@qoqobolo ISSUE 5 should be fixed now. Thank you for your patience! |
|
Thank you too, @bitgamma! @flexsurfer @bitgamma need your opinion on one more thing (hopefully the last one here). Noticed, that when opening a chat or scrolling it after the first opening on Android devices, image borders are loaded first. It is not reproducible on develop, and this is an Android-specific issue. Here is a video with large images at normal speed video_2022-02-10_11-47-37.mp4and in slow motion video_2022-02-10_11-48-18.mp4Here are small images, chat without a lot of data, normal speed video_2022-02-10_11-51-00.mp4Slow motion video_2022-02-10_11-52-05.mp4Steps to reproduce:
|
0% of end-end tests have passedFailed tests (50)Click to expand
|
|
I'd say this is normal because we are downloading (from status-go) the images on demand as the view scrolls instead of downloading them all at once as we were doing before. This should actually make opening the chat a bit faster at the price of this "effect" when scrolling. |
91% of end-end tests have passedFailed tests (14)Click to expand
Passed tests (141)Click to expand
|
|
@bitgamma @flexsurfer thank you both for the great work, waiting, and patient solving issues! |
|
|
bitgamma
force-pushed
the
feature/12855
branch
from
97d9cf6 to
7ac91e8
Compare
Co-Authored-By: andrey <motor4ik@gmail.com> Signed-off-by: Michele Balistreri <michele@bitgamma.com>
bitgamma
force-pushed
the
feature/12855
branch
from
7ac91e8 to
52afbf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12855.
fixes: #13081