Add group members to mentionable list #12994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (9)
|
85% of end-end tests have passedFailed tests (25)Click to expand
Passed tests (138)Click to expand |
flexsurfer
reviewed
Jan 12, 2022
| all-contacts (:contacts/contacts db) | ||
| current-multiaccount (:multiaccount db) | ||
| community-members (get-in db [:communities (:community-id chat) :members])] | ||
| (mentionable-users chat all-contacts current-multiaccount community-members))) |
There was a problem hiding this comment.
why is an extra method needed?
There was a problem hiding this comment.
i mean why don't just have implementation here
There was a problem hiding this comment.
@flexsurfer, done 👍, Thanks
Parveshdhull
force-pushed
the
feature/add-group-members-to-mentionable-list
branch
2 times, most recently
from
c50ff89
to
ad40151
Compare
|
@Parveshdhull thanks for your work! ISSUE 1: ENS names are resolved in the mention suggestions list and in the chat input field only and are not resolved in other views (i.e. home screen, chat history, 1-1 chat, contacts, etc.)Reproduction:
The issue is not reproducible on Nightly. IMG_1032.MP4UPD (for the record): Currently, the issue is reproducible with these steps (thanks @Parveshdhull for discovering!):
|
flexsurfer
approved these changes
Jan 13, 2022
99% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (70)Click to expand |
|
Tested cases:
@Parveshdhull thanks again for your hard work and for the investigation of the ENS issue! |
Parveshdhull
force-pushed
the
feature/add-group-members-to-mentionable-list
branch
from
ad40151
to
bbbac43
Compare
Parveshdhull
deleted the
feature/add-group-members-to-mentionable-list
branch
qfrank
pushed a commit
to qfrank/status-react
that referenced
this pull request
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12993
Summary
PR implements a feature, which allows users to mention newly joined group members. Group members will be shown in the group chat mention suggestion list, even if they are not their contact.
Code Review:
There was duplicate code in file
subs.cljsandmentions.cljs. I tried to reformat and refactor. Please let me know If I missed something.QA Test Request:
As the code of mentioning is reformated, it might have affected other chat types like community or group. So, Please let me know if any of them are not working as expected.
Thanks
status: ready