Skip to content

fix distortion of app theme due to change in system theme #12934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2021
Merged

fix distortion of app theme due to change in system theme #12934

merged 2 commits into from
Dec 27, 2021

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Dec 19, 2021 •
edited
Loading

fixes #12921

status: ready

@Parveshdhull Parveshdhull self-assigned this Dec 19, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Dec 19, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 285cbcb #1 2021-12-19 22:42:21 ~3 min ios 📄log
✔️ 285cbcb #1 2021-12-19 22:51:29 ~12 min android-e2e 📦apk 📲
✔️ 285cbcb #1 2021-12-19 22:59:14 ~20 min android 📦apk 📲
❌ df68d0b #2 2021-12-19 23:30:29 ~2 min ios 📄log
✔️ df68d0b #2 2021-12-19 23:40:32 ~12 min android 📦apk 📲
✔️ df68d0b #2 2021-12-19 23:50:04 ~22 min android-e2e 📦apk 📲
❌ aa1cd49 #3 2021-12-21 22:24:28 ~2 min ios 📄log
✔️ aa1cd49 #3 2021-12-21 22:47:41 ~25 min android-e2e 📦apk 📲
✔️ aa1cd49 #3 2021-12-21 22:47:50 ~26 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8b90a7a #4 2021-12-25 19:30:41 ~5 min ios 📄log
✔️ 8b90a7a #4 2021-12-25 19:45:48 ~20 min android-e2e 📦apk 📲
✔️ 8b90a7a #4 2021-12-25 19:45:57 ~20 min android 📦apk 📲
❌ 14e9074 #5 2021-12-25 19:32:21 ~2 min ios 📄log
✔️ 14e9074 #5 2021-12-25 19:42:10 ~12 min android 📦apk 📲
✔️ 14e9074 #5 2021-12-25 19:42:35 ~12 min android-e2e 📦apk 📲

@Parveshdhull Parveshdhull force-pushed the fix/system-theme-change branch from 285cbcb to df68d0b Compare December 19, 2021 23:27
@Parveshdhull Parveshdhull marked this pull request as ready for review December 19, 2021 23:52
@status-im-auto
Copy link
Member

83% of end-end tests have passed

Total executed tests: 69
Failed tests: 12
Passed tests: 57

IDs of failed tests: 6305,5315,5387,5675,695843,5310,5762,5317,6228,5403,5341,5313

Failed tests (12)

Click to expand
  • Rerun tests

    • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find 'Button' by 'xpath': `//*[@text="Hey hey hey"]`
    Device 2: Find 'Button' by 'xpath': `//*[@text="Hey hey hey"]`

    Device 2: Button by xpath: `//*[@text="Hey hey hey"]` is not found on the screen

    Device sessions

    2. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

    Device 1: Find 'TimeStampText' by 'xpath': `(//*[starts-with(@text,'® æ ç ♥')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView)[last()]`
    Device 1: 'TimeStampText' is '® æ ç ♥ '

    'list' object has no attribute 'join'

    Device sessions

    3. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:ijvwsqkafj

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    4. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675

    Device 1: 'Text' is '#spectentur'
    # STEP: Check that can fetch previous history

    Device 1: "Dec 19, 2021" is not shown

    Device sessions

    5. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843

    Device 1: Looking for a message by text: Message AFTER edit 2
    Device 2: Looking for a message by text: Message AFTER edit 2

    No mark in message bubble about this message was edited Message is not edited.

    Device sessions

    6. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Smooth Noxious Sambar'
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    7. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find 'ChatElementByText' by 'xpath': `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    8. test_copy_and_paste_messages, id: 5317

    Device 1: Long press on 'TimeStampText'
    Device 1: Find 'Button' by 'xpath': `//*[@text="Copy"]`

    Device 1: Button by xpath: `//*[@text="Copy"]` is not found on the screen

    Device sessions

    9. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Not connected to history node after enabling fetching on mobile data Chat history was not fetched with mobile data fetching ON

    Device sessions

    10. test_start_chat_with_ens_mention_in_one_to_one, id: 5403

    Device 1: Setting nickname:МОЙ дорогой ДРУх
    Device 1: Find 'Button' by 'accessibility id': `profile-nickname-item`

    Device 1: Button by accessibility id: `profile-nickname-item` is not found on the screen

    Device sessions

    11. test_manage_assets, id: 5341

    Device 1: Tap on found: Button
    Device 1: Selecting MDS asset

    MDS asset is shown in wallet but was deselected

    Device sessions

    12. test_public_chat_messaging_emojis_timestamps, id: 5313

    Device 1: Find 'TimeStampText' by 'xpath': `(//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView)[last()]`
    Device 1: 'TimeStampText' is 'hello '

    'list' object has no attribute 'join'

    Device sessions

    Passed tests (57)

    Click to expand

    1. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    2. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    3. test_request_stt_from_dapp, id: 5309
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    12. test_delete_close_all_tabs, id: 5390
    Device sessions

    13. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    14. test_send_token_with_7_decimals, id: 5350
    Device sessions

    15. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    16. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    17. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    18. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    19. test_block_user_from_public_chat, id: 5786
    Device sessions

    20. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    21. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    22. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    23. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    24. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    25. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    26. test_long_press_to_delete_chat, id: 5319
    Device sessions

    27. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    28. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    29. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    30. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    31. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    32. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    33. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    34. test_browser_managing_bookmarks, id: 6633
    Device sessions

    35. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    36. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    37. test_dapps_permissions, id: 5738
    Device sessions

    38. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    39. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    40. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    41. test_wallet_set_up, id: 5335
    Device sessions

    42. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    43. test_home_view, id: 5379
    Device sessions

    44. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    45. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    46. test_set_profile_picture, id: 6646
    Device sessions

    47. test_collectible_from_wallet, id: 5346
    Device sessions

    48. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    49. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    50. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    51. test_pass_phrase_validation, id: 5363
    Device sessions

    52. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    53. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    54. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    55. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    56. test_fetching_balance_after_offline, id: 6237
    Device sessions

    57. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 12
Failed tests: 12
Passed tests: 0

    IDs of failed tests: 5341,5313,695843,6228,5403,5315,5310,5675,6305,5762,5387,5317

    Failed tests (12)

    Click to expand
  • Rerun tests

    • 1. test_manage_assets, id: 5341

    Device 1: Tap on found: Button
    Device 1: Selecting MDS asset

    MDS asset is shown in wallet but was deselected

    Device sessions

    2. test_public_chat_messaging_emojis_timestamps, id: 5313

    Device 1: Find 'TimeStampText' by 'xpath': `(//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView)[last()]`
    Device 1: 'TimeStampText' is 'hello '

    'list' object has no attribute 'join'

    Device sessions

    3. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843

    Device 1: Looking for a message by text: Message AFTER edit 2
    Device 2: Looking for a message by text: Message AFTER edit 2

    No mark in message bubble about this message was edited Message is not edited.

    Device sessions

    4. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Not connected to history node after enabling fetching on mobile data Chat history was not fetched with mobile data fetching ON

    Device sessions

    5. test_start_chat_with_ens_mention_in_one_to_one, id: 5403

    Device 1: Setting nickname:МОЙ дорогой ДРУх
    Device 1: Find 'Button' by 'accessibility id': `profile-nickname-item`

    Device 1: Button by accessibility id: `profile-nickname-item` is not found on the screen

    Device sessions

    6. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

    Device 1: Find 'TimeStampText' by 'xpath': `(//*[starts-with(@text,'® æ ç ♥')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView)[last()]`
    Device 1: 'TimeStampText' is '® æ ç ♥ '

    'list' object has no attribute 'join'

    Device sessions

    7. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Opulent Buzzing Flickertailsquirrel'
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    8. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675

    Device 1: 'Text' is '#spectentur'
    # STEP: Check that can fetch previous history

    Device 1: "Dec 19, 2021" is not shown

    Device sessions

    9. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find 'Button' by 'xpath': `//*[@text="Hey hey hey"]`
    Device 2: Find 'Button' by 'xpath': `//*[@text="Hey hey hey"]`

    Device 2: Button by xpath: `//*[@text="Hey hey hey"]` is not found on the screen

    Device sessions

    10. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find 'ChatElementByText' by 'xpath': `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    11. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:nxwqdtdywn

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    12. test_copy_and_paste_messages, id: 5317

    Device 1: Long press on 'TimeStampText'
    Device 1: Find 'Button' by 'xpath': `//*[@text="Copy"]`

    Device 1: Button by xpath: `//*[@text="Copy"]` is not found on the screen

    Device sessions

    @status-im-auto
    Copy link
    Member

    78% of end-end tests have passed

    Total executed tests: 69
Failed tests: 15
Passed tests: 54

    IDs of failed tests: 6305,5315,5387,5675,6645,695843,5310,5762,5317,5360,6228,5403,5341,6646,5313

    Failed tests (15)

    Click to expand
  • Rerun tests

    • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find 'Button' by 'xpath': `//*[@text="Hey hey hey"]`
    Device 2: Find 'Button' by 'xpath': `//*[@text="Hey hey hey"]`

    Device 2: Button by xpath: `//*[@text="Hey hey hey"]` is not found on the screen

    Device sessions

    2. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

    Device 1: Find 'TimeStampText' by 'xpath': `(//*[starts-with(@text,'® æ ç ♥')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView)[last()]`
    Device 1: 'TimeStampText' is '® æ ç ♥ '

    'list' object has no attribute 'join'

    Device sessions

    3. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:sdmdbmjkly

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    4. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675

    Device 1: 'Text' is '#spectentur'
    # STEP: Check that can fetch previous history

    Device 1: "Dec 19, 2021" is not shown

    Device sessions

    5. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: Tap on found: Button
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    6. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843

    Device 1: Looking for a message by text: Message AFTER edit 2
    Device 2: Looking for a message by text: Message AFTER edit 2

    No mark in message bubble about this message was edited Message is not edited.

    Device sessions

    7. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Relieved Frugal Whitetaileddeer'
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    8. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find 'ChatElementByText' by 'xpath': `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    9. test_copy_and_paste_messages, id: 5317

    Device 1: Long press on 'TimeStampText'
    Device 1: Find 'Button' by 'xpath': `//*[@text="Copy"]`

    Device 1: Button by xpath: `//*[@text="Copy"]` is not found on the screen

    Device sessions

    10. test_unread_messages_counter_public_chat, id: 5360

    ## Signed in successfully!
    Device 2: Looking for chat: '#mlxtkce'

    New messages public chat badge is shown on Home button Unread messages badge is shown in public chat while there are no unread messages

    Device sessions

    11. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Not connected to history node after enabling fetching on mobile data Chat history was not fetched with mobile data fetching ON

    Device sessions

    12. test_start_chat_with_ens_mention_in_one_to_one, id: 5403

    Device 1: Setting nickname:МОЙ дорогой ДРУх
    Device 1: Find 'Button' by 'accessibility id': `profile-nickname-item`

    Device 1: Button by accessibility id: `profile-nickname-item` is not found on the screen

    Device sessions

    13. test_manage_assets, id: 5341

    Device 1: Tap on found: Button
    Device 1: Selecting MDS asset

    MDS asset is shown in wallet but was deselected

    Device sessions

    14. test_set_profile_picture, id: 6646

    Device 2: Looking for a message by text: Text message
    Device 2: Find 'MemberPhoto' by 'xpath': `//*[starts-with(@text,'Text message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='member-photo']`

    Device 1: Profile picture was not updated in chat

    Device sessions

    15. test_public_chat_messaging_emojis_timestamps, id: 5313

    Device 1: Find 'TimeStampText' by 'xpath': `(//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView)[last()]`
    Device 1: 'TimeStampText' is 'hello '

    'list' object has no attribute 'join'

    Device sessions

    Passed tests (54)

    Click to expand

    1. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    2. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    3. test_request_stt_from_dapp, id: 5309
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    12. test_delete_close_all_tabs, id: 5390
    Device sessions

    13. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    14. test_send_token_with_7_decimals, id: 5350
    Device sessions

    15. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    16. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    17. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    18. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    19. test_block_user_from_public_chat, id: 5786
    Device sessions

    20. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    21. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    22. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    23. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    24. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    25. test_long_press_to_delete_chat, id: 5319
    Device sessions

    26. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    27. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    28. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    29. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    30. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    31. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    32. test_browser_managing_bookmarks, id: 6633
    Device sessions

    33. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    34. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    35. test_dapps_permissions, id: 5738
    Device sessions

    36. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    37. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    38. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    39. test_wallet_set_up, id: 5335
    Device sessions

    40. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    41. test_home_view, id: 5379
    Device sessions

    42. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    43. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    44. test_collectible_from_wallet, id: 5346
    Device sessions

    45. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    46. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    47. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    48. test_pass_phrase_validation, id: 5363
    Device sessions

    49. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    50. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    51. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    52. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    53. test_fetching_balance_after_offline, id: 6237
    Device sessions

    54. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    @Parveshdhull Parveshdhull force-pushed the fix/system-theme-change branch from df68d0b to aa1cd49 Compare December 21, 2021 22:21
    @status-im-auto
    Copy link
    Member

    81% of end-end tests have passed

    Total executed tests: 69
Failed tests: 13
Passed tests: 56

    IDs of failed tests: 3998,5315,5387,5675,5689,5310,5762,5317,6228,5403,5341,6646,5313

    Failed tests (13)

    Click to expand
  • Rerun tests

    • 1. test_offline_add_new_group_chat_member, id: 3998

    Device 3: Looking for chat: 'vwwifcm'
    Device 3: Wait for element 'Button' for max 30s and click when it is available

    Device 3: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    2. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

    Device 1: Find 'TimeStampText' by 'xpath': `(//*[starts-with(@text,'® æ ç ♥')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView)[last()]`
    Device 1: 'TimeStampText' is '® æ ç ♥ '

    'list' object has no attribute 'join'

    Device sessions

    3. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:efvtyeqjmo

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    4. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675

    Device 1: 'Text' is '#spectentur'
    # STEP: Check that can fetch previous history

    Device 1: "Dec 20, 2021" is not shown

    Device sessions

    5. test_keycard_create_login_restore_unlock_same_seed, id: 5689

    Device 1: Find 'Button' by 'accessibility id': `new-chat-button`
    Device 1: Tap on found: Button

    Account USD value is not 0, it is ...

    Device sessions

    6. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Boiling Darkslategray Seagull'
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    7. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find 'ChatElementByText' by 'xpath': `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    8. test_copy_and_paste_messages, id: 5317

    Device 1: Long press on 'TimeStampText'
    Device 1: Find 'Button' by 'xpath': `//*[@text="Copy"]`

    Device 1: Button by xpath: `//*[@text="Copy"]` is not found on the screen

    Device sessions

    9. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Not connected to history node after enabling fetching on mobile data Chat history was not fetched with mobile data fetching ON

    Device sessions

    10. test_start_chat_with_ens_mention_in_one_to_one, id: 5403

    Device 1: Setting nickname:МОЙ дорогой ДРУх
    Device 1: Find 'Button' by 'accessibility id': `profile-nickname-item`

    Device 1: Button by accessibility id: `profile-nickname-item` is not found on the screen

    Device sessions

    11. test_manage_assets, id: 5341

    Device 1: Tap on found: Button
    Device 1: Selecting MDS asset

    MDS asset is shown in wallet but was deselected

    Device sessions

    12. test_set_profile_picture, id: 6646

    Device 2: Looking for a message by text: Text message
    Device 2: Find 'MemberPhoto' by 'xpath': `//*[starts-with(@text,'Text message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='member-photo']`

    Device 1: Profile picture was not updated in chat after making photo

    Device sessions

    13. test_public_chat_messaging_emojis_timestamps, id: 5313

    Device 1: Find 'TimeStampText' by 'xpath': `(//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView)[last()]`
    Device 1: 'TimeStampText' is 'hello '

    'list' object has no attribute 'join'

    Device sessions

    Passed tests (56)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_request_stt_from_dapp, id: 5309
    Device sessions

    5. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    6. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    7. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    8. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    9. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    12. test_delete_close_all_tabs, id: 5390
    Device sessions

    13. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    14. test_send_token_with_7_decimals, id: 5350
    Device sessions

    15. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    16. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    17. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    18. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    19. test_block_user_from_public_chat, id: 5786
    Device sessions

    20. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    21. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    22. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    23. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    24. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    25. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    26. test_long_press_to_delete_chat, id: 5319
    Device sessions

    27. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    28. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    29. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    30. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    31. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    32. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    33. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    34. test_browser_managing_bookmarks, id: 6633
    Device sessions

    35. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    36. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    37. test_dapps_permissions, id: 5738
    Device sessions

    38. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    39. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    40. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    41. test_wallet_set_up, id: 5335
    Device sessions

    42. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    43. test_home_view, id: 5379
    Device sessions

    44. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    45. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    46. test_collectible_from_wallet, id: 5346
    Device sessions

    47. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    48. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    49. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    50. test_pass_phrase_validation, id: 5363
    Device sessions

    51. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    52. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    53. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    54. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    55. test_fetching_balance_after_offline, id: 6237
    Device sessions

    56. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    @du82
    Copy link
    Contributor

    du82 commented Dec 22, 2021

    What I call "Zebra mode" has plagued the app for a while, glad to see a fix!

    @churik
    Copy link
    Member

    churik commented Dec 24, 2021

    It works way better than before, thank you for the fix!
    Found one issue: new theme doesn't apply to system dialogs in the app and user profile picture
    Steps:

    • Open Status
    • Change mode in device settings
    • Go back to app and tap on Logout

    photo_2021-12-24 14 16 19 jpeg 2021-12-24 14-16-48

    @status-im-auto
    Copy link
    Member

    58% of end-end tests have passed

    Total executed tests: 12
Failed tests: 5
Passed tests: 7

    IDs of failed tests: 6228,5310,5675,5762,5387

    Failed tests (5)

    Click to expand
  • Rerun tests

    • 1. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Not connected to history node after enabling fetching on mobile data Chat history was not fetched with mobile data fetching ON

    Device sessions

    2. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Vibrant Heavy Whitebeakeddolphin'
    Device 1: Wait for element 'Button' for max 60s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    3. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675

    Device 1: 'Text' is '#spectentur'
    # STEP: Check that can fetch previous history

    Device 1: "Dec 23, 2021" is not shown

    Device sessions

    4. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find 'ChatElementByText' by 'xpath': `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    5. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:azqtgltbqw

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    Passed tests (7)

    Click to expand

    1. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    2. test_manage_assets, id: 5341
    Device sessions

    3. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    4. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    5. test_set_profile_picture, id: 6646
    Device sessions

    6. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    7. test_copy_and_paste_messages, id: 5317
    Device sessions

    @Parveshdhull Parveshdhull force-pushed the fix/system-theme-change branch from 8b90a7a to 14e9074 Compare December 25, 2021 19:29
    @status-im status-im deleted a comment from status-im-auto Dec 27, 2021
    @churik
    Copy link
    Member

    churik commented Dec 27, 2021

    👍 awesome work!
    e2e failures are not related to PR.

    Devices:

    • Xiaomi Mi Note 9 Pro (Android 10)

    @Parveshdhull Parveshdhull merged commit ffba396 into develop Dec 27, 2021
    @Parveshdhull Parveshdhull deleted the fix/system-theme-change branch December 27, 2021 09:54
    @churik churik mentioned this pull request Jan 14, 2022
    Closed
    flexsurfer added a commit that referenced this pull request Jan 14, 2022
    @flexsurfer
    Revert "fix distortion of app theme due to change in system theme (#1…
    56df6b3 
    …2934)"

This reverts commit ffba396.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rasom rasom rasom approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    Assignees

    @Parveshdhull Parveshdhull

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    On changing light system mode to dark app needs relaunch to apply new mode
    5 participants
    @Parveshdhull @status-im-auto @du82 @churik @rasom