-
Notifications
You must be signed in to change notification settings - Fork 1k
[#12818] Support tx history (in a way) when on BSC chains #12843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
flexsurfer
approved these changes
Nov 25, 2021
8657db5
to
a41f164
Compare
97% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (67)Click to expand |
97% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (67)Click to expand |
5381 will fix in #12836 |
932d8bd
to
27b29b2
Compare
27b29b2
to
c7e66fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12818
There is no way to fetch archival data on BSC mainnet with RPC access we have now, thus only txs which are sent from our app will be shown. The links to block explorer are added for viewing more data.
Although we can fetch history on BSC testnet I made it work the same way as BCS mainnet just for the sake of testing.
status: ready