Show loading until all messages are processed #12834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (27)
|
cammellos
force-pushed
the
feature/mark-p2p-messages-as-confirmed
branch
3 times, most recently
from
e327ed4 to
c1102f6
Compare
cammellos
changed the title
Parveshdhull
approved these changes
Nov 26, 2021
cammellos
force-pushed
the
feature/mark-p2p-messages-as-confirmed
branch
from
4d7d17e to
f2f0baa
Compare
94% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (65)Click to expand |
75% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (3)Click to expand
|
cammellos
force-pushed
the
feature/mark-p2p-messages-as-confirmed
branch
from
f5fabaf to
f2f0baa
Compare
|
@cammellos thank you for the instructions for testing, appreciate it!
Is everything expected here? |
cammellos
force-pushed
the
feature/mark-p2p-messages-as-confirmed
branch
from
f2f0baa to
90f6538
Compare
97% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (67)Click to expand |
50% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (1) |
|
@cammellos
ISSUE 1: On build 9 (90f6538) endless "loading..." is shown when all history was fetched (instead of "Fetch more") Steps:
|
cammellos
force-pushed
the
feature/mark-p2p-messages-as-confirmed
branch
from
90f6538 to
ce1bbe9
Compare
|
@churik it should be fixed now, sorry I have messed up the rebase |
0% of end-end tests have passedFailed tests (1)Click to expand
|
|
e2e failures are not related to PR. Devices:
|
cammellos
force-pushed
the
feature/mark-p2p-messages-as-confirmed
branch
from
ce1bbe9 to
1b16086
Compare
Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
cammellos
force-pushed
the
feature/mark-p2p-messages-as-confirmed
branch
from
1b16086 to
153204e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build fixes an issue with receiving messages.
Before we would stop showing loading and mark a request as completed as soon as the messages made it to our device, but not necessarily processed.
This caused 2 issues:
Testing
It's hard to replicate in real scenario, so I prepared a couple of builds that intentionally slow down the processing of messages.
One is faulty (old behavior), while the other one includes the fix.
Test faulty behavior:
#4(https://status-im-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-211126-101731-c1102f-pr12834-universal.apk).Expected:
messages are retrieved
Actual:
messages are not retrieved
Also notice that on 3, the "loading..." spinner is gone in the chat, while messages are not there.
To test the fixed behavior, follow the same steps, but use build 5.
The chat should still show "loading..." in step 3, and on reopening the app.
Messages should be eventually retrieved in step 6.