Handle confirmations from mailservers #12824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
cammellos
force-pushed
the
feature/wait-for-ack-confirmations
branch
from
6fcd9f5 to
14bf3c5
Compare
flexsurfer
approved these changes
Nov 17, 2021
|
@cammellos can we do e2e build with default |
|
@churik yes, I think so, I'll push a commit |
cammellos
force-pushed
the
feature/wait-for-ack-confirmations
branch
from
14bf3c5 to
b5e3bac
Compare
cammellos
force-pushed
the
feature/wait-for-ack-confirmations
branch
2 times, most recently
from
6a2675a to
388aed6
Compare
|
Tested confirmations (flows New > Sent > Delivered, New (not sent), New > Sent, Sent > Delivered) on group chats + 1-1 chats (with offline resending) and on public chat (no resending) after offline 1min, 5mins, 30mins, 48h +. I noticed that 'stuck' messages in public chats couldn't be resent but I suppose it is not the part of this PR, right @cammellos ? e2e test results: here and here Devices:
|
cammellos
force-pushed
the
feature/wait-for-ack-confirmations
branch
from
388aed6 to
61910d2
Compare
Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
cammellos
force-pushed
the
feature/wait-for-ack-confirmations
branch
from
61910d2 to
fdadee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes confirmations a bit more robust.
It should fix an issue with being offline and having your messages confirmed.
On develop currently the behavior is:
Expected:
Message not confirmed
Actual:
Message is confirmed
After this change it will not mark the message as confirmed.
Testing
This PR will work just as in develop against prod & staging fleet (so it will result in the
Actualbehavior from above).The
Expectedbehavior needs to be tested against the test fleet.It should though not have any issue (other than the above) when testing with prod/staging.
Develop though won't work with the test fleet, messages won't get confirmed, that's know, as it's a breaking change.
status: ready