Skip to content

🚀 contacts performance 🚀 #12643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Oct 4, 2021
Merged

🚀 contacts performance 🚀 #12643

merged 0 commits into from
Oct 4, 2021

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Sep 23, 2021 •
edited
Loading

🚀 contacts performance 🚀

replaced systemTags on added and blocked fields, all other changes in status-go

QA: pls ping me when testing

@flexsurfer flexsurfer self-assigned this Sep 23, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Sep 23, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (11)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1d98a05 #1 2021-09-23 12:11:10 ~20 min android 📦apk 📲
✔️ 1d98a05 #1 2021-09-23 12:12:54 ~22 min android-e2e 📦apk 📲
✔️ 2d7a4b1 #2 2021-09-27 10:28:09 ~16 min android 📦apk 📲
✔️ 2d7a4b1 #2 2021-09-27 10:30:51 ~19 min android-e2e 📦apk 📲
✔️ 2d7a4b1 #2 2021-09-27 10:30:52 ~19 min ios 📦ipa 📲
✔️ 47de8f2 #3 2021-09-30 10:16:25 ~15 min android 📦apk 📲
✔️ 47de8f2 #3 2021-09-30 10:17:00 ~15 min ios 📦ipa 📲
✔️ 47de8f2 #3 2021-09-30 10:17:12 ~16 min android-e2e 📦apk 📲
✔️ e58191f #4 2021-10-01 10:45:17 ~14 min android-e2e 📦apk 📲
✔️ e58191f #4 2021-10-01 10:46:43 ~16 min ios 📦ipa 📲
✔️ e58191f #4 2021-10-01 10:48:49 ~18 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 19c455a #5 2021-10-01 15:44:33 ~15 min android 📦apk 📲
✔️ 19c455a #5 2021-10-01 15:46:06 ~16 min android-e2e 📦apk 📲
✔️ 19c455a #5 2021-10-01 15:47:07 ~17 min ios 📦ipa 📲
✔️ dcc62ec #6 2021-10-04 11:01:48 ~14 min android-e2e 📦apk 📲
✔️ dcc62ec #6 2021-10-04 11:04:17 ~16 min ios 📦ipa 📲
✔️ dcc62ec #6 2021-10-04 11:04:29 ~17 min android 📦apk 📲

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 68
Failed tests: 7
Passed tests: 61

IDs of failed tests: 6305,3994,6226,5360,5346,5332,6237

Failed tests (7)

Click to expand
  • Rerun tests

    • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: *Find Button by xpath:* `//*[@text="Hey hey hey"]`
    Device 2: *Find Button by xpath:* `//*[@text="Hey hey hey"]`

    Device 2: Button by xpath:* `//*[@text="Hey hey hey"]` is not found on the screen

    Device sessions

    2. test_create_new_group_chat_messaging_pn_delivered, id: 3994

    Device 2: =========================================================================
    Device 2: *Find Button by xpath:* `//*[contains(@text, "Message from device: 1")]`

    Device 2: Button by xpath: `//*[contains(@text, "Message from device: 1")]` is not found on the screen

    Device sessions

    3. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226

    Device 1: =========================================================================
    Device 1: *Find Button by xpath:* `//*[contains(@text, "Spiffy Coordinated Calf")]`

    Device 1: Button by xpath: `//*[contains(@text, "Spiffy Coordinated Calf")]` is not found on the screen

    Device sessions

    4. test_unread_messages_counter_public_chat, id: 5360

    Device 2: *Find EditBox by accessibility id:* `chat-message-input`
    Device 2: *Tap on found EditBox*

    Device 2: Button by xpath:`//*[@content-desc='suggestions-list']//*[@text='Lasting Dirty Bluewhale']` is not found on the screen

    Device sessions

    5. test_collectible_from_wallet, id: 5346

    Device 1: *Find Button by xpath:* `//*[@text="Enable"]`
    Device 1: *Tap on found Button*

    Device 1: Text by xpath:`//*[@text='CryptoKitties']//following-sibling::android.widget.TextView` is not found on the screen

    Device sessions

    6. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332

    Device 1: *Find EditBox by accessibility id:* `chat-message-input`
    Device 1: *Tap on found EditBox*

    Device 1: Button by xpath:`//*[@content-desc='suggestions-list']//*[@text='Darkslateblue Colossal Manxcat']` is not found on the screen

    Device sessions

    7. test_fetching_balance_after_offline, id: 6237

    Device 1: =========================================================================
    Device 1: **Toggling airplane mode**

    Cannot perform TouchMove action at (200, 300)

    Device sessions

    Passed tests (61)

    Click to expand

    1. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    2. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    12. test_delete_close_all_tabs, id: 5390
    Device sessions

    13. test_send_token_with_7_decimals, id: 5350
    Device sessions

    14. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    15. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    16. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    17. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    18. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    19. test_block_user_from_public_chat, id: 5786
    Device sessions

    20. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    21. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    22. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    23. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    24. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    25. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    26. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    27. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    28. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    29. test_long_press_to_delete_chat, id: 5319
    Device sessions

    30. test_copy_and_paste_messages, id: 5317
    Device sessions

    31. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    32. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    33. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    34. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    35. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    36. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    37. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    38. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    39. test_manage_assets, id: 5341
    Device sessions

    40. test_browser_managing_bookmarks, id: 6633
    Device sessions

    41. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    42. test_request_stt_from_daap, id: 5309
    Device sessions

    43. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    44. test_dapps_permissions, id: 5738
    Device sessions

    45. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    46. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    47. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    48. test_wallet_set_up, id: 5335
    Device sessions

    49. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    50. test_home_view, id: 5379
    Device sessions

    51. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    52. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    53. test_set_profile_picture, id: 6646
    Device sessions

    54. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    55. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    56. test_pass_phrase_validation, id: 5363
    Device sessions

    57. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    58. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    59. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    60. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    61. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @churik
    Copy link
    Member

    churik commented Sep 27, 2021

    @flexsurfer
    can you please rebase it?
    let me know when it is ready for testing.
    Thank you!

    @flexsurfer flexsurfer force-pushed the feature/contacts-performance branch from 1d98a05 to 2d7a4b1 Compare September 27, 2021 10:11
    @flexsurfer
    Copy link
    Member Author

    @churik done

    @churik churik self-assigned this Sep 27, 2021
    @status-im-auto
    Copy link
    Member

    91% of end-end tests have passed

    Total executed tests: 67
Failed tests: 6
Passed tests: 61

    IDs of failed tests: 6645,5762,5360,6279,6263,5332

    Failed tests (6)

    Click to expand
  • Rerun tests

    • 1. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: *Tap on found Button*
    Device 1: *Find Button by accessibility id:* `back-button`

    Device 1: Button by accessibility id: `back-button` is not found on the screen

    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 2: *Find Button by accessibility id:* `contacts-button`
    Device 2: *Tap on found Button*

    Device 2: Button by accessibility id:* `blocked-users-list-button` is still visible on the screen after 60 seconds

    Device sessions

    3. test_unread_messages_counter_public_chat, id: 5360

    Device 2: *Find EditBox by accessibility id:* `chat-message-input`
    Device 2: *Tap on found EditBox*

    Device 2: Button by xpath:`//*[@content-desc='suggestions-list']//*[@text='Novel Wasteful Llama']` is not found on the screen

    Device sessions

    4. test_send_eth_to_ens_in_chat, id: 6279

    Device 2: *Type 'hello' to EditBox*
    Device 2: *Find SendMessageButton by accessibility id:* `send-message-button`

    Device 2: SendMessageButton by accessibility id: `send-message-button` is not found on the screen

    Device sessions

    5. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: *Click until EditBox by accessibility id:*`chat-message-input` *will be presented*
    Device 2: *Wait for text element TransactionStatus to be equal to Confirmed*

    Device 2: 'Pending' is not equal to expected 'Confirmed' in 120 sec

    Device sessions

    6. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332

    Device 1: *Find EditBox by accessibility id:* `chat-message-input`
    Device 1: *Tap on found EditBox*

    Device 1: Button by xpath:`//*[@content-desc='suggestions-list']//*[@text='Defenseless Musty Massasauga']` is not found on the screen

    Device sessions

    Passed tests (61)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    25. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    26. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    27. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    30. test_long_press_to_delete_chat, id: 5319
    Device sessions

    31. test_copy_and_paste_messages, id: 5317
    Device sessions

    32. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    33. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    34. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    35. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    36. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    37. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    38. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    39. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    40. test_manage_assets, id: 5341
    Device sessions

    41. test_browser_managing_bookmarks, id: 6633
    Device sessions

    42. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    43. test_request_stt_from_daap, id: 5309
    Device sessions

    44. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    45. test_dapps_permissions, id: 5738
    Device sessions

    46. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    47. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    48. test_wallet_set_up, id: 5335
    Device sessions

    49. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    50. test_home_view, id: 5379
    Device sessions

    51. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    52. test_set_profile_picture, id: 6646
    Device sessions

    53. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    54. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    55. test_pass_phrase_validation, id: 5363
    Device sessions

    56. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    57. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    58. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    59. test_fetching_balance_after_offline, id: 6237
    Device sessions

    60. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    61. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @churik
    Copy link
    Member

    churik commented Sep 27, 2021

    @flexsurfer thank you for PR!

    ISSUE 1: unblocking and removing the user from contacts is not synced between paired devices

    Steps:

    1. restore multiaccount from seed phrase on Device A and B
    2. pair devices
    3. device A: add user A, block user B
    4. device B: wait until it will be synced
    5. device A: remove user A from contacts, unblock User B

    Expected result:
    unblocking and removing will be synced

    Actual result:
    not synced

    OS: IOS, Android

    ISSUE 2: Users, who are not added to contacts, don't appear in mention suggestion list

    Monosnap 2021-09-27 14-58-39

    @flexsurfer
    Copy link
    Member Author

    flexsurfer commented Sep 29, 2021 •
    edited
    Loading

    ISSUE 2: Users, who are not added to contacts, don't appear in the mention suggestion list

    unfortunately its a price for now, but anyway we want to remove public chats soon, for communities and group chats there should be another solution implemented separately

    @churik
    Copy link
    Member

    churik commented Sep 29, 2021 •
    edited
    Loading

    @cammellos @hesterbruikman
    so currently it means that mention for non-contacts will not work (public/group chats/communities), not sure what should we do here.

    @cammellos
    Copy link
    Contributor

    My 2p is that it would be frustrating for user if they ever have to mention someone, so I'd be inclined in fixing it, communities I'd be ok as still in alpha, but public/group chats he would be noticeable

    @flexsurfer
    Copy link
    Member Author

    i'll fix that then, thanks

    @flexsurfer flexsurfer force-pushed the feature/contacts-performance branch from 2d7a4b1 to 47de8f2 Compare September 30, 2021 10:00
    @flexsurfer
    Copy link
    Member Author

    thanks @churik all fixed

    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 67
Failed tests: 0
Passed tests: 67

    Passed tests (67)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    26. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    27. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    28. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    29. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    31. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    32. test_long_press_to_delete_chat, id: 5319
    Device sessions

    33. test_copy_and_paste_messages, id: 5317
    Device sessions

    34. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    35. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    36. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    37. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    38. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    39. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    40. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    41. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    42. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    43. test_manage_assets, id: 5341
    Device sessions

    44. test_browser_managing_bookmarks, id: 6633
    Device sessions

    45. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    46. test_request_stt_from_daap, id: 5309
    Device sessions

    47. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    48. test_dapps_permissions, id: 5738
    Device sessions

    49. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    50. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    51. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    52. test_wallet_set_up, id: 5335
    Device sessions

    53. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    54. test_home_view, id: 5379
    Device sessions

    55. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    56. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    57. test_set_profile_picture, id: 6646
    Device sessions

    58. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    59. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    60. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    61. test_pass_phrase_validation, id: 5363
    Device sessions

    62. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    63. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    64. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    65. test_fetching_balance_after_offline, id: 6237
    Device sessions

    66. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    67. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @churik
    Copy link
    Member

    churik commented Oct 1, 2021

    Awesome work @flexsurfer!
    No regression found.

    @flexsurfer flexsurfer force-pushed the feature/contacts-performance branch from 47de8f2 to e58191f Compare October 1, 2021 10:30
    @status-im-auto
    Copy link
    Member

    96% of end-end tests have passed

    Total executed tests: 67
Failed tests: 3
Passed tests: 64

    IDs of failed tests: 6228,6253,6646

    Failed tests (3)

    Click to expand
  • Rerun tests

    • 1. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: *Find Button by xpath:* `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: *Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Peer-to-peer connection is not working when mobile data fetching is off

    Device sessions

    2. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Expected amount of confirmations is 6, in fact 6
    Device 1: *Find Button by xpath:* `//*[contains(@text, "You sent 0.001111153 ETH")]`

    Device 1: Button by xpath: `//*[contains(@text, "You sent 0.001111153 ETH")]` is not found on the screen

    Device sessions

    3. test_set_profile_picture, id: 6646

    Device 2: **Looking for a message by text: Text message**
    Device 2: *Find MemberPhoto by xpath:* `//*[starts-with(@text,'Text message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='member-photo']`

    Device 1: Profile picture was not updated in chat

    Device sessions

    Passed tests (64)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    26. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    27. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    28. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    29. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    31. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    32. test_long_press_to_delete_chat, id: 5319
    Device sessions

    33. test_copy_and_paste_messages, id: 5317
    Device sessions

    34. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    35. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    36. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    37. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    38. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    39. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    40. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    41. test_manage_assets, id: 5341
    Device sessions

    42. test_browser_managing_bookmarks, id: 6633
    Device sessions

    43. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    44. test_request_stt_from_daap, id: 5309
    Device sessions

    45. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    46. test_dapps_permissions, id: 5738
    Device sessions

    47. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    48. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    49. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    50. test_wallet_set_up, id: 5335
    Device sessions

    51. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    52. test_home_view, id: 5379
    Device sessions

    53. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    54. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    55. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    56. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    57. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    58. test_pass_phrase_validation, id: 5363
    Device sessions

    59. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    60. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    61. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    62. test_fetching_balance_after_offline, id: 6237
    Device sessions

    63. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    64. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @status-im-auto
    Copy link
    Member

    33% of end-end tests have passed

    Total executed tests: 3
Failed tests: 2
Passed tests: 1

    IDs of failed tests: 6646,6228

    Failed tests (2)

    Click to expand
  • Rerun tests

    • 1. test_set_profile_picture, id: 6646

    Device 2: **Looking for a message by text: Text message**
    Device 2: *Find MemberPhoto by xpath:* `//*[starts-with(@text,'Text message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='member-photo']`

    Device 1: Profile picture was not updated in chat

    Device sessions

    2. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: *Find Button by xpath:* `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: *Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    Passed tests (1)

    Click to expand

    1. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    @flexsurfer flexsurfer force-pushed the feature/contacts-performance branch from 19c455a to dcc62ec Compare October 4, 2021 10:47
    @status-im-auto
    Copy link
    Member

    97% of end-end tests have passed

    Total executed tests: 67
Failed tests: 2
Passed tests: 65

    IDs of failed tests: 6228,6646

    Failed tests (2)

    Click to expand
  • Rerun tests

    • 1. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: *Find Button by xpath:* `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: *Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    2. test_set_profile_picture, id: 6646

    Device 2: **Looking for a message by text: Text message**
    Device 2: *Find MemberPhoto by xpath:* `//*[starts-with(@text,'Text message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='member-photo']`

    Device 1: Profile picture was not updated in chat

    Device sessions

    Passed tests (65)

    Click to expand

    1. test_send_token_with_7_decimals, id: 5350
    Device sessions

    2. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    3. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    4. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    5. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    6. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    7. test_long_press_to_delete_chat, id: 5319
    Device sessions

    8. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    9. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    10. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    11. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    12. test_manage_assets, id: 5341
    Device sessions

    13. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    14. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    15. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    16. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    17. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    18. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    19. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    20. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    21. test_browser_managing_bookmarks, id: 6633
    Device sessions

    22. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    23. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    24. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    25. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    26. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    27. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    28. test_dapps_permissions, id: 5738
    Device sessions

    29. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    30. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    31. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    32. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    33. test_request_stt_from_daap, id: 5309
    Device sessions

    34. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    35. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    36. test_delete_close_all_tabs, id: 5390
    Device sessions

    37. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    38. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    39. test_block_user_from_public_chat, id: 5786
    Device sessions

    40. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    41. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    42. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    43. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    44. test_home_view, id: 5379
    Device sessions

    45. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    46. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    47. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    48. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    49. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    50. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    51. test_fetching_balance_after_offline, id: 6237
    Device sessions

    52. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    53. test_copy_and_paste_messages, id: 5317
    Device sessions

    54. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    55. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    56. test_pass_phrase_validation, id: 5363
    Device sessions

    57. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    58. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    59. test_wallet_set_up, id: 5335
    Device sessions

    60. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    61. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    62. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    63. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    64. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    65. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    @flexsurfer flexsurfer closed this Oct 4, 2021
    @flexsurfer flexsurfer force-pushed the feature/contacts-performance branch from dcc62ec to 1bbebc9 Compare October 4, 2021 13:10
    @flexsurfer flexsurfer merged commit 1bbebc9 into develop Oct 4, 2021
    @flexsurfer flexsurfer deleted the feature/contacts-performance branch October 4, 2021 13:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    Assignees

    @churik churik

    @flexsurfer flexsurfer

    Labels
    Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @flexsurfer @status-im-auto @churik @cammellos @shivekkhurana