Fix profile image in push notifications #12427

briansztamfater · 2021-08-05T20:30:48Z

fixes #12331

Summary

This PR aims to fix user profile picture is not shown in Push Notifications

Platforms

Android

Functional

1-1 chats

Steps to test

Open Status
User A: open status, add User B to contacts
User B: set profile picture
User B: send message to User A
Verify if profile image is displaying in PN

status: ready

status-im-auto · 2021-08-05T20:46:05Z

Jenkins Builds

Click to see older builds (83)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`8fe29fb`	#1	2021-08-05 20:46:04	~15 min	`android`	📦`apk` 📲
✔️	`8fe29fb`	#1	2021-08-05 20:46:40	~15 min	`ios`	📦`ipa` 📲
✔️	`8fe29fb`	#1	2021-08-05 20:48:38	~17 min	`android-e2e`	📦`apk` 📲

✔️	`5cf5958`	#2	2021-08-05 23:19:57	~13 min	`ios`	📦`ipa` 📲
✔️	`5cf5958`	#2	2021-08-05 23:23:22	~17 min	`android-e2e`	📦`apk` 📲
✔️	`5cf5958`	#2	2021-08-05 23:23:32	~17 min	`android`	📦`apk` 📲

✔️	`9dd93b2`	#3	2021-08-05 23:44:27	~13 min	`ios`	📦`ipa` 📲
✔️	`9dd93b2`	#3	2021-08-05 23:44:51	~13 min	`android-e2e`	📦`apk` 📲
✔️	`9dd93b2`	#3	2021-08-05 23:44:55	~13 min	`android`	📦`apk` 📲

❌	`b3a6611`	#4	2021-08-06 19:27:39	~31 sec	`android`	📄`log`
❌	`b3a6611`	#4	2021-08-06 19:27:39	~31 sec	`android-e2e`	📄`log`
❌	`b3a6611`	#4	2021-08-06 19:27:50	~36 sec	`ios`	📄`log`

✔️	`be91c60`	#5	2021-08-06 19:51:08	~15 min	`ios`	📦`ipa` 📲
✔️	`be91c60`	#5	2021-08-06 19:55:21	~19 min	`android-e2e`	📦`apk` 📲
✔️	`be91c60`	#5	2021-08-06 19:55:29	~19 min	`android`	📦`apk` 📲

✔️	`867a38e`	#6	2021-08-06 22:07:04	~20 min	`android-e2e`	📦`apk` 📲
✔️	`867a38e`	#6	2021-08-06 22:07:10	~20 min	`ios`	📦`ipa` 📲
✔️	`867a38e`	#6	2021-08-06 22:07:11	~20 min	`android`	📦`apk` 📲

✔️	`b2dec8a`	#7	2021-08-06 22:59:04	~16 min	`ios`	📦`ipa` 📲
✔️	`b2dec8a`	#7	2021-08-06 23:01:35	~18 min	`android-e2e`	📦`apk` 📲
✔️	`b2dec8a`	#7	2021-08-06 23:01:40	~18 min	`android`	📦`apk` 📲

✔️	`da80aad`	#8	2021-08-07 05:20:07	~15 min	`ios`	📦`ipa` 📲
✔️	`da80aad`	#8	2021-08-07 05:20:27	~15 min	`android-e2e`	📦`apk` 📲
✔️	`da80aad`	#8	2021-08-07 05:20:36	~16 min	`android`	📦`apk` 📲

✔️	`e57bd53`	#9	2021-08-07 05:47:10	~15 min	`ios`	📦`ipa` 📲
✔️	`e57bd53`	#9	2021-08-07 05:48:30	~16 min	`android-e2e`	📦`apk` 📲
✔️	`e57bd53`	#9	2021-08-07 05:48:33	~17 min	`android`	📦`apk` 📲

✔️	`5b6a8d6`	#10	2021-08-07 06:08:18	~15 min	`ios`	📦`ipa` 📲
✔️	`5b6a8d6`	#10	2021-08-07 06:09:49	~17 min	`android-e2e`	📦`apk` 📲
✔️	`5b6a8d6`	#10	2021-08-07 06:10:31	~17 min	`android`	📦`apk` 📲

✔️	`c20d60e`	#11	2021-08-07 06:27:39	~13 min	`android`	📦`apk` 📲
✔️	`c20d60e`	#11	2021-08-07 06:28:48	~14 min	`android-e2e`	📦`apk` 📲
✔️	`c20d60e`	#11	2021-08-07 06:30:37	~16 min	`ios`	📦`ipa` 📲

✔️	`92cba78`	#12	2021-08-07 06:32:57	~15 min	`android-e2e`	📦`apk` 📲
✔️	`92cba78`	#12	2021-08-07 06:34:37	~17 min	`ios`	📦`ipa` 📲
✔️	`92cba78`	#12	2021-08-07 06:35:39	~18 min	`android`	📦`apk` 📲

✔️	`9fce2f9`	#13	2021-08-07 18:21:04	~15 min	`ios`	📦`ipa` 📲
✔️	`9fce2f9`	#13	2021-08-07 18:22:52	~17 min	`android-e2e`	📦`apk` 📲
✔️	`9fce2f9`	#13	2021-08-07 18:22:54	~17 min	`android`	📦`apk` 📲

❌	`e377a1c`	#14	2021-09-15 17:54:35	~6 min	`android-e2e`	📄`log`
❌	`e377a1c`	#14	2021-09-15 17:55:12	~7 min	`android`	📄`log`
❌	`e377a1c`	#14	2021-09-15 18:00:20	~12 min	`ios`	📄`log`

❌	`b9d23b4`	#15	2021-09-15 18:13:25	~3 min	`android`	📄`log`
❌	`b9d23b4`	#15	2021-09-15 18:13:40	~3 min	`android-e2e`	📄`log`
❌	`b9d23b4`	#15	2021-09-15 18:25:20	~15 min	`ios`	📄`log`

✔️	`15b444f`	#16	2021-09-15 18:31:30	~16 min	`android`	📦`apk` 📲
✔️	`15b444f`	#16	2021-09-15 18:31:48	~17 min	`android-e2e`	📦`apk` 📲
✔️	`15b444f`	#16	2021-09-15 18:33:14	~18 min	`ios`	📦`ipa` 📲

❌	`47d0256`	#18	2021-09-27 17:03:27	~7 min	`android-e2e`	📄`log`
❌	`47d0256`	#18	2021-09-27 17:03:28	~7 min	`android`	📄`log`

✔️	`ba123a0`	#17	2021-09-27 17:11:59	~16 min	`android`	📦`apk` 📲
✔️	`ba123a0`	#17	2021-09-27 17:12:31	~17 min	`android-e2e`	📦`apk` 📲

❌	`9fe1781`	#19	2021-09-30 14:28:48	~1 min	`android`	📄`log`
❌	`9fe1781`	#19	2021-09-30 14:29:00	~1 min	`android-e2e`	📄`log`
❌	`9fe1781`	#19	2021-09-30 14:57:49	~30 min	`ios`	📄`log`

✔️	`e931cc5`	#20	2021-09-30 15:26:29	~17 min	`android-e2e`	📦`apk` 📲
✔️	`e931cc5`	#20	2021-09-30 15:26:34	~17 min	`android`	📦`apk` 📲
✔️	`e931cc5`	#20	2021-09-30 15:28:09	~19 min	`ios`	📦`ipa` 📲

✔️	`2efe899`	#21	2021-10-01 13:16:29	~11 min	`android`	📦`apk` 📲
✔️	`2efe899`	#21	2021-10-01 13:17:25	~12 min	`android-e2e`	📦`apk` 📲
✔️	`2efe899`	#21	2021-10-01 13:29:48	~24 min	`ios`	📦`ipa` 📲

✔️	`0affff5`	#22	2021-10-01 15:15:27	~14 min	`android-e2e`	📦`apk` 📲
✔️	`0affff5`	#22	2021-10-01 15:17:11	~16 min	`ios`	📦`ipa` 📲
✔️	`0affff5`	#22	2021-10-01 15:18:05	~17 min	`android`	📦`apk` 📲

❌	`9954b34`	#23	2021-10-01 21:18:39	~6 min	`android-e2e`	📄`log`
❌	`9954b34`	#23	2021-10-01 21:20:18	~8 min	`android`	📄`log`
✔️	`9954b34`	#23	2021-10-01 21:31:37	~19 min	`ios`	📦`ipa` 📲

❌	`5ad0839`	#24	2021-10-01 21:23:03	~3 min	`android-e2e`	📄`log`
❌	`5ad0839`	#24	2021-10-01 21:26:26	~6 min	`android`	📄`log`
✔️	`5ad0839`	#24	2021-10-01 21:34:46	~15 min	`ios`	📦`ipa` 📲

✔️	`49f6004`	#25	2021-10-01 21:36:13	~11 min	`android`	📦`apk` 📲
✔️	`49f6004`	#25	2021-10-01 21:39:40	~15 min	`android-e2e`	📦`apk` 📲
✔️	`49f6004`	#25	2021-10-01 21:44:32	~20 min	`ios`	📦`ipa` 📲

✔️	`f39e814`	#26	2021-10-01 21:41:30	~11 min	`android`	📦`apk` 📲
✔️	`f39e814`	#26	2021-10-01 21:41:50	~12 min	`android-e2e`	📦`apk` 📲
✔️	`f39e814`	#26	2021-10-01 21:44:36	~14 min	`ios`	📦`ipa` 📲
❌	`f39e814`	#27	2021-10-05 14:08:37	~17 sec	`ios`	📄`log`

✔️	`d2f80b7`	#27	2021-10-05 14:44:07	~11 min	`android-e2e`	📦`apk` 📲
✔️	`d2f80b7`	#27	2021-10-05 14:44:09	~11 min	`android`	📦`apk` 📲
✔️	`d2f80b7`	#28	2021-10-05 14:48:25	~15 min	`ios`	📦`ipa` 📲

✔️	`5f8d806`	#28	2021-10-05 17:27:00	~14 min	`android`	📦`apk` 📲
✔️	`5f8d806`	#28	2021-10-05 17:29:41	~16 min	`android-e2e`	📦`apk` 📲
✔️	`5f8d806`	#29	2021-10-05 17:30:19	~17 min	`ios`	📦`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`5e3b665`	#29	2021-10-07 14:44:43	~17 min	`android`	📦`apk` 📲
✔️	`5e3b665`	#29	2021-10-07 14:53:26	~25 min	`android-e2e`	📦`apk` 📲

✔️	`0afbe80`	#30	2021-10-07 14:53:45	~22 min	`android-e2e`	📦`apk` 📲
✔️	`0afbe80`	#31	2021-10-07 14:55:56	~22 min	`android-e2e`	📦`apk` 📲

status-im-auto · 2021-08-07T05:47:46Z

✔️ status-react/prs/ios/PR-12427#9 🔹 ~16 min 🔹 `e57bd53` 🔹 📦 ios package

status-im-auto · 2021-09-15T23:42:48Z

77% of end-end tests have passed

Total executed tests: 69
Failed tests: 16
Passed tests: 53

IDs of failed tests: 6305,6244,5314,5412,5350,5758,6645,6272,5381,5309,6263,5346,6249,6240,5373,6237

Failed tests (16)

Click to expand

Rerun tests

1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device 2: Find Button by xpath: `//[@text="Hey hey hey"]` Device 2: Find Button by xpath:* `//[@text="Hey hey hey"]` Device 2: Button by xpath: `//*[@text="Hey hey hey"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_insufficient_funds_wallet_positive_balance, id: 5412
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
5. test_send_token_with_7_decimals, id: 5350
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
6. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device 1: Getting LXS amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':LXS-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
7. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
Device 1: Getting ADI amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
8. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
9. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device 1: Find Button by xpath: `//[@text="Collectibles"]` Device 1: Tap on found Button* `Device 1: User collectibles token name in not shown` Device sessions Device 1: Steps, video, logs Failure screenshot
10. test_request_stt_from_daap, id: 5309
Device 1: Getting STT amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
11. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device 2: Getting STT amount Device 2: Scrolling down to SilentButton Device 2: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
12. test_collectible_from_wallet, id: 5346
Device 1: Check collectibles amount in wallet Device 1: ========================================================================= Device 1: Text by xpath:`//*[@text='CryptoKitties']//following-sibling::android.widget.TextView` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
13. test_keycard_request_stt_from_daap, id: 6249
Device 1: Getting STT amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
14. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device 1: Getting ADI amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
15. test_send_and_open_links_with_previews, id: 5373
Device 2: Tap on found OpenInStatusButton Device 2: Find Button by xpath: `//[@text="Private, Secure Communication"]` Device 2: Button by xpath: `//[@text="Private, Secure Communication"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
16. test_fetching_balance_after_offline, id: 6237
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (53)

Click to expand

1. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions Device 1: Steps, video, logs
2. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions Device 1: Steps, video, logs
3. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
Device sessions Device 1: Steps, video, logs
4. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
Device sessions Device 1: Steps, video, logs
5. test_open_public_chat_using_deep_link, id: 5396
Device sessions Device 1: Steps, video, logs
6. test_offline_add_new_group_chat_member, id: 3998
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
7. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_delete_close_all_tabs, id: 5390
Device sessions Device 1: Steps, video, logs
9. test_create_new_group_chat_messaging_pn_delivered, id: 3994
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_delete_chats_via_delete_button_rejoin, id: 5387
Device sessions Device 1: Steps, video, logs
11. test_send_transaction_set_recipient_options, id: 6328
Device sessions Device 1: Steps, video, logs
12. test_keycard_sign_message_and_transactions_from_daap, id: 6251
Device sessions Device 1: Steps, video, logs
13. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions Device 1: Steps, video, logs
14. test_block_user_from_public_chat, id: 5786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
15. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
16. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
Device sessions Device 1: Steps, video, logs
17. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
18. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
19. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions Device 1: Steps, video, logs
20. test_keycard_create_login_restore_unlock_same_seed, id: 5689
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
21. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
22. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
23. test_long_press_to_delete_chat, id: 5319
Device sessions Device 1: Steps, video, logs
24. test_copy_and_paste_messages, id: 5317
Device sessions Device 1: Steps, video, logs
25. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
Device sessions Device 1: Steps, video, logs
26. test_unread_messages_counter_public_chat, id: 5360
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
27. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
Device sessions Device 1: Steps, video, logs
28. test_mobile_data_usage_complex_settings, id: 6228
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
29. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions Device 1: Steps, video, logs
30. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
31. test_send_eth_in_1_1_chat_transaction_push, id: 6253
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
32. test_install_pack_and_send_sticker, id: 5782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
33. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
Device sessions Device 1: Steps, video, logs
34. test_manage_assets, id: 5341
Device sessions Device 1: Steps, video, logs
35. test_browser_managing_bookmarks, id: 6633
Device sessions Device 1: Steps, video, logs
36. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
Device sessions Device 1: Steps, video, logs
37. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions Device 1: Steps, video, logs
38. test_dapps_permissions, id: 5738
Device sessions Device 1: Steps, video, logs
39. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
Device sessions Device 1: Steps, video, logs
40. test_send_eth_to_ens_in_chat, id: 6279
Device sessions Device 1: Steps, video, logs
41. test_share_copy_contact_code_and_wallet_address, id: 5323
Device sessions Device 1: Steps, video, logs
42. test_wallet_set_up, id: 5335
Device sessions Device 1: Steps, video, logs
43. test_send_transaction_with_custom_token, id: 6208
Device sessions Device 1: Steps, video, logs
44. test_home_view, id: 5379
Device sessions Device 1: Steps, video, logs
45. test_can_add_existing_ens, id: 5502
Device sessions Device 1: Steps, video, logs
46. test_logcat_backup_recovery_phrase, id: 5419
Device sessions Device 1: Steps, video, logs
47. test_set_profile_picture, id: 6646
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
48. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
49. test_pass_phrase_validation, id: 5363
Device sessions Device 1: Steps, video, logs
50. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
51. test_reactions_to_message_in_chats, id: 6315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
52. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
53. test_public_chat_messaging_emojis_timestamps, id: 5313
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2021-09-16T13:23:29Z

@briansztamfater thanks for PR!

ISSUE 1: Settings `Show profile pictures of` are not applied to profile pictures in PNs

Profile picture in PN is displayed for receiver even if the Show profile pictures setting is set to Contacts / None.

Reproduction:
UserA (Android):

Enable PNs
Join a public chat (This behavior is reproducible for PNs from any chat)
Send a message
Put the app in the background

UserB:

Join the same public chat
Mention UserA

UserA:

Check PN

Expected result:
No profile image in PN from non-contact / anyone if the Show profile pictures setting is set to Contacts / None
Actual result:
User can see profile images in PN with any settings

ISSUE 2/Q: Could we have a rounded profile image in PNs?

Also, it would be nice to check profile images in PNs after merging push notification on group chat invite. So could you rebase the current PR after merging the other one, please?

briansztamfater · 2021-09-30T15:39:45Z

@qoqobolo did the changes to consider the privacy settings for the profile picture. Also images in notifications should appear circled. Let me know if something arises during testing.

qoqobolo · 2021-10-01T09:52:11Z

@briansztamfater can you please rebase it?
Thanks

briansztamfater · 2021-10-01T13:05:04Z

@briansztamfater can you please rebase it? Thanks

Sure, rebase done @qoqobolo

qoqobolo · 2021-10-01T14:18:37Z

Thanks, @briansztamfater!
Is it expected that there is no profile image in PN on the group invite?
I believe we could add profile images to this type of PNs ass well, because 3-random name of admin is displayed there. WDYT?

status-im-auto · 2021-10-01T14:57:25Z

99% of end-end tests have passed

Total executed tests: 67
Failed tests: 1
Passed tests: 66

IDs of failed tests: 3994

Failed tests (1)

Click to expand

Rerun tests

1. test_create_new_group_chat_messaging_pn_delivered, id: 3994
Device 2: Looking for a message by text: Message from device: 1 Device 2: Looking for a message by text: Message from device: 2 `Message from device '2' was not received` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (66)

Click to expand

1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions Device 1: Steps, video, logs
3. test_can_add_existing_ens_on_mainnet, id: 5502
Device sessions Device 1: Steps, video, logs
4. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions Device 1: Steps, video, logs
5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
Device sessions Device 1: Steps, video, logs
6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device sessions Device 1: Steps, video, logs
7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
Device sessions Device 1: Steps, video, logs
8. test_open_public_chat_using_deep_link, id: 5396
Device sessions Device 1: Steps, video, logs
9. test_offline_add_new_group_chat_member, id: 3998
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
Device sessions Device 1: Steps, video, logs
12. test_insufficient_funds_wallet_positive_balance, id: 5412
Device sessions Device 1: Steps, video, logs
13. test_delete_close_all_tabs, id: 5390
Device sessions Device 1: Steps, video, logs
14. test_send_token_with_7_decimals, id: 5350
Device sessions Device 1: Steps, video, logs
15. test_delete_chats_via_delete_button_rejoin, id: 5387
Device sessions Device 1: Steps, video, logs
16. test_send_transaction_set_recipient_options, id: 6328
Device sessions Device 1: Steps, video, logs
17. test_keycard_sign_message_and_transactions_from_daap, id: 6251
Device sessions Device 1: Steps, video, logs
18. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions Device 1: Steps, video, logs
19. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device sessions Device 1: Steps, video, logs
20. test_block_user_from_public_chat, id: 5786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
21. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
22. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
Device sessions Device 1: Steps, video, logs
23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
Device sessions Device 1: Steps, video, logs
24. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
25. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
26. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions Device 1: Steps, video, logs
27. test_keycard_create_login_restore_unlock_same_seed, id: 5689
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
Device sessions Device 1: Steps, video, logs
29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
30. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
31. test_long_press_to_delete_chat, id: 5319
Device sessions Device 1: Steps, video, logs
32. test_copy_and_paste_messages, id: 5317
Device sessions Device 1: Steps, video, logs
33. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
Device sessions Device 1: Steps, video, logs
34. test_unread_messages_counter_public_chat, id: 5360
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
35. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
Device sessions Device 1: Steps, video, logs
36. test_mobile_data_usage_complex_settings, id: 6228
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
37. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions Device 1: Steps, video, logs
38. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
39. test_send_eth_in_1_1_chat_transaction_push, id: 6253
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
40. test_install_pack_and_send_sticker, id: 5782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
41. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
Device sessions Device 1: Steps, video, logs
42. test_manage_assets, id: 5341
Device sessions Device 1: Steps, video, logs
43. test_browser_managing_bookmarks, id: 6633
Device sessions Device 1: Steps, video, logs
44. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
Device sessions Device 1: Steps, video, logs
45. test_request_stt_from_daap, id: 5309
Device sessions Device 1: Steps, video, logs
46. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions Device 1: Steps, video, logs
47. test_dapps_permissions, id: 5738
Device sessions Device 1: Steps, video, logs
48. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
Device sessions Device 1: Steps, video, logs
49. test_send_eth_to_ens_in_chat, id: 6279
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
50. test_share_copy_contact_code_and_wallet_address, id: 5323
Device sessions Device 1: Steps, video, logs
51. test_wallet_set_up, id: 5335
Device sessions Device 1: Steps, video, logs
52. test_send_transaction_with_custom_token, id: 6208
Device sessions Device 1: Steps, video, logs
53. test_home_view, id: 5379
Device sessions Device 1: Steps, video, logs
54. test_logcat_backup_recovery_phrase, id: 5419
Device sessions Device 1: Steps, video, logs
55. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
56. test_set_profile_picture, id: 6646
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
57. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
58. test_keycard_request_stt_from_daap, id: 6249
Device sessions Device 1: Steps, video, logs
59. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device sessions Device 1: Steps, video, logs
60. test_pass_phrase_validation, id: 5363
Device sessions Device 1: Steps, video, logs
61. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
62. test_send_and_open_links_with_previews, id: 5373
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
63. test_reactions_to_message_in_chats, id: 6315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
64. test_fetching_balance_after_offline, id: 6237
Device sessions Device 1: Steps, video, logs
65. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
66. test_public_chat_messaging_emojis_timestamps, id: 5313
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

briansztamfater · 2021-10-01T15:02:31Z

@qoqobolo I agree, that would be a nice addition. Updated PR with that change :)

qoqobolo · 2021-10-01T15:43:17Z

@briansztamfater PNs on group chat invites are not received in the latest build (0affff5) 👀

briansztamfater · 2021-10-01T15:58:08Z

@briansztamfater PNs on group chat invites are not received in the latest build (0affff5) 👀

@qoqobolo Hmm interesting, worked on my local build but didn't work on the PR apk. I'll dive into the problem and come back to you with previous deep testing. Sorry about that!

briansztamfater · 2021-10-01T22:42:48Z

@qoqobolo diving deeper into notifications UX, it seems that default behavior is to show icons on the right side since Android Lollipop, unless it is a conversation. As this is just an invite to a group and not an initiated chat / conversation, maybe it is ok to show it on the right side.

What do you think?

(Also, if you are OK with that, PR is ready to test)

churik · 2021-10-04T08:31:32Z

@briansztamfater
It doesn't seem so important to me, as I don't think it is too often the situation when you have several PNs to notice the difference.
However, we can fix it later.
@hesterbruikman better to know your opinion about that.

hesterbruikman · 2021-10-05T13:58:27Z

@briansztamfater to make sure I understand the issue:

Is the notification only treated differently when it's a group chat invite?
Do I understand correctly that because the notification is treated differently it can be shown with either no profile image or profile image on the right?
What happens when a user receives 2 group chat invites from different people at the same time? This makes me think that it's probably better to leave profile image out of group chat invites altogether

Agree with @churik that in any case this would be an uncommon scenario. I do want to understand the issue a bit better though; The scenario might be more common on first time use. You join a community and get invited to a bunch of group chats by members

briansztamfater · 2021-10-05T14:17:44Z

@briansztamfater to make sure I understand the issue:

Is the notification only treated differently when it's a group chat invite?

Do I understand correctly that because the notification is treated differently it can be shown with either no profile image or profile image on the right?

What happens when a user receives 2 group chat invites from different people at the same time? This makes me think that it's probably better to leave profile image out of group chat invites altogether

Agree with @churik that in any case this would be an uncommon scenario. I do want to understand the issue a bit better though; The scenario might be more common on first time use. You join a community and get invited to a bunch of group chats by members

@hesterbruikman thanks for your time, really appreciate your questions.

Exactly, but in reality, the conversation notifications are those treated differently, as the default behavior is to have the icon on the right since Android Lollipop.
Correct, we can show the notification with no profile image on the right, or with no profile image at all (that's how it is currently working in develop branch)
In that case user should receive two different notifications with different profile pictures at the right (if we decide to show them)

qoqobolo · 2021-10-05T15:38:33Z

@briansztamfater

ISSUE 3: In the latest build `d2f80b7` group invites from contacts are sent to the Activity center

Steps:

UserA and UserB add to contacts each other
UserA creates a group chat with UserB

Expected result: the group chat to which the user was invited by his contact is displayed on the home screen
Actual result: the group chat is displayed in the Activity center

briansztamfater · 2021-10-05T16:59:11Z

@qoqobolo seems I also need to rebase status-go part due to some contacts logic modification, on it right now

briansztamfater · 2021-10-05T17:49:23Z

@qoqobolo Done. Profile image is still showing on group invite notifications, so I'll stay tuned on whether we should remove it or not

qoqobolo · 2021-10-06T08:17:43Z

@briansztamfater let's keep it as it is, with the profile image on the right, it looks good!
Also, tested the case with 2 group chat invites from different users and can confirm that in that case user receives two different notifications with different profile pictures at the right.

Everything works fine now, thanks for the great work!
PR can be merged.

Signed-off-by: Brian Sztamfater <brian@status.im>

briansztamfater added bug push-notifications labels Aug 5, 2021

briansztamfater self-assigned this Aug 5, 2021

briansztamfater marked this pull request as draft August 5, 2021 20:30

briansztamfater force-pushed the fix/push-notification-picture branch 8 times, most recently from da80aad to e57bd53 Compare August 7, 2021 05:31

briansztamfater force-pushed the fix/push-notification-picture branch 2 times, most recently from 5b6a8d6 to c20d60e Compare August 7, 2021 06:13

briansztamfater changed the title ~~[WIP] Fix profile image in push notiications~~ Fix profile image in push notiications Aug 7, 2021

briansztamfater marked this pull request as ready for review August 7, 2021 06:14

briansztamfater force-pushed the fix/push-notification-picture branch from c20d60e to 92cba78 Compare August 7, 2021 06:17

briansztamfater added the request-manual-qa label Aug 7, 2021

briansztamfater force-pushed the fix/push-notification-picture branch from 92cba78 to 9fce2f9 Compare August 7, 2021 18:05

briansztamfater changed the title ~~Fix profile image in push notiications~~ Fix profile image in push notifications Aug 7, 2021

briansztamfater added the android label Aug 7, 2021

rasom approved these changes Aug 9, 2021

View reviewed changes

briansztamfater force-pushed the fix/push-notification-picture branch 3 times, most recently from b9d23b4 to 15b444f Compare September 15, 2021 18:14

qoqobolo self-assigned this Sep 16, 2021

briansztamfater force-pushed the fix/push-notification-picture branch 2 times, most recently from 9fe1781 to e931cc5 Compare September 30, 2021 15:08

qoqobolo removed the Tested - Issues label Oct 1, 2021

briansztamfater force-pushed the fix/push-notification-picture branch from e931cc5 to 2efe899 Compare October 1, 2021 13:04

briansztamfater force-pushed the fix/push-notification-picture branch 3 times, most recently from 49f6004 to f39e814 Compare October 1, 2021 21:29

briansztamfater force-pushed the fix/push-notification-picture branch from f39e814 to d2f80b7 Compare October 5, 2021 14:32

qoqobolo added the Tested - OK label Oct 6, 2021

briansztamfater force-pushed the fix/push-notification-picture branch from 5f8d806 to 5e3b665 Compare October 7, 2021 14:27

Fix profile image in push notiications

0afbe80

Signed-off-by: Brian Sztamfater <brian@status.im>

briansztamfater force-pushed the fix/push-notification-picture branch from 5e3b665 to 0afbe80 Compare October 7, 2021 14:31

briansztamfater merged commit 0afbe80 into develop Oct 7, 2021

briansztamfater deleted the fix/push-notification-picture branch October 7, 2021 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix profile image in push notifications #12427

Fix profile image in push notifications #12427

briansztamfater commented Aug 5, 2021 •

edited

Loading

status-im-auto commented Aug 5, 2021 •

edited

Loading

status-im-auto commented Aug 7, 2021

status-im-auto commented Sep 15, 2021

qoqobolo commented Sep 16, 2021

briansztamfater commented Sep 30, 2021 •

edited

Loading

qoqobolo commented Oct 1, 2021

briansztamfater commented Oct 1, 2021

qoqobolo commented Oct 1, 2021

status-im-auto commented Oct 1, 2021

briansztamfater commented Oct 1, 2021

qoqobolo commented Oct 1, 2021

briansztamfater commented Oct 1, 2021

briansztamfater commented Oct 1, 2021 •

edited

Loading

churik commented Oct 4, 2021

hesterbruikman commented Oct 5, 2021

briansztamfater commented Oct 5, 2021

qoqobolo commented Oct 5, 2021

briansztamfater commented Oct 5, 2021 •

edited

Loading

briansztamfater commented Oct 5, 2021

qoqobolo commented Oct 6, 2021 •

edited

Loading

Fix profile image in push notifications #12427

Fix profile image in push notifications #12427

Conversation

briansztamfater commented Aug 5, 2021 • edited Loading

Summary

Platforms

Functional

Steps to test

status-im-auto commented Aug 5, 2021 • edited Loading

Jenkins Builds

status-im-auto commented Aug 7, 2021

✔️ status-react/prs/ios/PR-12427#9 🔹 ~16 min 🔹 e57bd53 🔹 📦 ios package

status-im-auto commented Sep 15, 2021

77% of end-end tests have passed

Failed tests (16)

Passed tests (53)

qoqobolo commented Sep 16, 2021

ISSUE 1: Settings Show profile pictures of are not applied to profile pictures in PNs

ISSUE 2/Q: Could we have a rounded profile image in PNs?

briansztamfater commented Sep 30, 2021 • edited Loading

qoqobolo commented Oct 1, 2021

briansztamfater commented Oct 1, 2021

qoqobolo commented Oct 1, 2021

status-im-auto commented Oct 1, 2021

99% of end-end tests have passed

Failed tests (1)

Passed tests (66)

briansztamfater commented Oct 1, 2021

qoqobolo commented Oct 1, 2021

briansztamfater commented Oct 1, 2021

briansztamfater commented Oct 1, 2021 • edited Loading

churik commented Oct 4, 2021

hesterbruikman commented Oct 5, 2021

briansztamfater commented Oct 5, 2021

qoqobolo commented Oct 5, 2021

ISSUE 3: In the latest build d2f80b7 group invites from contacts are sent to the Activity center

briansztamfater commented Oct 5, 2021 • edited Loading

briansztamfater commented Oct 5, 2021

qoqobolo commented Oct 6, 2021 • edited Loading

briansztamfater commented Aug 5, 2021 •

edited

Loading

status-im-auto commented Aug 5, 2021 •

edited

Loading

✔️ status-react/prs/ios/PR-12427#9 🔹 ~16 min 🔹 `e57bd53` 🔹 📦 ios package

ISSUE 1: Settings `Show profile pictures of` are not applied to profile pictures in PNs

briansztamfater commented Sep 30, 2021 •

edited

Loading

briansztamfater commented Oct 1, 2021 •

edited

Loading

ISSUE 3: In the latest build `d2f80b7` group invites from contacts are sent to the Activity center

briansztamfater commented Oct 5, 2021 •

edited

Loading

qoqobolo commented Oct 6, 2021 •

edited

Loading