Skip to content

[#12233] support $HEZ erc20 token #12234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2021
Merged

[#12233] support $HEZ erc20 token #12234

merged 1 commit into from
Jun 21, 2021

Conversation

flexsurfer
Copy link
Member

fixes #12233

@flexsurfer flexsurfer self-assigned this Jun 18, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Jun 18, 2021 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ab304b4 #1 2021-06-18 11:15:39 ~12 min android 📦apk 📲
✔️ ab304b4 #1 2021-06-18 11:15:41 ~12 min android-e2e 📦apk 📲
✔️ ab304b4 #1 2021-06-18 11:16:47 ~13 min ios 📦ipa 📲
✔️ cc22c19 #2 2021-06-21 10:01:38 ~10 min android-e2e 📦apk 📲
✔️ cc22c19 #2 2021-06-21 10:06:26 ~15 min android 📦apk 📲
✔️ cc22c19 #2 2021-06-21 10:07:17 ~16 min ios 📦ipa 📲

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 44
Failed tests: 3
Passed tests: 41

IDs of failed tests: 5315,5395,5783

Failed tests (3)

Click to expand
  • Rerun tests

    • 1. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

    Device 1: Button element not found
    Device 1: *Find Text by accessibility id:* `default-username`

    Device 1: Text by accessibility id: `default-username` is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token HEZ at address 0xeef9f339514298c6a857efcfc1a762af84438dee - set to Hermez Network but detected as Hermez Network Toke

    Device sessions

    2. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)

    Device 1: EditBox element not found
    Device 1: *Find Button by accessibility id:* `browser-open-tabs`

    Device 1: Button by accessibility id: `browser-open-tabs` is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token HEZ at address 0xeef9f339514298c6a857efcfc1a762af84438dee - set to Hermez Network but detected as Hermez Network T

    Device sessions

    3. test_can_use_purchased_stickers_on_recovered_account, id: 5783

    Device 1: *Find Button by accessibility id:* `new-chat-button`
    Device 1: ChatButton element not found

    Device 1: ChatButton by accessibility id:`join-public-chat-button` is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token HEZ at address 0xeef9f339514298c6a857efcfc1a762af84438dee - set to Hermez Network but detected as Hermez

    Device sessions

    Passed tests (41)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    3. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    4. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    5. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    6. test_send_token_with_7_decimals, id: 5350
    Device sessions

    7. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    8. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    9. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    10. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    11. test_block_user_from_public_chat, id: 5786
    Device sessions

    12. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    13. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    14. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    15. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    16. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    17. test_long_press_to_delete_chat, id: 5319
    Device sessions

    18. test_copy_and_paste_messages, id: 5317
    Device sessions

    19. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    20. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    21. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    22. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    23. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    24. test_manage_assets, id: 5341
    Device sessions

    25. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    26. test_request_stt_from_daap, id: 5309
    Device sessions

    27. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    28. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    29. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    30. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    31. test_home_view, id: 5379
    Device sessions

    32. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    33. test_set_profile_picture, id: 6646
    Device sessions

    34. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    35. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    36. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    37. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    38. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    39. test_fetching_balance_after_offline, id: 6237
    Device sessions

    40. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    41. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    briansztamfater
    briansztamfater approved these changes Jun 18, 2021
    View reviewed changes
    Copy link
    Contributor

    @briansztamfater briansztamfater left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think there is an e2e test that validates token name, in https://etherscan.io/token/0xEEF9f339514298C6A857EfCfC1A762aF84438dEE#readContract name is Hermez Network Token. Can you confirm @Serhy?

    @qoqobolo qoqobolo self-assigned this Jun 21, 2021
    @qoqobolo
    Copy link
    Contributor

    @briansztamfater yeah, that's true.
    @flexsurfer could you change the name of the token from Hermez Network to Hermez Network Token, please?

    @flexsurfer
    Copy link
    Member Author

    done, thanks

    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 3
Failed tests: 0
Passed tests: 3

    Passed tests (3)

    Click to expand

    1. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    2. test_back_forward_refresh_navigation_history_kept_after_relogin, id: 5395
    Device sessions

    3. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    @flexsurfer
    [#12233] support $HEZ erc20 token
    7bfd671 
    Signed-off-by: andrey <motor4ik@gmail.com>
    @flexsurfer flexsurfer merged commit 7bfd671 into develop Jun 21, 2021
    @flexsurfer flexsurfer deleted the feature/hez-erc20 branch June 21, 2021 10:39
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @briansztamfater briansztamfater briansztamfater approved these changes

    Assignees

    @flexsurfer flexsurfer

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    support $HEZ erc20 token
    4 participants
    @flexsurfer @status-im-auto @qoqobolo @briansztamfater