Keycard account recovery #12115
Merged
Keycard account recovery #12115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (3)
|
cammellos
approved these changes
May 17, 2021
src/status_im/keycard/recovery.cljs
Outdated
| [{:keys [db] :as cofx}] | ||
| (fx/merge cofx | ||
| {:db (-> db | ||
| (assoc-in [:keycard :pin :enter-step] :login) |
There was a problem hiding this comment.
you can probably do as well:
(update-in [:keycard :pin] assoc :enter-step :login
:status nil
:login [])
Which is a bit neater
There was a problem hiding this comment.
thanks for the review! fixed
99% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (69)Click to expand |
|
awesome work @bitgamma !
Found one edge case, but don't think it is worth fixing. Devices:
|
bitgamma
force-pushed
the
feature/recovery-keycard
branch
from
4c2e84f to
5b51806
Compare
Signed-off-by: Michele Balistreri <michele@bitgamma.com>
bitgamma
force-pushed
the
feature/recovery-keycard
branch
from
5b51806 to
72df44d
Compare
This was referenced May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the creation of recovery/backup Keycard from the login interface. It requires the mnemonic and either a new or frozen Keycard (or actually a Keycard in any state, since you can factory reset).
Screenshots for localization