Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change amount-input field keyboard type and autocapitalization to display decimal separator #10393

Merged
merged 2 commits into from
Jun 22, 2020
Merged

fix: change amount-input field keyboard type and autocapitalization to display decimal separator #10393

merged 2 commits into from
Jun 22, 2020

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Apr 21, 2020 •
edited by StatusWrike
Loading

fixes #2681

Summary

This PR is an attempt to fix the issue with not displaying the dot/comma in the keyboard when typing in the input field for setting the amount to send in a transaction. I could not replicate this issue locally (S9+ and Android 6.0 / R), as it seems to happen on specific devices / OS versions.

The solution is based on these comments:
facebook/react-native#22005 (comment)
facebook/react-native#12988 (comment)

Platforms

  • Android
  • iOS

status: WIP

@richard-ramos richard-ramos requested a review from a team as a code owner April 21, 2020 16:31
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Apr 21, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ adbf274 #1 2020-04-21 16:52:49 ~9 min ios 📦ipa 📲
✔️ adbf274 #1 2020-04-21 16:54:31 ~10 min android-e2e 📦apk 📲
✔️ adbf274 #1 2020-04-21 16:56:18 ~12 min android 📦apk 📲
✔️ b200b4f #3 2020-06-19 08:35:21 ~10 min android-e2e 📦apk 📲
✔️ b200b4f #3 2020-06-19 08:37:42 ~12 min android 📦apk 📲
✔️ b200b4f #3 2020-06-19 08:39:38 ~14 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b4a9212 #4 2020-06-19 16:43:25 ~9 min android-e2e 📦apk 📲
✔️ b4a9212 #4 2020-06-19 16:44:44 ~10 min android 📦apk 📲
✔️ b4a9212 #4 2020-06-19 16:48:45 ~14 min ios 📦ipa 📲
✔️ df3dec8 #5 2020-06-22 11:00:07 ~15 min android-e2e 📦apk 📲
✔️ df3dec8 #5 2020-06-22 11:00:30 ~16 min android 📦apk 📲
✔️ df3dec8 #5 2020-06-22 11:03:29 ~18 min ios 📦ipa 📲

@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2020
Closed
@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
@Serhy
Copy link
Contributor

Serhy commented May 12, 2020 •
edited
Loading

@richard-ramos it's amazing! You almost fixed that 2-years old issue! :)
It looks good now when sending transactions from Galaxy Note 4 with Android 6.0.1 where we had an issue.

There is one place where it's needed to make same update though: when Request transaction from 1-1 chat.

Screenshot 2020-05-12 at 16 43 58

To reproduce:

  1. Open Status and create new account
  2. Join any 1-1 chat
  3. Tap [/] commands button in message input.
  4. Tap Request transaction

Could you please update in that screen keyboard setting in a same way?

@flexsurfer flexsurfer force-pushed the fix/dot-comma branch 2 times, most recently from 48befab to b200b4f Compare June 19, 2020 08:24
@flexsurfer
Copy link
Member

@Serhy added to request as well

@status-im-auto
Copy link
Member

98% of end-end tests have passed

Total executed tests: 95
Failed tests: 2
Passed tests: 93

Failed tests (2)

Click to expand
1. test_keycard_send_transaction_from_daap

Device 1: =========================================================================
Device 1: Check logcat for sensitive data

Device 1: ['Password in logcat!!!']

Device sessions

2. test_send_transaction_with_custom_token

Device 1: Tap on OkButton
Device 1: Tap on TransactionHistoryButton

Device 1: Transaction 0.0987141 WEENUS was not found on Wallet/Transaction screen

Device sessions

Passed tests (93)

Click to expand
1. test_request_public_key_status_test_daap
Device sessions

2. test_open_public_chat_using_deep_link
Device sessions

3. test_ens_username_recipient
Device sessions

4. test_keycard_can_see_all_transactions_in_history
Device sessions

5. test_offline_status
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_open_chat_by_pasting_public_key
Device sessions

8. test_back_forward_buttons_browsing_website
Device sessions

9. test_password_in_logcat_creating_account
Device sessions

10. test_can_use_purchased_stickers_on_recovered_account
Device sessions

11. test_insufficient_funds_wallet_positive_balance
Device sessions

12. test_mobile_data_usage_settings
Device sessions

13. test_open_google_com_via_open_dapp
Device sessions

14. test_logcat_backup_recovery_phrase
Device sessions

15. test_unread_messages_counter_public_chat
Device sessions

16. test_send_two_transactions_one_after_another_in_dapp
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_public_chat_clear_history
Device sessions

19. test_wallet_set_up
Device sessions

20. test_timestamp_in_chats
Device sessions

21. test_delete_chats_via_delete_button
Device sessions

22. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

23. test_fetch_more_history_in_empty_chat
Device sessions

24. test_mobile_data_usage_popup_continue_syncing
Device sessions

25. test_keycard_fetching_balance_after_offline
Device sessions

26. test_add_to_contacts
Device sessions

27. test_dapps_permissions
Device sessions

28. test_long_press_delete_clear_all_dapps
Device sessions

29. test_need_help_section
Device sessions

30. test_transaction_wrong_password_wallet
Device sessions

31. test_offline_messaging_1_1_chat
Device sessions

32. test_token_with_more_than_allowed_decimals
Device sessions

33. test_add_account_to_multiaccount_instance_private_key
Device sessions

34. test_text_message_1_1_chat
Device sessions

35. test_install_pack_and_send_sticker
Device sessions

36. test_send_eth_in_1_1_chat
Device sessions

37. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

38. test_image_in_one_to_one_send_save_reply
Device sessions

39. test_send_emoji
Device sessions

40. test_copy_and_paste_messages
Device sessions

41. test_restore_account_from_mnemonic_to_keycard
Device sessions

42. test_add_account_to_multiaccount_instance_generate_new
Device sessions

43. test_send_eth_from_wallet_to_address
Device sessions

44. test_messaging_in_different_networks
Device sessions

45. test_start_chat_with_ens
Device sessions

46. test_logcat_recovering_account
Device sessions

47. test_offline_add_new_group_chat_member
Device sessions

48. test_connection_is_secure
Device sessions

49. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

50. test_send_eth_to_ens_in_chat
Device sessions

51. test_keycard_sign_message_from_daap
Device sessions

52. test_long_press_to_delete_chat
Device sessions

53. test_add_and_remove_contact_from_public_chat
Device sessions

54. test_send_transaction_from_daap
Device sessions

55. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

56. test_keycard_send_eth_from_wallet_to_address
Device sessions

57. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

58. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

59. test_open_blocked_site
Device sessions

60. test_refresh_button_browsing_app_webview
Device sessions

61. test_public_chat_messaging
Device sessions

62. test_pass_phrase_validation
Device sessions

63. test_send_token_with_7_decimals
Device sessions

64. test_sign_message_from_daap
Device sessions

65. test_recover_account_from_new_user_seedphrase
Device sessions

66. test_add_new_keycard_account_and_login
Device sessions

67. test_decline_transactions_in_1_1_chat
Device sessions

68. test_send_and_open_links
Device sessions

69. test_manage_assets
Device sessions

70. test_share_contact_code_and_wallet_address
Device sessions

71. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

72. test_redirect_to_public_chat_tapping_tag_message
Device sessions

73. test_block_user_from_public_chat
Device sessions

74. test_ens_in_public_and_1_1_chats
Device sessions

75. test_sign_typed_message (TestRail link is not found)
Device sessions

76. test_create_new_group_chat
Device sessions

77. test_password_in_logcat_sign_in
Device sessions

78. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

79. test_mobile_data_usage_popup_stop_syncing
Device sessions

80. test_send_non_english_message_to_newly_added_contact
Device sessions

81. test_collectible_from_wallet_opens_in_browser_view
Device sessions

82. test_contact_profile_view
Device sessions

83. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

84. test_switch_users_and_add_new_account
Device sessions

85. test_send_two_transactions_in_batch_in_dapp
Device sessions

86. test_filters_from_daap
Device sessions

87. test_login_with_new_account
Device sessions

88. test_home_view
Device sessions

89. test_log_level_and_fleet
Device sessions

90. test_can_add_existing_ens
Device sessions

91. test_copy_contact_code_and_wallet_address
Device sessions

92. test_fetching_balance_after_offline
Device sessions

93. test_can_see_all_transactions_in_history
Device sessions

@Serhy
Copy link
Contributor

Serhy commented Jun 19, 2020 •
edited
Loading

Thanks @flexsurfer
I've added autocapitalize words because without this key there was no dot separator.
On Android 6.0.1 and Android 8.1 (and iOS too) tested and separator is present everywhere
Thanks @richard-ramos for finding solution!

@status-im-auto
Copy link
Member

98% of end-end tests have passed

Total executed tests: 95
Failed tests: 2
Passed tests: 93

Failed tests (2)

Click to expand
1. test_send_transaction_with_custom_token

Device 1: Tap on OkButton
Device 1: Tap on TransactionHistoryButton

Device 1: Transaction 0.0315951 WEENUS was not found on Wallet/Transaction screen

Device sessions

2. test_fetching_balance_after_offline

Transaction #5, amount is 0.0917851
{'blockNumber': '8130889', 'timeStamp': '1592625671', 'hash': '0x1bc95d8add55d7e075bd9d55ecf950193f1b85e06075904f7e67744c633c7741', 'nonce': '152', 'blockHash': '0x320cb075031c307cf67d6fdca1ec719507fa4a888b3d378af9a312ac55a8566a', 'from': '0x0f3eff5cacee63045be97281316457fb78dd659e', 'contractAddress': '0x101848d5c5bbca18e6b4431eedf6b95e9adf82fa', 'to': '0xf184747445c3b85ceb147dfb136067cb93d95f1d', 'value': '91785100000000000', 'tokenName': 'Weenus 💪', 'tokenSymbol': 'WEENUS', 'tokenDecimal': '18', 'transactionIndex': '67', 'gas': '43297', 'gasPrice': '2000000000', 'gasUsed': '36081', 'cumulativeGasUsed': '4127554', 'input': 'deprecated', 'confirmations': '762'}

Transaction with amount 0.002063456 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D

Device sessions

Passed tests (93)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_delete_chats_via_delete_button
Device sessions

3. test_can_see_all_transactions_in_history
Device sessions

4. test_install_pack_and_send_sticker
Device sessions

5. test_login_with_new_account
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_public_chat_clear_history
Device sessions

10. test_need_help_section
Device sessions

11. test_send_and_open_links
Device sessions

12. test_mobile_data_usage_popup_stop_syncing
Device sessions

13. test_mobile_data_usage_settings
Device sessions

14. test_create_new_group_chat
Device sessions

15. test_sign_typed_message (TestRail link is not found)
Device sessions

16. test_user_can_switch_network
Device sessions

17. test_mobile_data_usage_popup_continue_syncing
Device sessions

18. test_home_view
Device sessions

19. test_open_google_com_via_open_dapp
Device sessions

20. test_share_contact_code_and_wallet_address
Device sessions

21. test_connection_is_secure
Device sessions

22. test_add_to_contacts
Device sessions

23. test_add_account_to_multiaccount_instance_private_key
Device sessions

24. test_refresh_button_browsing_app_webview
Device sessions

25. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

26. test_can_add_existing_ens
Device sessions

27. test_transaction_wrong_password_wallet
Device sessions

28. test_public_chat_messaging
Device sessions

29. test_unread_messages_counter_public_chat
Device sessions

30. test_keycard_send_eth_from_wallet_to_address
Device sessions

31. test_keycard_fetching_balance_after_offline
Device sessions

32. test_keycard_send_transaction_from_daap
Device sessions

33. test_text_message_1_1_chat
Device sessions

34. test_can_use_purchased_stickers_on_recovered_account
Device sessions

35. test_open_transaction_on_etherscan
Device sessions

36. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

37. test_contact_profile_view
Device sessions

38. test_offline_add_new_group_chat_member
Device sessions

39. test_logcat_backup_recovery_phrase
Device sessions

40. test_start_chat_with_ens
Device sessions

41. test_add_and_remove_contact_from_public_chat
Device sessions

42. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

43. test_open_blocked_site
Device sessions

44. test_open_chat_by_pasting_public_key
Device sessions

45. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

46. test_keycard_sign_message_from_daap
Device sessions

47. test_send_non_english_message_to_newly_added_contact
Device sessions

48. test_ens_username_recipient
Device sessions

49. test_token_with_more_than_allowed_decimals
Device sessions

50. test_fetch_more_history_in_empty_chat
Device sessions

51. test_open_public_chat_using_deep_link
Device sessions

52. test_switch_users_and_add_new_account
Device sessions

53. test_add_account_to_multiaccount_instance_generate_new
Device sessions

54. test_copy_contact_code_and_wallet_address
Device sessions

55. test_send_transaction_from_daap
Device sessions

56. test_send_two_transactions_one_after_another_in_dapp
Device sessions

57. test_image_in_one_to_one_send_save_reply
Device sessions

58. test_add_new_keycard_account_and_login
Device sessions

59. test_long_press_delete_clear_all_dapps
Device sessions

60. test_copy_and_paste_messages
Device sessions

61. test_back_forward_buttons_browsing_website
Device sessions

62. test_password_in_logcat_creating_account
Device sessions

63. test_sign_message_from_daap
Device sessions

64. test_dapps_permissions
Device sessions

65. test_request_public_key_status_test_daap
Device sessions

66. test_long_press_to_delete_chat
Device sessions

67. test_log_level_and_fleet
Device sessions

68. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

69. test_recover_account_from_new_user_seedphrase
Device sessions

70. test_send_eth_in_1_1_chat
Device sessions

71. test_send_two_transactions_in_batch_in_dapp
Device sessions

72. test_ens_in_public_and_1_1_chats
Device sessions

73. test_block_user_from_public_chat
Device sessions

74. test_offline_status
Device sessions

75. test_wallet_set_up
Device sessions

76. test_manage_assets
Device sessions

77. test_offline_messaging_1_1_chat
Device sessions

78. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

79. test_send_token_with_7_decimals
Device sessions

80. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

81. test_pass_phrase_validation
Device sessions

82. test_keycard_can_see_all_transactions_in_history
Device sessions

83. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

84. test_send_emoji
Device sessions

85. test_filters_from_daap
Device sessions

86. test_redirect_to_public_chat_tapping_tag_message
Device sessions

87. test_restore_account_from_mnemonic_to_keycard
Device sessions

88. test_send_eth_to_ens_in_chat
Device sessions

89. test_send_eth_from_wallet_to_address
Device sessions

90. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

91. test_messaging_in_different_networks
Device sessions

92. test_collectible_from_wallet_opens_in_browser_view
Device sessions

93. test_insufficient_funds_wallet_positive_balance
Device sessions

@flexsurfer
Add auto-capitalize words to keyboard
df3dec8 
Signed-off-by: andrey <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit df3dec8 into develop Jun 22, 2020
@flexsurfer flexsurfer deleted the fix/dot-comma branch June 22, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees
No one assigned
Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No dot/comma is shown on keyboard when requesting/sending funds
4 participants
@richard-ramos @status-im-auto @Serhy @flexsurfer