Skip to content

Conversation

@at0m1x19
Copy link

Replace usage of close_status_backend_containers fixture

Important changes:

  • remove close_status_backend_containers
  • refactor affected tests
  • improve generation of names for logs/teardown in backend_factory

Closes #7085

@status-im-auto
Copy link
Member

status-im-auto commented Nov 28, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ff2196e #1 2025-11-28 10:57:14 ~4 min linux/status-go 📦zip
✔️ ff2196e #1 2025-11-28 10:57:38 ~4 min macos/status-go 📦zip
✔️ ff2196e #1 2025-11-28 10:58:10 ~4 min windows/status-go 📦zip
✔️ ff2196e #1 2025-11-28 11:05:12 ~12 min linux/nwaku 📦zip
✔️ ff2196e #1 2025-11-28 11:05:52 ~12 min tests-rpc 📄log
✔️ ff2196e #1 2025-11-28 11:20:26 ~27 min tests 📄log
✔️ 744952c #2 2025-11-28 13:21:23 ~4 min linux/status-go 📦zip
✔️ 744952c #2 2025-11-28 13:21:41 ~4 min macos/status-go 📦zip
✔️ 744952c #2 2025-11-28 13:21:54 ~4 min windows/status-go 📦zip
✖️ 744952c #2 2025-11-28 13:22:48 ~5 min tests 📄log
✔️ 744952c #2 2025-11-28 13:28:06 ~11 min linux/nwaku 📦zip
✔️ 744952c #2 2025-11-28 13:33:06 ~15 min tests-rpc 📄log
✔️ 744952c #3 2025-11-28 14:34:24 ~25 min tests 📄log

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.81%. Comparing base (ee01162) to head (744952c).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7162      +/-   ##
===========================================
- Coverage    59.94%   59.81%   -0.13%     
===========================================
  Files          811      811              
  Lines       113220   113220              
===========================================
- Hits         67866    67725     -141     
- Misses       38502    38626     +124     
- Partials      6852     6869      +17     
Flag Coverage Δ
functional 35.01% <ø> (-0.63%) ⬇️
unit 55.39% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 40 files with indirect coverage changes

Copy link
Contributor

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great contribution in your first week!!

@at0m1x19 at0m1x19 force-pushed the test/replace-usage-of-close_status_backend_containers-with-backend_new_profile-fixture-approach branch from ff2196e to 744952c Compare November 28, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace usage of close_status_backend_containers with backend_new_profile fixture approach

4 participants