-
Notifications
You must be signed in to change notification settings - Fork 266
fix: update go-waku to filter peers by protocol #7105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@AlbertoSoutullo can you please try this PR? It fixed the issue for me locally. |
Jenkins Builds
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7105 +/- ##
===========================================
- Coverage 59.82% 59.51% -0.32%
===========================================
Files 804 804
Lines 113847 113847
===========================================
- Hits 68114 67756 -358
- Misses 38806 39147 +341
- Partials 6927 6944 +17
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
What I see now is: Which I assume it is expected, and I don't see any logs in the bootstrap node, so it looks ok. Looks like it cannot connect. Also in the nwaku node I see: Looks like it is retrying each minute? Tomorrow will take a deeper look. |
Fixes:
filterprotocol to the bootstrap node that does not support it #7097Description
Update go-waku to get: