feat!: a new token list approach - wallet sdk token lists integration #6912
+5,345
−35,569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
changed the title
saledjenic
changed the title
Member
Jenkins BuildsClick to see older builds (487)
|
saledjenic
changed the base branch from
develop
to
chore/single-token-manager
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
3 times, most recently
from
5fdbea8 to
119e1b7
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
5 times, most recently
from
13ad01f to
c54bd12
Compare
saledjenic
changed the title
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
3 times, most recently
from
41cffc7 to
96dc9bd
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
from
38cef51 to
4e22c96
Compare
saledjenic
changed the base branch from
develop
to
chore/remove-history-service
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
5 times, most recently
from
934352f to
c107513
Compare
siddarthkay
force-pushed
the
feat/new-token-list-approach
branch
from
68bbd3c to
9ce6817
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
from
9ce6817 to
6e0549f
Compare
siddarthkay
force-pushed
the
feat/new-token-list-approach
branch
from
6e0549f to
eb710dc
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
2 times, most recently
from
10ce4f8 to
ef5d38e
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
2 times, most recently
from
e2cbae5 to
db33310
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
6 times, most recently
from
d9730c9 to
fb62a37
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
3 times, most recently
from
08fdc53 to
360dd3a
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
3 times, most recently
from
0fc0661 to
cecbc5c
Compare
Collaborator
|
@saledjenic FYI, I've removed (pinging you because this was the only open PR with this label ) |
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
5 times, most recently
from
5b88139 to
32018e7
Compare
Since CoinGecko doesn't have data for test tokens new methods introduced in TokenManagerInterface for fetching market data, for both mainnet and test tokens. Mapping tokens in CoinGecko client updated.
Instead of checking all tokens when fetching balances only relevant tokens are processed.
Instead of returning all tokens (atm there are ~15k unique tokens that the app operates with) from all supported lists, this change forms a token list based on `token_balances` table which contains tokens for all accounts, for those tokens includes other tokens that share the same cross chain id and includes all mandatory tokens.
18 decimals for community related tokens is determined by the community creation contract.
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
from
32018e7 to
6fd9ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
General changes:
API changes:
GetBalancesByChaininstead of chain ids and token addresses requirestokenKeys []stringGetTokenListthat was returningListWrapperis replaced byGetAllTokenListsand returns[]*tokenlists.TokenListGetTokensreplaced byGetAllTokensGetCustomTokensremovedFetchPricesinstead ofsymbolsrequires nowtokensKeys []stringFetchMarketValuesinstead ofsymbolsrequires nowtokensKeys []stringGetHourlyMarketValuesinstead ofsymbolrequires nowtokenKey stringGetDailyMarketValuesinstead ofsymbolrequires nowtokenKey stringFetchTokenDetailsinstead ofsymbolsrequires nowtokensKeys []stringNew, convenient functions added to the token manager:
GetTokenByChainAddressGetTokensByChain(chainID uint64) []*tokenlists.TokenGetTokensByChains(chainIDs []uint64) ([]*tokenlists.Token, error)GetAllTokens() []*tokenlists.TokenGetTokenList(id string) (*tokenlists.TokenList, bool)GetAllTokenLists() []*tokenlists.TokenListGetLastTokenListsRefreshTime() (int64, error)Exposed types that have been updated:
RouteInputParamsTokenIDreplaced byTokenKeyTokenIDIsOwnerTokenreplaced byTokenIsOwnerTokenToTokenIDreplaced byToTokenKeySendDetailsFromTokenreplaced byFromTokenKeyToTokenreplaced byToTokenKeyRouterSentTransactionFromTokenreplaced byFromTokenKeyToTokenreplaced byToTokenKeyChainBalance- removedStorageTokenBalancesPerChain- replaced by:TokenAddressTokenChainIDRawBalanceBalanceHasErrorList- removed, array ofTokenListused insteadListWrapper- removedSendTxArgsVersionSymbol- removedFromTokenIDreplaced byFromTokenToTokenIDreplaced byToToken