chore!: cleanup unused cmd

[igor-sirotin]

Removed:

• cmd/bootnode
• cmd/spiff-workflow
• cmd/node-canary
• Some outdated/unused files
• Cleanup references to some non-existent cmd/statusd-prune

Checking clients:

• chore_: bump status-go status-desktop#16711
• chore_: bump status-go status-mobile#21556

[github-actions]

Looks like you have BREAKING CHANGES in your PR.
Please make sure to follow 💔How to introduce breaking changes guide:

Check-list

• Tried to avoid this breaking change
• Updated status-desktop
• Updated status-mobile

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	3180042	#1	2024-11-04 13:50:15	~4 min	windows	📦zip
✔️	3180042	#1	2024-11-04 13:50:28	~4 min	tests-rpc	📄log
✔️	3180042	#1	2024-11-04 13:50:53	~4 min	macos	📦zip
✔️	3180042	#1	2024-11-04 13:51:03	~5 min	ios	📦zip
✔️	3180042	#1	2024-11-04 13:51:06	~5 min	macos	📦zip
✔️	3180042	#1	2024-11-04 13:51:06	~5 min	linux	📦zip
✔️	3180042	#1	2024-11-04 13:52:10	~6 min	android	📦aar
✔️	3180042	#1	2024-11-04 14:19:52	~33 min	tests	📄log

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.84%. Comparing base (b329b15) to head (3180042).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6045      +/-   ##
===========================================
- Coverage    60.88%   60.84%   -0.05%     
===========================================
  Files          811      811              
  Lines       108894   108894              
===========================================
- Hits         66303    66252      -51     
- Misses       34841    34884      +43     
- Partials      7750     7758       +8     

Flag	Coverage Δ
functional	13.08% <ø> (+<0.01%)	⬆️
unit	60.20% <ø> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

[jakubgs]

I don't know if I like the removal of setup in _assets/compose and _assets/systemd for mailserver. It is still quite a valid part of the setup. Mailservers(waku v1 nodes) are still being used in notify.prod fleet, so I don't think removing this stuff makes sense.

[jakubgs]

Why not just move this and BOOTNODE.md to _docs?

[igor-sirotin]

Well, BOOTNODE.md is about running cmd/bootnode, doesn't make sense to keep it if we remove the app.

MAILSERVER.md runs cmd/statusd (which stays for now), so I suppose we could keep it indeed. Though it basically shouldn't be used at this point. If someone needs to run a Mailserver, it's better to checkout some older version, running anything WakuV1 from current state has no guarantees to be correct.

@jakubgs do we have plans to kick notify.prod?

[jakubgs]

As far as I know we can't unless we implement support for Gorush directly in nim-waku, and that's not happening anytime soon.

I'm fine with removing bootnode stuff.

[richard-ramos]

@jakubgs: Mailservers(waku v1 nodes) are still being used in notify.prod fleet,

Why is notify.prod using wakuv1? Is this fleet used only by those users that have not updated their clients to more recent versions?