Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: remove rpclimiter from rpc/chain/client.go #5950

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

friofry
Copy link
Contributor

@friofry friofry commented Oct 16, 2024

Removing rpc limiter usage from rpc/chain/client

Full refactoring will be added here: #5952

Closes #5942

@status-im-auto
Copy link
Member

status-im-auto commented Oct 16, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 7b46060 #1 2024-10-16 12:03:13 ~3 min tests 📄log
✔️ 7b46060 #1 2024-10-16 12:04:25 ~4 min linux 📦zip
✔️ 7b46060 #1 2024-10-16 12:04:51 ~5 min ios 📦zip
✔️ 7b46060 #1 2024-10-16 12:05:06 ~5 min android 📦aar
✔️ 7b46060 #1 2024-10-16 12:05:23 ~5 min tests-rpc 📄log
✔️ 72a4734 #2 2024-10-16 12:09:02 ~2 min android 📦aar
✔️ 72a4734 #2 2024-10-16 12:09:21 ~2 min linux 📦zip
✔️ 72a4734 #2 2024-10-16 12:10:12 ~3 min ios 📦zip
✔️ 72a4734 #2 2024-10-16 12:12:31 ~5 min tests-rpc 📄log
✔️ 72a4734 #2 2024-10-16 12:39:05 ~32 min tests 📄log

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.56%. Comparing base (fadce93) to head (72a4734).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5950      +/-   ##
===========================================
+ Coverage    47.14%   47.56%   +0.42%     
===========================================
  Files          840      842       +2     
  Lines       138167   138231      +64     
===========================================
+ Hits         65138    65751     +613     
+ Misses       65510    64690     -820     
- Partials      7519     7790     +271     
Flag Coverage Δ
functional 10.57% <ø> (?)
unit 46.88% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...althmanager/provider_errors/rpc_provider_errors.go 82.85% <ø> (ø)
rpc/chain/client.go 45.19% <ø> (+16.42%) ⬆️

... and 127 files with indirect coverage changes

proper refactoring will be in a separate PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore_: removal of internal RPS limiter for proxy providers
3 participants