Make profile photos visible by default #3553
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (4)
|
cmd/populate-db/main.go
Outdated
| @@ -359,7 +359,7 @@ func defaultSettings(generatedAccountInfo generator.GeneratedAccountInfo, derive | |||
|
|
|||
| settings.PreviewPrivacy = true | |||
| settings.Currency = "usd" | |||
| settings.ProfilePicturesVisibility = 1 | |||
| settings.ProfilePicturesVisibility = 2 | |||
There was a problem hiding this comment.
it should be probably using some const that we defined somewhere (I know it's not your code, but mine :) ), would you mind pointing it at it?
thanks
There was a problem hiding this comment.
No problem, I changed it to use the constant.
However, to avoid shadowing I had to change the name settings used for the object here (there is a package under that name that is already imported). defaultSettings seems to be an appropriate name because that's exactly what we're creating
There was a problem hiding this comment.
Should we be giving the user the lowest privacy level by default? This approach fixes an expectation without giving the user an opportunity learn about our approach to privacy.
@cammellos @John-44 @pedro-et what are you thoughts on this?
| @@ -33,7 +33,8 @@ func defaultSettings(generatedAccountInfo generator.GeneratedAccountInfo, derive | |||
| s.BackupEnabled = true | |||
| logLevel := "INFO" | |||
| s.LogLevel = &logLevel | |||
| s.ProfilePicturesShowTo = settings.ProfilePicturesShowToContactsOnly | |||
| s.ProfilePicturesShowTo = settings.ProfilePicturesShowToEveryone | |||
There was a problem hiding this comment.
Thank you for your work @alwx . I do have an objection with the nature of this PR, but not with the implementation and your work. If our messenger app is privacy first I'd argue that we should default to a sensible privacy focused setting, settings.ProfilePicturesShowToContactsOnly seems to me to strike that balance.
Otherwise we the concept of ProfilePicturesShowTo and ProfilePicturesVisibility becomes a bit of a gimmick.
The problem of conforming to other messenger conventions and managing the user's expectations should be an exercise in design and communication, not merely giving the user the loosest privacy levels and hoping they find the privacy toggle.
@alwx profile photos shouldn't be visible by default, this 'profile photo visibility' setting should be removed enterally (so that profile photos are always visible). This setting has already been removed from the desktop UI about 6 months ago, and is not featured in the new Mobile designs. So time to get rid of this enterally! @Samyoul there isn't a privacy concern here, because the reason this setting was originally added was nothing to do with privacy (I remember the conversations that led to this setting being added in the first place). The reason this setting exists at all was due to a specific request from our legal team that was only relevant in the context of 'public group chats'. Now that the 'public group chat' functionality has been removed from our product, this legal concern is no longer relevant, hence why this setting should be fully removed. One other comment on the privacy prospective: we treat user avatar images in exactly the same way we treat usernames. A user is free to choose whatever username they want, and they are free to choose whatever avatar image they want or not choose an avatar image at all. If a user doesn't want other users to see their avatar image, they have the option of just not adding an avatar image, or if they really want the user also has an option to use a black or white circle or something like that ;-) |
alwx
force-pushed
the
feature/default-profile-pictures-visibility
branch
from
597c239
to
1a81030
Compare
Fixes status-im/status-mobile#16060