-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Community on SetMuted #2414
base: develop
Are you sure you want to change the base?
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (8)
|
aa64193
to
af09615
Compare
Looks like mute is a desktop only feature, see status-im/status-mobile#12788 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing version bump
@Samyoul is PR still relevant? |
Hey @churik yes it is relevant, but it is something that only impacts desktop. Community mute setting doesn't seem to be active on mobile. |
@Samyoul would you mind to rebase it? |
af09615
to
853d1b3
Compare
Hey @anastasiyaig I've moved the PR back into client testing. In tests this functionality works, and devices update the muted state of communities between devices once a user syncs their devices. |
i've tested this functionality and looks like it works the opposite I do expect. so when i have 2 instances of desktop, same community with same recovered account , both items are synced and then i switch the toggle OFF on one of the devices -> sync devices -> then both instances have the toggle ON (i was expecting it to be OFF) @Samyoul what do u think? Screen.Recording.2022-06-08.at.17.49.15.mov |
@Samyoul shall that be closed? |
Community muted state is sync on initial sync, but muted changes are not subsequently synced.
Check e2e tests with QANotes for QA
This functionality syncs the mute state of communities, we need to test that after a community has initially been synced further changes to the muted option sync between devices.