chore: status-go with nim-sds #19402
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Member
Jenkins BuildsClick to see older builds (223)
|
igor-sirotin
commented
Nov 26, 2025
Ivansete-status
force-pushed
the
chore/status-go-nim-sds
branch
from
7f50f38 to
773af07
Compare
igor-sirotin
commented
Dec 1, 2025
ci/Jenkinsfile.linux
Outdated
| /* nwaku source directory */ | ||
| NWAKU_SOURCE_DIR = "${env.WORKSPACE_TMP}/nwaku" | ||
| /* nim-sds source directory */ | ||
| NIM_SDS_SOURCE_DIR = "${env.WORKSPACE}/nim-sds" |
Contributor
Author
There was a problem hiding this comment.
WORKSPACE_TMP must be used for nwaku and nim-sds.
Suggested change
| NIM_SDS_SOURCE_DIR = "${env.WORKSPACE}/nim-sds" | |
| NIM_SDS_SOURCE_DIR = "${env.WORKSPACE_TMP}/nim-sds" |
Contributor
Author
There was a problem hiding this comment.
I believe we must set NIM_SDS_SOURCE_DIR in all CI jobs.
So we should also set it for android and windows.
mobile/Makefile
Outdated
| IPHONE_SDK="$(IPHONE_SDK)" \ | ||
| IOS_TARGET="$(IOS_TARGET)" \ | ||
| SHELL=/bin/sh | ||
| @cp $(WORKSPACE)/nim-sds/build/libsds$(LIB_EXT) $(LIB_PATH)/libsds$(LIB_EXT) |
Contributor
Author
There was a problem hiding this comment.
What is the WORKSPACE variable you're referencing? The one defined in Jenkins? And how to build it locally then?
Contributor
Author
There was a problem hiding this comment.
We shouldn't reference pure Jenkins variables here. Instead, we should use NIM_SDS_LIB_DIR.
There was a problem hiding this comment.
Should we hard-code the path as in this example?
@cp ../vendor/status-go/build/bin/libstatus$(LIB_EXT) $(LIB_PATH)/libstatus$(LIB_EXT)
mobile/Makefile
Outdated
| HOST_OS="$(HOST_OS)" \ | ||
| GO_GENERATE_CMD="go generate" \ | ||
| SHELL=/bin/sh | ||
| @cp ../vendor/nim-sds/build/libsds$(LIB_EXT) $(LIB_PATH)/libsds$(LIB_EXT) |
Contributor
Author
There was a problem hiding this comment.
Same here, use NIM_SDS_LIB_DIR
Makefile
Outdated
Comment on lines
248
to
249
| STATUSGO_MAKE_PARAMS += NIM_SDS_HEADER_PATH="$(LIBSDS_LIBDIR)" | ||
| STATUSGO_MAKE_PARAMS += NIM_SDS_LIB_PATH="$(GIT_ROOT)/vendor/nim-sds/build/" |
Contributor
Author
There was a problem hiding this comment.
No, status-go should be provided with NIM_SDS_SOURCE_DIR, not binary paths.
igor-sirotin
commented
Dec 1, 2025
Makefile
Outdated
| NIM_EXTRA_PARAMS += --passL:"-L$(LIBWAKU_LIBDIR)" --passL:"-lwaku" | ||
| endif | ||
|
|
||
| NIM_SDS_SOURCE_DIR ?= vendor/nim-sds/ |
Contributor
Author
There was a problem hiding this comment.
Default should be outside the repository. Same as we do for nwaku
Suggested change
| NIM_SDS_SOURCE_DIR ?= vendor/nim-sds/ | |
| NIM_SDS_SOURCE_DIR ?= $(GIT_ROOT)/../nim-sds |
igor-sirotin
commented
Dec 2, 2025
Contributor
Author
There was a problem hiding this comment.
LGTM now, thank you 👍
e2e tests are probably failing because you're upgrading status-go, and I still didn't merge my fix #19283. Will do.
(can't approve as it's my own pr)
| pkg-macos: check-pkg-target-macos $(STATUS_CLIENT_DMG) | ||
| clean-libsds-cache: | ||
| @echo "Cleaning libsds_d from cache..." | ||
| rm -rf ~/.cache/nim/libsds_d |
Contributor
Author
There was a problem hiding this comment.
This seem to be very specific. What's this about? Will it work on Windows?
There was a problem hiding this comment.
This is to avoid compilation issues between macos and iOS. i.e., error such as:
ld: building for 'macOS', but linking in object file
(/Users/ivan/.cache/nim/libsds_d/@m..@svendor@snimbus-build-system@svendor@sNim@slib@ssystem@sexceptions.nim.c.o)
built for 'iOS-simulator'
Ivansete-status
force-pushed
the
chore/status-go-nim-sds
branch
from
727ae41 to
37afaef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.