fix late acquire #7745
Open
fix late acquire #7745
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it has no practical impact on the processor (except if `addBlock` were cancelled, which it never is), the `acquire` should be outside the `finally` (since obvisouly, if it were cancelled it will not be acquired and therefore shouldn't be released)
arnetheduck
force-pushed
the
move-lock
branch
from
80bad2e to
e22897b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it has no practical impact on the processor (except if
addBlockwere cancelled, which it never is), theacquireshould beoutside the
finally(since obvisouly, if it were cancelled it will notbe acquired and therefore shouldn't be released)