Skip to content

work around blob quarantine infinite loop #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

work around blob quarantine infinite loop #7742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions beacon_chain/consensus_object_pools/blob_quarantine.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,18 @@ proc unloadRoot[A, B](quarantine: var SidecarQuarantine[A, B]) =

let blockRoot = quarantine.getOldestInMemoryRoot()

# There's some condition whereby `quarantine.roots` becomes desynced with
# `quarantine.diskUsage`, such that `removeRoot` functions as a no-op and
# the `fitsOnDisk/pruneOnDiskRoot` becomes an infinite loop. Pending some
# more principled/correct approach, kludge around this.
var retries = 0

quarantine.roots.withValue(blockRoot, record):
while not(quarantine.fitsOnDisk(record[].count)):
quarantine.pruneOnDiskRoot()
inc retries
if retries > 10:
break

var res: seq[ref A]
for index in 0 ..< len(record[].sidecars):
Expand Down
Loading