Skip to content

serialization: bump #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2025
Merged

serialization: bump #7345

merged 5 commits into from
Jul 31, 2025

Conversation

arnetheduck
Copy link
Member

Fixes an issue where a crash can be caused if decode is used with a temporary or short-lived variable that gets collectedf due to allocations inside decode.

  • previously, some of the C variables were being evaluated inside noSideEffect by nim-ser by mistake when expanding the decode template - here we have to do it separately

arnetheduck referenced this pull request in status-im/nim-serialization Jul 31, 2025
* Reinstate Nim workaround for decode
* fix multiple expansion of `input` in `decode`
Fixes an issue where a crash can be caused if `decode` is used with a
temporary or short-lived variable that gets collectedf due to
allocations inside decode.

* previously, some of the C variables were being evaluated inside
noSideEffect by nim-ser by mistake when expanding the decode template -
here we have to do it separately
Copy link

github-actions bot commented Jul 31, 2025

Unit Test Results

       15 files  ±0    2 650 suites  ±0   1h 16m 27s ⏱️ +38s
  6 628 tests ±0    6 070 ✔️ ±0  558 💤 ±0  0 ±0 
45 646 runs  ±0  44 864 ✔️ ±0  782 💤 ±0  0 ±0 

Results for commit 5756c72. ± Comparison against base commit fce46a8.

♻️ This comment has been updated with latest results.

@arnetheduck arnetheduck merged commit 930effb into unstable Jul 31, 2025
12 checks passed
@arnetheduck arnetheduck deleted the bump-ser branch July 31, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant