Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

halve CI per-function stack limit to 512KiB #7008

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

halve CI per-function stack limit to 512KiB #7008

wants to merge 1 commit into from

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Mar 12, 2025

It helped catch

so it's worth reducing this further to try to be stricter about catching this category of issues, especially as an eventual migration towards ORC will likely trigger cases here that refc does not.

@tersec
Copy link
Contributor Author

tersec commented Mar 12, 2025

2025-03-12T08:18:09.3648136Z /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim: In function ‘_ZN31runComputeCellsAndKzgProofsTest20runTestX60gensym446_E6string6string’:
2025-03-12T08:18:09.3654243Z /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim:1101:15: error: stack usage is 810624 bytes [-Werror=stack-usage=]
2025-03-12T08:18:09.3655806Z  1101 |   proc runTest(suiteName, testName: string): TestStatus {.raises: [], gensym.} =
2025-03-12T08:18:09.3772737Z       |               ^
2025-03-12T08:18:11.5547683Z /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim: In function ‘_ZN31runRecoverCellsAndKzgProofsTest20runTestX60gensym628_E6string6string’:
2025-03-12T08:18:11.5552215Z /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim:1101:15: error: stack usage is 550864 bytes [-Werror=stack-usage=]
2025-03-12T08:18:17.4333470Z lto1: some warnings being treated as errors
2025-03-12T08:18:17.4747895Z make[2]: *** [/tmp/cc6OF3y9.mk:314: /tmp/ccRnLcUj.ltrans104.ltrans.o] Error 1
2025-03-12T08:18:17.4748638Z make[2]: *** Waiting for unfinished jobs....
2025-03-12T08:19:04.7129896Z /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-chronos/chronos/internal/asyncmacro.nim: In function ‘_ZN16readChunkPayload61readChunkPayload__OOZbeacon95chainZsyncZsync95protocol_u17395E3refIN7futures26FutureBasecolonObjectType_EE’:
2025-03-12T08:19:04.7136066Z /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-chronos/chronos/internal/asyncmacro.nim:445:15: error: stack usage might be 925216 bytes [-Werror=stack-usage=]
2025-03-12T08:19:04.7137688Z   445 |       iteratorNameSym = genSym(nskIterator, $prcName)
2025-03-12T08:19:04.7138264Z       |               ^
2025-03-12T08:19:06.3545889Z lto1: some warnings being treated as errors
2025-03-12T08:19:06.3856353Z make[2]: *** [/tmp/cc6OF3y9.mk:233: /tmp/ccRnLcUj.ltrans77.ltrans.o] Error 1
2025-03-12T08:20:01.5739374Z lto-wrapper: fatal error: make returned 2 exit status
2025-03-12T08:20:01.5740031Z compilation terminated.
2025-03-12T08:20:01.6689826Z /usr/bin/ld: error: lto-wrapper failed
2025-03-12T08:20:01.6817673Z collect2: error: ld returned 1 exit status
2025-03-12T08:20:01.6843928Z make[1]: *** [nimcache/release/all_tests/all_tests.makefile:3752: build] Error 1

Copy link

github-actions bot commented Mar 12, 2025

Unit Test Results

         9 files   -          6    1 578 suites   - 1 052   58m 41s ⏱️ - 19m 28s
  6 339 tests ±         0    5 837 ✔️ ±         0  502 💤 ±    0  0 ±0 
26 468 runs   - 17 648  25 904 ✔️  - 17 534  564 💤  - 114  0 ±0 

Results for commit 0450f96. ± Comparison against base commit eec3f17.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant