VC: Some block monitor fixes #5109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix events block monitor from losing connection forever. Add node to block received log statement.
arnetheduck
reviewed
Jun 22, 2023
| @@ -503,15 +503,15 @@ proc runBlockEventMonitor(service: BlockServiceRef, | |||
|
|
|||
| while true: | |||
| while node.status notin statuses: | |||
| await vc.waitNodes(nil, statuses, roles, false) | |||
| await vc.waitNodes(nil, statuses, roles, true) | |||
There was a problem hiding this comment.
shouldn't this be waiting for the specific node to become connected?
There was a problem hiding this comment.
waitNodes using event which indicates that some of the changes in nodes status happened, so we wait for node status to be changed, checks status, if status is not in {RestBeaconNodeStatus.Synced} it continues to waiting changes.
arnetheduck
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pollblock monitor issue when it deadlocks VC.eventsblock monitor issue when it doesn't recover connection when connection has been lost.nodefield to "Block received" log statement.