ignore EL exchangeTransitionConfiguration
results
#4831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
engine_exchangeTransitionConfigurationV1
isn't useful anymore. It was, arguably, maybe, potentially, temporarily useful (but probably not) during the merge. The merge is over. Even by the extended definition used by some, now that Capella is on mainnet, the merge is over.So now, there's this code that exists for little other reason than to occasionally cause spurious CL/EL communications outages such as seen in https://ci.status.im/blue/organizations/jenkins/nimbus-eth2%2Fplatforms%2Flinux%2Fx86_64/detail/unstable/649/pipeline where
That this wasn't more obvious in logs, or in the wild, is probably due to #4830 where the relevant
newPayload
failing downstream of this timeout inexchangeTransitionConfiguration
causingnimbus-eth2/beacon_chain/eth1/eth1_monitor.nim
Lines 1990 to 1995 in 228e10f
and
nimbus-eth2/beacon_chain/gossip_processing/block_processor.nim
Lines 290 to 297 in 228e10f
causing that single timeout to cascade into a minute's worth of lack of communication with the EL. This PR fixes that.