Skip to content

Conversation

arnetheduck
Copy link
Member

@arnetheduck arnetheduck commented Sep 6, 2022

Since these files may have been created in a previous run or manually,
we want to keep loading them even on nodes that don't enable the
keystore API (for example static setups)

@arnetheduck arnetheduck changed the title Fee recipient load suggested fee recipient file also when keymanager is disabled Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Unit Test Results

       12 files  ±0       860 suites  ±0   1h 9m 5s ⏱️ - 1m 2s
  1 982 tests ±0    1 835 ✔️ ±0  147 💤 ±0  0 ±0 
10 662 runs  ±0  10 472 ✔️ ±0  190 💤 ±0  0 ±0 

Results for commit 50f5ac5. ± Comparison against base commit 80f44f4.

♻️ This comment has been updated with latest results.

@zah
Copy link
Contributor

zah commented Sep 13, 2022

LGTM, but needs rebasing

@arnetheduck
Copy link
Member Author

rebased, and added logging of the fee recipient at different stages

Since these files may have been created in a previous run or manually,
we want to keep loading them even on nodes that don't enable the
keystore API (for example static setups)

* log keystore loading progressively (#3699)
@zah zah merged commit ef8bab5 into unstable Sep 17, 2022
@zah zah deleted the fee-recipient branch September 17, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants