🐼 #3670
Merged
🐼 #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
approved these changes
May 28, 2022
beacon_chain/nimbus_beacon_node.nim
Outdated
| @@ -179,7 +181,8 @@ proc loadChainDag( | |||
| onLCFinalityUpdateCb = onLightClientFinalityUpdateCb, | |||
| onLCOptimisticUpdateCb = onLightClientOptimisticUpdateCb, | |||
| serveLightClientData = config.serveLightClientData.get, | |||
| importLightClientData = config.importLightClientData.get) | |||
| importLightClientData = config.importLightClientData.get, | |||
| pandaTexts = getPandas(detectTTY(config.logStdout))) | |||
There was a problem hiding this comment.
If an additional cmd line argument needed in CI setups to force color output, e.g., when running through docker, will people streaming nimbus terminals need to know about it?
There was a problem hiding this comment.
Yeah, currently, the only ways to see the color ones are to either use --log-format=colors or --log-format=auto (the default) on what Nimbus detects as a TTY.
Whether this works in/through Docker containers depends on the terminal emulation setup, if there's a TTY in Docker.
| QM$Mb .d$b. .d$b. .d$b. .d$b. $$$$$ $\ /$ $: $$ .d$b. $$$$$ $$$$$ $$$b. d$P | ||
| |: d$ $: $$ $b."P $: $$ $: "" [$: [$: Q$:$P $: $$ [$: $P.. $: Q$ .$$; | ||
| Pb"' $: $$ `""b. $$22$ $: mm [$: [$: Q$P $$$$$ [$: $b"" $: d$ `$: | ||
| |$b `Q$P' `MpM; $: $$ `Q$P' [$: $$$$$ `$' $: $$ [$: $$ETH $$$$' mm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.