fix finalized epoch ref loading on checkpoint start #3517
Conversation
regression from #3513 that did not take tail into consideration when loading epoch ancestor
| if epoch == dag.genesis.slot.epoch: | ||
| return EpochKey(bid: dag.genesis, epoch: epoch) | ||
| if epoch < dag.tail.slot.epoch or bid.slot < dag.tail.slot: | ||
| return EpochKey() # We can't load these states |
There was a problem hiding this comment.
Will the callers be able to handle this? This seems to be the first empty EpochKey. Opt[EpochKey] as return could be a clearer alternative.
There was a problem hiding this comment.
maybe, but there's a better approach overall to do this which is outlined in the TODO / #2677, so I don't expect this function to stay around for long - in fact, epoch ancestor == proposer_dependent_root now which is a first step and once those steps are complete, this whole mechanism will go away.
| if bid.slot < dag.tail.slot or epoch < dag.tail.slot.epoch: | ||
| return err() |
There was a problem hiding this comment.
Does this need special handling for the case of tail.slot > tail.slot.epoch.start_slot / epoch == dag.tail.slot.epoch?
There was a problem hiding this comment.
we de-facto don't support non-epoch-start-slot tails, so no :)
|
jenkins crash is light-client related |
regression from #3513 that did not take tail into consideration when
loading epoch ancestor