Fix two bugs in Receipts RLP encoding/decoding #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
force-pushed
the
rlp-receipts-fixes
branch
2 times, most recently
from
712e4ef to
3ac3378
Compare
4 tasks
1. Fix Assertion error when receipt is not a List nor has a single byte value. Receiving such garbage data would cause a crash. 2. Fix decoding of Receipt list by adding the missing Blob encapsulation Also added tests for these scenarios.
kdeme
force-pushed
the
rlp-receipts-fixes
branch
from
3ac3378 to
38ef05f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added tests for these scenarios.