Skip to content

Commit

Permalink
Merge pull request ethereum#2818 from etan-status/err-unavailable
Browse files Browse the repository at this point in the history
Update reserved libp2p error documentation
  • Loading branch information
djrtwo authored Feb 3, 2022
2 parents f2fd673 + 20c8d0d commit 824ff97
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
5 changes: 0 additions & 5 deletions specs/das/p2p-interface.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,6 @@ This builds on top of the protocol identification and encoding spec which was in

Note that DAS networking uses a different protocol prefix: `/eth2/das/req`

The result codes are extended with:
- 3: **ResourceUnavailable** -- when the request was valid but cannot be served at this point in time.

TODO: unify with phase0? Lighthoue already defined this in their response codes enum.

### Messages

#### DASQuery
Expand Down
4 changes: 2 additions & 2 deletions specs/phase0/p2p-interface.md
Original file line number Diff line number Diff line change
Expand Up @@ -569,11 +569,11 @@ The response code can have one of the following values, encoded as a single unsi
The response payload adheres to the `ErrorMessage` schema (described below).
- 3: **ResourceUnavailable** -- the responder does not have requested resource.
The response payload adheres to the `ErrorMessage` schema (described below).
*Note*: This response code is only valid as a response to `BlocksByRange`.
*Note*: This response code is only valid as a response where specified.

Clients MAY use response codes above `128` to indicate alternative, erroneous request-specific responses.

The range `[3, 127]` is RESERVED for future usages, and should be treated as error if not recognized expressly.
The range `[4, 127]` is RESERVED for future usages, and should be treated as error if not recognized expressly.

The `ErrorMessage` schema is:

Expand Down

0 comments on commit 824ff97

Please sign in to comment.