Skip to content

Commit

Permalink
PR feedback from @ppopth
Browse files Browse the repository at this point in the history
  • Loading branch information
hwwhww committed May 23, 2023
1 parent 0b2f604 commit 3247bcf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 17 deletions.
2 changes: 1 addition & 1 deletion specs/bellatrix/beacon-chain.md
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ The Engine API may be used to implement this and similarly defined functions via
```python
def notify_new_payload(self: ExecutionEngine, new_payload_request: NewPayloadRequest) -> bool:
"""
Return ``True`` if and only if ``execution_payload`` is valid with respect to ``self.execution_state``.
Return ``True`` if and only if ``new_payload_request`` is valid with respect to ``self.execution_state``.
"""
...
```
Expand Down
17 changes: 1 addition & 16 deletions specs/deneb/beacon-chain.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
- [Modified `NewPayloadRequest`](#modified-newpayloadrequest)
- [Engine APIs](#engine-apis)
- [Modified `notify_new_payload`](#modified-notify_new_payload)
- [Block processing](#block-processing)
- [Execution payload](#execution-payload)
- [`process_execution_payload`](#process_execution_payload)
- [Testing](#testing)
Expand Down Expand Up @@ -182,25 +181,11 @@ class NewPayloadRequest(object):
```python
def notify_new_payload(self: ExecutionEngine, new_payload_request: NewPayloadRequest) -> bool:
"""
Return ``True`` if and only if ``execution_payload`` is valid with respect to ``self.execution_state``.
Return ``True`` if and only if ``new_payload_request`` is valid with respect to ``self.execution_state``.
"""
...
```

### Block processing

```python
def process_block(state: BeaconState, block: BeaconBlock) -> None:
process_block_header(state, block)
if is_execution_enabled(state, block.body):
process_withdrawals(state, block.body.execution_payload)
process_execution_payload(state, block.body, EXECUTION_ENGINE) # [Modified in Deneb]
process_randao(state, block.body)
process_eth1_data(state, block.body)
process_operations(state, block.body)
process_sync_aggregate(state, block.body.sync_aggregate)
```

#### Execution payload

##### `process_execution_payload`
Expand Down

0 comments on commit 3247bcf

Please sign in to comment.