Skip to content

Laravel 9 support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Laravel 9 support #4

merged 2 commits into from
Sep 15, 2022

Conversation

dave-mills
Copy link
Member

Very minor update; Only the dependencies are changed to allow this new version to run on Laravel 9.

When publishing a release, we should probably make it a major version update; going forward I think we can focus on only using PHP 8+ and Laravel 9+.

@dan-tang-ssd
Copy link

Performed testing with positive result.

Testing summary:

  1. Use faw application for testing, as it has already installed laravel-sql-views v1.0.2
  2. run command "php artisan updatesql", verified 3 database views created in database
  3. In faw application, update laravel-sql-views to branch "laravel-9-support"
  4. run command "php artisan updatesql", verified 3 database views created in database

I think we are ready to proceed.

Below please find detail testing procedure with commands for reference:


 - testing procedure:
  - use faw application for testing, as it has installed laravel-sql-views v1.0.2
  - run command "php artisan updatesql", success

  - Download Github repo "laravel-sql-views" to local development env
  - git clone "laravel-sql-views" in local folder "C:\public\laravel-sql-views"
   - cd c:\public
   - git clone https://github.com/stats4sd/laravel-sql-views

  - laravel-sql-views, get remote branch "laravel-9-support" to local repository
   - git switch -c laravel-9-support remotes/origin/laravel-9-support

  - verify modified files in PR, confirm local repository has latest changes for branch "laravel-9-support"

  - update repository section in faw application "composer.json", point to c:\public\laravel-sql-views

  - faw application, update laravel-sql-views to branch "laravel-9-support"
   - composer require stats4sd/laravel-sql-views dev-laravel-9-support
  
  - faw application, verify laravel-sql-views version is "dev-laravel-9-support" in composer.json and composer.lock

  - run command "php artisan updatesql", success

@dave-mills dave-mills merged commit 8277093 into master Sep 15, 2022
@dave-mills dave-mills deleted the laravel-9-support branch September 15, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants