Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
apps/frontend/vite.config.ts
Outdated
| define: { | ||
| // Prevent Vite from injecting process.env like Webpack DefinePlugin | ||
| "process.env": {}, | ||
| "process.env": "window.process.env", |
There was a problem hiding this comment.
When I run
pnpm --filter frontend run devand open the website in the browser I now get the following error:
env.mjs:8 Uncaught TypeError: Cannot read properties of undefined (reading 'env')
Note
maybe we should setup e2e test (maybe using playwright?) to catch this issues in CI?
There was a problem hiding this comment.
Problem should be fixed now.
maybe we should setup e2e test (maybe using playwright?) to catch this issues in CI?
Sounds good. If you have experience with this, you're very welcome to create a PR for this. ;)
There was a problem hiding this comment.
Sounds good. If you have experience with this, you're very welcome to create a PR for this. ;)
Created a new taks: #46
There was a problem hiding this comment.
Problem should be fixed now.
I can confirm that the error is no longer present 🎉
docs/deploy.md
Outdated
| 13. optional: add an SQL database; by using e.g. the ["Nile" integration](https://vercel.com/marketplace/nile) or by manually setting the environment variable `POSTGRES_URL` | ||
| 14. optional: [create your own OAuth App](https://github.com/settings/developers) and set environment variables `OAUTH_REDIRECT_URI`, `OAUTH_CLIENT_ID` and `OAUTH_CLIENT_SECRET` on Vercel accordingly | ||
| 15. optional: in addition to the Vercel project based on the `apps/backend` folder, create a second project based on the `apps/frontend` folder. No environment variables needed. | ||
| 16. optional: if your Vercel deployments fail but after a redeployment without build cache they work, add an environment variable [`VERCEL_FORCE_NO_BUILD_CACHE`](https://vercel.com/docs/deployments/troubleshoot-a-build#managing-build-cache) with value `1` to force Vercel to not use the build cache. |
There was a problem hiding this comment.
Maybe we can force pnpm to redownload dependencies on install?
{
"installCommand": "pnpm install --frozen-lockfile --prefer-offline=false"
}If this works we can avoid this additional step for users.
There was a problem hiding this comment.
I agree, better make it simple for users.
vercel
bot
temporarily deployed
to
Preview – github-stats-extended-backend
vercel
bot
temporarily deployed
to
Preview – github-stats-extended-backend
2 participants
process.envin frontend